Re: [PATCH] virtio: document ENOSPC
On Tue, 27 May 2025 10:27:19 -0400, "Michael S. Tsirkin" wrote: > drivers handle ENOSPC specially since it's an error one can > get from a working VQ. Document the semantics. > > Reported-by: Parav Pandit > Signed-off-by: Michael S. Tsirkin Reviewed-by: Xuan Zhuo > --- > drivers/virtio/virtio_ring.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c > index b784aab66867..97ab0cce527d 100644 > --- a/drivers/virtio/virtio_ring.c > +++ b/drivers/virtio/virtio_ring.c > @@ -2296,6 +2296,10 @@ static inline int virtqueue_add(struct virtqueue *_vq, > * at the same time (except where noted). > * > * Returns zero or a negative error (ie. ENOSPC, ENOMEM, EIO). > + * > + * NB: ENOSPC is a special code that is only returned on an attempt to add a > + * buffer to a full VQ. It indicates that some buffers are outstanding and > that > + * the operation can be retried after some buffers have been used. > */ > int virtqueue_add_sgs(struct virtqueue *_vq, > struct scatterlist *sgs[], > -- > MST >
RE: [PATCH] virtio: document ENOSPC
> From: Michael S. Tsirkin > Sent: Tuesday, May 27, 2025 7:57 PM > To: [email protected] > Cc: Parav Pandit ; Jason Wang ; > Xuan Zhuo ; Eugenio Pérez > ; [email protected] > Subject: [PATCH] virtio: document ENOSPC > > drivers handle ENOSPC specially since it's an error one can get from a > working VQ. Document the semantics. > > Reported-by: Parav Pandit > Signed-off-by: Michael S. Tsirkin > --- > drivers/virtio/virtio_ring.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c index > b784aab66867..97ab0cce527d 100644 > --- a/drivers/virtio/virtio_ring.c > +++ b/drivers/virtio/virtio_ring.c > @@ -2296,6 +2296,10 @@ static inline int virtqueue_add(struct virtqueue > *_vq, > * at the same time (except where noted). > * > * Returns zero or a negative error (ie. ENOSPC, ENOMEM, EIO). > + * > + * NB: ENOSPC is a special code that is only returned on an attempt to > + add a > + * buffer to a full VQ. It indicates that some buffers are outstanding > + and that > + * the operation can be retried after some buffers have been used. > */ > int virtqueue_add_sgs(struct virtqueue *_vq, > struct scatterlist *sgs[], > -- > MST Reviewed-by: Parav Pandit
Re: [PATCH] virtio: document ENOSPC
On Tue, May 27, 2025 at 10:27 PM Michael S. Tsirkin wrote: > > drivers handle ENOSPC specially since it's an error one can > get from a working VQ. Document the semantics. > > Reported-by: Parav Pandit > Signed-off-by: Michael S. Tsirkin > --- > drivers/virtio/virtio_ring.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c > index b784aab66867..97ab0cce527d 100644 > --- a/drivers/virtio/virtio_ring.c > +++ b/drivers/virtio/virtio_ring.c > @@ -2296,6 +2296,10 @@ static inline int virtqueue_add(struct virtqueue *_vq, > * at the same time (except where noted). > * > * Returns zero or a negative error (ie. ENOSPC, ENOMEM, EIO). > + * > + * NB: ENOSPC is a special code that is only returned on an attempt to add a > + * buffer to a full VQ. It indicates that some buffers are outstanding and > that > + * the operation can be retried after some buffers have been used. > */ > int virtqueue_add_sgs(struct virtqueue *_vq, > struct scatterlist *sgs[], > -- > MST > Acked-by: Jason Wang Thanks
Re: [PATCH] virtio: document ENOSPC
On Tue, May 27, 2025 at 10:28 AM Michael S. Tsirkin wrote: > > drivers handle ENOSPC specially since it's an error one can > get from a working VQ. Document the semantics. > > Reported-by: Parav Pandit > Signed-off-by: Michael S. Tsirkin > --- > drivers/virtio/virtio_ring.c | 4 > 1 file changed, 4 insertions(+) Reviewed-by: Stefan Hajnoczi
