Re: [PATCH] virtio_pci: drop kernel.h

2025-11-18 Thread Michael S. Tsirkin 
On Tue, Nov 18, 2025 at 06:08:37PM -0500, Michael S. Tsirkin wrote:
> UAPI headers really have no business pulling in kernel.h
> Drop it - it does not seem to be needed, either.
> 
> Fixes: 7c1ae151e812 ("virtio_pci: Introduce device parts access commands")
> Cc: "Yishai Hadas" 
> Cc: Alex Williamson 
> Signed-off-by: Michael S. Tsirkin 

Oops. Double checked and it's no good - I just had virtio disabled in
the config by mistake. Pls ignore.

> ---
>  include/uapi/linux/virtio_pci.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/uapi/linux/virtio_pci.h b/include/uapi/linux/virtio_pci.h
> index c691ac210ce2..d1b31efc4d7d 100644
> --- a/include/uapi/linux/virtio_pci.h
> +++ b/include/uapi/linux/virtio_pci.h
> @@ -40,7 +40,6 @@
>  #define _LINUX_VIRTIO_PCI_H
>  
>  #include 
> -#include 
>  
>  #ifndef VIRTIO_PCI_NO_LEGACY
>  
> -- 
> MST

Re: [PATCH] virtio_pci: drop kernel.h

2025-11-18 Thread Jason Wang 
On Wed, Nov 19, 2025 at 7:08 AM Michael S. Tsirkin  wrote:
>
> UAPI headers really have no business pulling in kernel.h
> Drop it - it does not seem to be needed, either.
>
> Fixes: 7c1ae151e812 ("virtio_pci: Introduce device parts access commands")
> Cc: "Yishai Hadas" 
> Cc: Alex Williamson 
> Signed-off-by: Michael S. Tsirkin 
> ---
>  include/uapi/linux/virtio_pci.h | 1 -
>  1 file changed, 1 deletion(-)
>

Acked-by: Jason Wang 

Thanks

Re: [PATCH] virtio_pci: drop kernel.h

2025-11-18 Thread Chaitanya Kulkarni 
On 11/18/25 15:08, Michael S. Tsirkin wrote:
> UAPI headers really have no business pulling in kernel.h
> Drop it - it does not seem to be needed, either.
>
> Fixes: 7c1ae151e812 ("virtio_pci: Introduce device parts access commands")
> Cc: "Yishai Hadas"
> Cc: Alex Williamson
> Signed-off-by: Michael S. Tsirkin

Indeed:

linux-block (discard-ret-value) # grep "kernel\.h" include/uapi/linux/* -ir
include/uapi/linux/virtio_pci.h:#include 

Looks good.

Reviewed-by: Chaitanya Kulkarni 

-ck