Re: [PATCH 2/2] vhost-scsi: Improve error handling in vhost_scsi_make_nexus and tpg
On 6/11/25 9:39 AM, Alok Tiwari wrote: > Use PTR_ERR to return the actual error code when vhost_scsi_make_nexus > fails to create a session, instead of returning -ENOMEM. > This ensures more accurate error propagation. > > Replace NULL with ERR_PTR(ret) in vhost_scsi_make_tpg to follow kernel > conventions for pointer-returning functions, allowing callers to use > IS_ERR and PTR_ERR for proper error handling. > > Signed-off-by: Alok Tiwari Reviewed-by: Mike Christie
Re: [PATCH 2/2] vhost-scsi: Improve error handling in vhost_scsi_make_nexus and tpg
On Wed, Jun 11, 2025 at 07:39:22AM -0700, Alok Tiwari wrote: > Use PTR_ERR to return the actual error code when vhost_scsi_make_nexus > fails to create a session, instead of returning -ENOMEM. > This ensures more accurate error propagation. > > Replace NULL with ERR_PTR(ret) in vhost_scsi_make_tpg to follow kernel > conventions for pointer-returning functions, allowing callers to use > IS_ERR and PTR_ERR for proper error handling. > > Signed-off-by: Alok Tiwari > --- > drivers/vhost/scsi.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature
