Re: [PATCH 20/48] klp-build: Don't use errexit

2026-04-29 Thread Miroslav Benes
On Wed, 22 Apr 2026 21:03:48 -0700, Josh Poimboeuf  wrote:
> The errtrace option (combined with the ERR trap) already serves the same
> function (and more) as errexit, so errexit is redundant.  And it has
> more pitfalls.  Remove it.

Reviewed-by: Miroslav Benes 

-- 
Miroslav




Re: [PATCH 20/48] klp-build: Don't use errexit

2026-04-24 Thread Song Liu
On Wed, Apr 22, 2026 at 9:04 PM Josh Poimboeuf  wrote:
>
> The errtrace option (combined with the ERR trap) already serves the same
> function (and more) as errexit, so errexit is redundant.  And it has
> more pitfalls.  Remove it.
>
> Signed-off-by: Josh Poimboeuf 

Acked-by: Song Liu