Re: [PATCH 4/4] ARM: dts: qcom: msm8974: Start using rpmpd for power domains
On 6/23/25 6:44 PM, Luca Weiss wrote: > On 23-06-2025 2:39 p.m., Konrad Dybcio wrote: >> On 6/21/25 3:19 PM, Luca Weiss wrote: >>> Due to historical reasons all msm8974 boards have used the CX power rail >>> as regulator instead of going through the power domain framework. >>> >>> Since rpmpd has gained msm8974 support quite a bit ago, let's start >>> using it and replace all usages of pm8841_s2 (CX), pm8841_s4 (GFX) and >>> for the boards using pma8084 pma8084_s2 (CX), pma8084_s7 (GFX). >>> >>> For reference, downstream is using GFX power rail as parent-supply for >>> mmcc's OXILI_GDSC GDSC which then is used for GPU, but nothing there is >>> modelled upstream. >> >> if you use an opp table with described rpmpd levels and bind the GFX >> domain to gpucc, it should propagate - check it out > > I don't *really* understand what you mean here. I'd be happy if you provided > an example (or better yet, a patch) for this. sm6115 > > Also msm8974 does not have gpucc, only gcc and mmcc. *oh*... right You would then have to somehow selectively bind the OXILI_GDSC to VDD_GX, for which I don't know if we have a good interface today.. Konrad
Re: [PATCH 4/4] ARM: dts: qcom: msm8974: Start using rpmpd for power domains
On 23-06-2025 2:39 p.m., Konrad Dybcio wrote: On 6/21/25 3:19 PM, Luca Weiss wrote: Due to historical reasons all msm8974 boards have used the CX power rail as regulator instead of going through the power domain framework. Since rpmpd has gained msm8974 support quite a bit ago, let's start using it and replace all usages of pm8841_s2 (CX), pm8841_s4 (GFX) and for the boards using pma8084 pma8084_s2 (CX), pma8084_s7 (GFX). For reference, downstream is using GFX power rail as parent-supply for mmcc's OXILI_GDSC GDSC which then is used for GPU, but nothing there is modelled upstream. if you use an opp table with described rpmpd levels and bind the GFX domain to gpucc, it should propagate - check it out I don't *really* understand what you mean here. I'd be happy if you provided an example (or better yet, a patch) for this. Also msm8974 does not have gpucc, only gcc and mmcc. Signed-off-by: Luca Weiss --- Reviewed-by: Konrad Dybcio Thanks! Regards Luca Konrad
Re: [PATCH 4/4] ARM: dts: qcom: msm8974: Start using rpmpd for power domains
On 6/21/25 3:19 PM, Luca Weiss wrote: > Due to historical reasons all msm8974 boards have used the CX power rail > as regulator instead of going through the power domain framework. > > Since rpmpd has gained msm8974 support quite a bit ago, let's start > using it and replace all usages of pm8841_s2 (CX), pm8841_s4 (GFX) and > for the boards using pma8084 pma8084_s2 (CX), pma8084_s7 (GFX). > > For reference, downstream is using GFX power rail as parent-supply for > mmcc's OXILI_GDSC GDSC which then is used for GPU, but nothing there is > modelled upstream. if you use an opp table with described rpmpd levels and bind the GFX domain to gpucc, it should propagate - check it out > > Signed-off-by: Luca Weiss > --- Reviewed-by: Konrad Dybcio Konrad
