Re: [PATCH V3 0/1] livepatch: Add "stack_order" sysfs attribute

2024-10-03 Thread zhang warden
Hi, Miroslav.

> On Oct 2, 2024, at 19:44, Miroslav Benes  wrote:
> 
> Hello,
> 
> could you also include the selftests as discussed before, please?
> 
> Miroslav

Should I include selftests in one patch?

Regards.
Wardenjohn.





Re: [PATCH V3 0/1] livepatch: Add "stack_order" sysfs attribute

2024-10-03 Thread Petr Mladek
On Thu 2024-10-03 16:06:59, zhang warden wrote:
> Hi,Miroslav.
> 
> >  could you also include the selftests as discussed before, please?
> 
> Should I submit the selftests in one patch?

I would put it into a separate patch from the patch adding the
"stack_order" attribute.

You might split the selftests into more patches if many selftests
are added.

Best Regards,
Petr



Re: [PATCH V3 0/1] livepatch: Add "stack_order" sysfs attribute

2024-10-02 Thread Miroslav Benes
Hello,

On Sun, 29 Sep 2024, Wardenjohn wrote:

> As previous discussion, maintainers think that patch-level sysfs interface is 
> the
> only acceptable way to maintain the information of the order that klp_patch 
> is 
> applied to the system.
> 
> However, the previous patch introduce klp_ops into klp_func is a optimization 
> methods of the patch introducing 'using' feature to klp_func.
> 
> But now, we don't support 'using' feature to klp_func and make 'klp_ops' patch
> not necessary.
> 
> Therefore, this new version is only introduce the sysfs feature of klp_patch 
> 'stack_order'.

could you also include the selftests as discussed before, please?

Miroslav