Re: [PATCH bpf v1 1/2] bpf: fix link info netfilter flags to populate defrag flag

2024-10-16 Thread Daniel Borkmann 

On 10/15/24 5:25 PM, Florian Westphal wrote:

Tyrone Wu  wrote:

This patch correctly populates the `bpf_link_info.netfilter.flags` field
when user passes the `BPF_F_NETFILTER_IP_DEFRAG` flag.


Indeed, thanks for fixing this.
Patch and testcase look good, but one nit:


Fixes: 84601d6ee68a ("bpf: add bpf_link support for BPF_NETFILTER programs")


BPF_F_NETFILTER_IP_DEFRAG flag was added in
91721c2d02d3 ("netfilter: bpf: Support BPF_F_NETFILTER_IP_DEFRAG in netfilter 
link"), that was a bit later than the initial support.

Other than that,
Acked-by: Florian Westphal 


Thanks Florian & Tyrone, fixed up Fixes tag while applying.

Re: [PATCH bpf v1 1/2] bpf: fix link info netfilter flags to populate defrag flag

2024-10-16 Thread patchwork-bot+netdevbpf 
Hello:

This series was applied to bpf/bpf.git (master)
by Daniel Borkmann :

On Fri, 11 Oct 2024 19:32:51 + you wrote:
> This patch correctly populates the `bpf_link_info.netfilter.flags` field
> when user passes the `BPF_F_NETFILTER_IP_DEFRAG` flag.
> 
> Fixes: 84601d6ee68a ("bpf: add bpf_link support for BPF_NETFILTER programs")
> Signed-off-by: Tyrone Wu 
> ---
>  net/netfilter/nf_bpf_link.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Here is the summary with links:
  - [bpf,v1,1/2] bpf: fix link info netfilter flags to populate defrag flag
https://git.kernel.org/bpf/bpf/c/92f3715e1eba
  - [bpf,v1,2/2] selftests/bpf: add asserts for netfilter link info
https://git.kernel.org/bpf/bpf/c/2aa587fd6659

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: [PATCH bpf v1 1/2] bpf: fix link info netfilter flags to populate defrag flag

2024-10-15 Thread Florian Westphal 
Tyrone Wu  wrote:
> This patch correctly populates the `bpf_link_info.netfilter.flags` field
> when user passes the `BPF_F_NETFILTER_IP_DEFRAG` flag.

Indeed, thanks for fixing this.
Patch and testcase look good, but one nit:

> Fixes: 84601d6ee68a ("bpf: add bpf_link support for BPF_NETFILTER programs")

BPF_F_NETFILTER_IP_DEFRAG flag was added in
91721c2d02d3 ("netfilter: bpf: Support BPF_F_NETFILTER_IP_DEFRAG in netfilter 
link"), that was a bit later than the initial support.

Other than that,
Acked-by: Florian Westphal