Re: [PATCH net] vsock/virtio: fix `rx_bytes` accounting for stream sockets
On Thu, Jun 12, 2025 at 04:55:14PM +0800, Xuewei Niu wrote: On Thu, 12 Jun 2025 at 10:21, Xuewei Niu wrote: > > > On Thu, 12 Jun 2025 at 08:50, Xuewei Niu wrote: > > > > > > > On Thu, Jun 12, 2025 at 01:32:01PM +0800, Xuewei Niu wrote: > > > > > No comments since last month. > > > > > > > > > > The patch [1], which adds SIOCINQ ioctl support for vsock, depends on this > > > > > patch. Could I get more eyes on this one? > > > > > > > > > > [1]: https://lore.kernel.org/lkml/bbn4lvdwh42m2zvi3rdyws66y5ulew32rchtz3kxirqlllkr63@7toa4tcepax3/#t > > > > > > > > > > Thanks, > > > > > Xuewei > > > > > > > > it's been in net for two weeks now, no? > > > > > > Umm sorry, I didn't check the date carefully, because there are several > > > ongoing patches. Next time I'll check it carefully. Sorry again. > > > > > > It looks like no one is paying attention to this patch. I am requesting > > > someone interested in vsock to review this. I'd appreciate that! > > > > Which patch do you mean? > > > > Thanks, > > Stefano > > I am saying your patch, "vsock/virtio: fix `rx_bytes` accounting for stream > sockets". > > Once this gets merged, I will send a new version of my patch to support > SIOCINQ ioctl. Thus, I can reuse `rx_bytes` to count unread bytes, as we > discussed. As Michael pointed out, it was merged several weeks ago in net tree, see https://lore.kernel.org/netdev/174827942876.985160.7017354014266756923.git-patchwork-not...@kernel.org/ And it also landed in Linus tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=45ca7e9f0730ae36fc610e675b990e9cc9ca0714 I misunderstood Michael's point. I am new to this, and not familiar with the process. Sorry about that... Don't worry ;-) Hope now it's clear! Thanks, Stefano
Re: [PATCH net] vsock/virtio: fix `rx_bytes` accounting for stream sockets
> On Thu, 12 Jun 2025 at 10:21, Xuewei Niu wrote: > > > > > On Thu, 12 Jun 2025 at 08:50, Xuewei Niu wrote: > > > > > > > > > On Thu, Jun 12, 2025 at 01:32:01PM +0800, Xuewei Niu wrote: > > > > > > No comments since last month. > > > > > > > > > > > > The patch [1], which adds SIOCINQ ioctl support for vsock, depends > > > > > > on this > > > > > > patch. Could I get more eyes on this one? > > > > > > > > > > > > [1]: > > > > > > https://lore.kernel.org/lkml/bbn4lvdwh42m2zvi3rdyws66y5ulew32rchtz3kxirqlllkr63@7toa4tcepax3/#t > > > > > > > > > > > > Thanks, > > > > > > Xuewei > > > > > > > > > > it's been in net for two weeks now, no? > > > > > > > > Umm sorry, I didn't check the date carefully, because there are several > > > > ongoing patches. Next time I'll check it carefully. Sorry again. > > > > > > > > It looks like no one is paying attention to this patch. I am requesting > > > > someone interested in vsock to review this. I'd appreciate that! > > > > > > Which patch do you mean? > > > > > > Thanks, > > > Stefano > > > > I am saying your patch, "vsock/virtio: fix `rx_bytes` accounting for stream > > sockets". > > > > Once this gets merged, I will send a new version of my patch to support > > SIOCINQ ioctl. Thus, I can reuse `rx_bytes` to count unread bytes, as we > > discussed. > > As Michael pointed out, it was merged several weeks ago in net tree, > see > https://lore.kernel.org/netdev/174827942876.985160.7017354014266756923.git-patchwork-not...@kernel.org/ > And it also landed in Linus tree: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=45ca7e9f0730ae36fc610e675b990e9cc9ca0714 I misunderstood Michael's point. I am new to this, and not familiar with the process. Sorry about that... > So, I think you can go head with your patch, right? > > Please remember to target net-next, since it will be a new feature IIRC. > > Thanks, > Stefano Yes, I'll do it ASAP. Thanks, Xuewei
Re: [PATCH net] vsock/virtio: fix `rx_bytes` accounting for stream sockets
On Thu, 12 Jun 2025 at 10:21, Xuewei Niu wrote: > > > On Thu, 12 Jun 2025 at 08:50, Xuewei Niu wrote: > > > > > > > On Thu, Jun 12, 2025 at 01:32:01PM +0800, Xuewei Niu wrote: > > > > > No comments since last month. > > > > > > > > > > The patch [1], which adds SIOCINQ ioctl support for vsock, depends on > > > > > this > > > > > patch. Could I get more eyes on this one? > > > > > > > > > > [1]: > > > > > https://lore.kernel.org/lkml/bbn4lvdwh42m2zvi3rdyws66y5ulew32rchtz3kxirqlllkr63@7toa4tcepax3/#t > > > > > > > > > > Thanks, > > > > > Xuewei > > > > > > > > it's been in net for two weeks now, no? > > > > > > Umm sorry, I didn't check the date carefully, because there are several > > > ongoing patches. Next time I'll check it carefully. Sorry again. > > > > > > It looks like no one is paying attention to this patch. I am requesting > > > someone interested in vsock to review this. I'd appreciate that! > > > > Which patch do you mean? > > > > Thanks, > > Stefano > > I am saying your patch, "vsock/virtio: fix `rx_bytes` accounting for stream > sockets". > > Once this gets merged, I will send a new version of my patch to support > SIOCINQ ioctl. Thus, I can reuse `rx_bytes` to count unread bytes, as we > discussed. As Michael pointed out, it was merged several weeks ago in net tree, see https://lore.kernel.org/netdev/174827942876.985160.7017354014266756923.git-patchwork-not...@kernel.org/ And it also landed in Linus tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=45ca7e9f0730ae36fc610e675b990e9cc9ca0714 So, I think you can go head with your patch, right? Please remember to target net-next, since it will be a new feature IIRC. Thanks, Stefano
Re: [PATCH net] vsock/virtio: fix `rx_bytes` accounting for stream sockets
> On Thu, 12 Jun 2025 at 08:50, Xuewei Niu wrote: > > > > > On Thu, Jun 12, 2025 at 01:32:01PM +0800, Xuewei Niu wrote: > > > > No comments since last month. > > > > > > > > The patch [1], which adds SIOCINQ ioctl support for vsock, depends on > > > > this > > > > patch. Could I get more eyes on this one? > > > > > > > > [1]: > > > > https://lore.kernel.org/lkml/bbn4lvdwh42m2zvi3rdyws66y5ulew32rchtz3kxirqlllkr63@7toa4tcepax3/#t > > > > > > > > Thanks, > > > > Xuewei > > > > > > it's been in net for two weeks now, no? > > > > Umm sorry, I didn't check the date carefully, because there are several > > ongoing patches. Next time I'll check it carefully. Sorry again. > > > > It looks like no one is paying attention to this patch. I am requesting > > someone interested in vsock to review this. I'd appreciate that! > > Which patch do you mean? > > Thanks, > Stefano I am saying your patch, "vsock/virtio: fix `rx_bytes` accounting for stream sockets". Once this gets merged, I will send a new version of my patch to support SIOCINQ ioctl. Thus, I can reuse `rx_bytes` to count unread bytes, as we discussed. Thanks, Xuewei
Re: [PATCH net] vsock/virtio: fix `rx_bytes` accounting for stream sockets
On Thu, 12 Jun 2025 at 08:50, Xuewei Niu wrote: > > > On Thu, Jun 12, 2025 at 01:32:01PM +0800, Xuewei Niu wrote: > > > No comments since last month. > > > > > > The patch [1], which adds SIOCINQ ioctl support for vsock, depends on this > > > patch. Could I get more eyes on this one? > > > > > > [1]: > > > https://lore.kernel.org/lkml/bbn4lvdwh42m2zvi3rdyws66y5ulew32rchtz3kxirqlllkr63@7toa4tcepax3/#t > > > > > > Thanks, > > > Xuewei > > > > it's been in net for two weeks now, no? > > Umm sorry, I didn't check the date carefully, because there are several > ongoing patches. Next time I'll check it carefully. Sorry again. > > It looks like no one is paying attention to this patch. I am requesting > someone interested in vsock to review this. I'd appreciate that! Which patch do you mean? Thanks, Stefano
Re: [PATCH net] vsock/virtio: fix `rx_bytes` accounting for stream sockets
On Thu, Jun 12, 2025 at 01:32:01PM +0800, Xuewei Niu wrote: > No comments since last month. > > The patch [1], which adds SIOCINQ ioctl support for vsock, depends on this > patch. Could I get more eyes on this one? > > [1]: > https://lore.kernel.org/lkml/bbn4lvdwh42m2zvi3rdyws66y5ulew32rchtz3kxirqlllkr63@7toa4tcepax3/#t > > Thanks, > Xuewei it's been in net for two weeks now, no?
Re: [PATCH net] vsock/virtio: fix `rx_bytes` accounting for stream sockets
> On Thu, Jun 12, 2025 at 01:32:01PM +0800, Xuewei Niu wrote: > > No comments since last month. > > > > The patch [1], which adds SIOCINQ ioctl support for vsock, depends on this > > patch. Could I get more eyes on this one? > > > > [1]: > > https://lore.kernel.org/lkml/bbn4lvdwh42m2zvi3rdyws66y5ulew32rchtz3kxirqlllkr63@7toa4tcepax3/#t > > > > Thanks, > > Xuewei > > it's been in net for two weeks now, no? Umm sorry, I didn't check the date carefully, because there are several ongoing patches. Next time I'll check it carefully. Sorry again. It looks like no one is paying attention to this patch. I am requesting someone interested in vsock to review this. I'd appreciate that! Thanks, Xuewei
Re: [PATCH net] vsock/virtio: fix `rx_bytes` accounting for stream sockets
No comments since last month. The patch [1], which adds SIOCINQ ioctl support for vsock, depends on this patch. Could I get more eyes on this one? [1]: https://lore.kernel.org/lkml/bbn4lvdwh42m2zvi3rdyws66y5ulew32rchtz3kxirqlllkr63@7toa4tcepax3/#t Thanks, Xuewei
Re: [PATCH net] vsock/virtio: fix `rx_bytes` accounting for stream sockets
Hello: This patch was applied to netdev/net.git (main) by Paolo Abeni : On Wed, 21 May 2025 14:17:05 +0200 you wrote: > From: Stefano Garzarella > > In `struct virtio_vsock_sock`, we maintain two counters: > - `rx_bytes`: used internally to track how many bytes have been read. > This supports mechanisms like .stream_has_data() and sock_rcvlowat(). > - `fwd_cnt`: used for the credit mechanism to inform available receive > buffer space to the remote peer. > > [...] Here is the summary with links: - [net] vsock/virtio: fix `rx_bytes` accounting for stream sockets https://git.kernel.org/netdev/net/c/45ca7e9f0730 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
