Re: [PATCH net-next v6 0/5] vsock: SOCK_LINGER rework
Hello: This series was applied to netdev/net-next.git (main) by Paolo Abeni : On Thu, 22 May 2025 01:18:20 +0200 you wrote: > Change vsock's lingerning to wait on close() until all data is sent, i.e. > until workers picked all the packets for processing. > > Changes in v6: > - Make vsock_wait_sent() return bool, parametrize enable_so_linger() with > timeout, don't open code DIV_ROUND_UP [Stefano] > - Link to v5: > https://lore.kernel.org/r/[email protected] > > [...] Here is the summary with links: - [net-next,v6,1/5] vsock/virtio: Linger on unsent data https://git.kernel.org/netdev/net-next/c/1c39f5dbbfd2 - [net-next,v6,2/5] vsock: Move lingering logic to af_vsock core https://git.kernel.org/netdev/net-next/c/5ec40864aaec - [net-next,v6,3/5] vsock/test: Introduce vsock_wait_sent() helper https://git.kernel.org/netdev/net-next/c/e78e0596c762 - [net-next,v6,4/5] vsock/test: Introduce enable_so_linger() helper https://git.kernel.org/netdev/net-next/c/8b07b7e5c253 - [net-next,v6,5/5] vsock/test: Add test for an unexpectedly lingering close() https://git.kernel.org/netdev/net-next/c/393d070135ad You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next v6 0/5] vsock: SOCK_LINGER rework
On 5/22/25 10:08, Stefano Garzarella wrote: > On Thu, May 22, 2025 at 01:18:20AM +0200, Michal Luczaj wrote: >> Change vsock's lingerning to wait on close() until all data is sent, i.e. >> until workers picked all the packets for processing. > > Thanks for the series and the patience :-) > > LGTM! There should be my R-b for all patches. I think it went smoothly, thanks for the reviews :) Michal
Re: [PATCH net-next v6 0/5] vsock: SOCK_LINGER rework
On Thu, May 22, 2025 at 01:18:20AM +0200, Michal Luczaj wrote: Change vsock's lingerning to wait on close() until all data is sent, i.e. until workers picked all the packets for processing. Thanks for the series and the patience :-) LGTM! There should be my R-b for all patches. Thanks, Stefano Changes in v6: - Make vsock_wait_sent() return bool, parametrize enable_so_linger() with timeout, don't open code DIV_ROUND_UP [Stefano] - Link to v5: https://lore.kernel.org/r/[email protected] Changes in v5: - Move unsent_bytes fetching logic to utils.c - Add a helper for enabling SO_LINGER - Accommodate for close() taking a long time for reasons unrelated to lingering - Separate and redo the testcase [Stefano] - Enrich the comment [Stefano] - Link to v4: https://lore.kernel.org/r/[email protected] Changes in v4: - While in virtio, stick to virtio_transport_unsent_bytes() [Stefano] - Squash the indentation reduction [Stefano] - Pull SOCK_LINGER check into vsock_linger() [Stefano] - Don't explicitly pass sk->sk_lingertime [Stefano] - Link to v3: https://lore.kernel.org/r/[email protected] Changes in v3: - Set "vsock/virtio" topic where appropriate - Do not claim that Hyper-V and VMCI ever lingered [Stefano] - Move lingering to af_vsock core [Stefano] - Link to v2: https://lore.kernel.org/r/[email protected] Changes in v2: - Comment that some transports do not implement unsent_bytes [Stefano] - Reduce the indentation of virtio_transport_wait_close() [Stefano] - Do not linger on shutdown(), expand the commit messages [Paolo] - Link to v1: https://lore.kernel.org/r/[email protected] Changes in v1: - Do not assume `unsent_bytes()` is implemented by all transports [Stefano] - Link to v0: https://lore.kernel.org/netdev/[email protected]/ Signed-off-by: Michal Luczaj --- Michal Luczaj (5): vsock/virtio: Linger on unsent data vsock: Move lingering logic to af_vsock core vsock/test: Introduce vsock_wait_sent() helper vsock/test: Introduce enable_so_linger() helper vsock/test: Add test for an unexpectedly lingering close() include/net/af_vsock.h | 1 + net/vmw_vsock/af_vsock.c| 33 + net/vmw_vsock/virtio_transport_common.c | 21 + tools/testing/vsock/util.c | 38 +++ tools/testing/vsock/util.h | 2 + tools/testing/vsock/vsock_test.c| 83 +++-- 6 files changed, 134 insertions(+), 44 deletions(-) --- base-commit: f44092606a3f153bb7e6b277006b1f4a5b914cfc change-id: 20250304-vsock-linger-9026e5f9986c Best regards, -- Michal Luczaj
