Re: [PATCH v1 1/4] iommu: Move Hyper-V IOMMU driver to its own subdirectory
On Wed, May 20, 2026 at 02:37:03PM +0800, Yu Zhang wrote: > On Fri, May 15, 2026 at 07:19:18PM -0300, Jason Gunthorpe wrote: > > On Tue, May 12, 2026 at 12:24:05AM +0800, Yu Zhang wrote: > > > From: Easwar Hariharan > > > > > > The Hyper-V IOMMU driver currently only supports IRQ remapping. > > > As it will be adding DMA remapping support, prepare a directory > > > to contain all the different feature files. > > > > Any possibility we could put the irq remapping thing under the irq > > directory? > > > > The other drivers have it here because they are co-mingled with their > > iommu HW, will hyperv have the same issue? > > > > Good question. I don't think Hyper-V have the same co-mingling issue. > > But from a code organization perspective, I think drivers/iommu/hyperv/ > is still the most natural place: > > - The IRQ remapping framework itself (drivers/iommu/irq_remapping.c > and its internal header irq_remapping.h) lives under drivers/iommu/, > and all three backends (intel/, amd/, hyperv/) sit there today. > hyperv/irq_remapping.c includes that internal header directly. IMHO it is a fair question if that even belongs under iommu. I think it was dumped into here because of the co-mingled drivers.. Jason
Re: [PATCH v1 1/4] iommu: Move Hyper-V IOMMU driver to its own subdirectory
On Fri, May 15, 2026 at 07:19:18PM -0300, Jason Gunthorpe wrote: > On Tue, May 12, 2026 at 12:24:05AM +0800, Yu Zhang wrote: > > From: Easwar Hariharan > > > > The Hyper-V IOMMU driver currently only supports IRQ remapping. > > As it will be adding DMA remapping support, prepare a directory > > to contain all the different feature files. > > Any possibility we could put the irq remapping thing under the irq > directory? > > The other drivers have it here because they are co-mingled with their > iommu HW, will hyperv have the same issue? > Good question. I don't think Hyper-V have the same co-mingling issue. But from a code organization perspective, I think drivers/iommu/hyperv/ is still the most natural place: - The IRQ remapping framework itself (drivers/iommu/irq_remapping.c and its internal header irq_remapping.h) lives under drivers/iommu/, and all three backends (intel/, amd/, hyperv/) sit there today. hyperv/irq_remapping.c includes that internal header directly. - irq_remapping_prepare() references the extern hyperv_irq_remap_ops declared in that header, so the provider naturally belongs in the same tree. Moving it to e.g. drivers/irqchip/ would break that symmetry. Yu > Jason >
Re: [PATCH v1 1/4] iommu: Move Hyper-V IOMMU driver to its own subdirectory
On Tue, May 12, 2026 at 12:24:05AM +0800, Yu Zhang wrote: > From: Easwar Hariharan > > The Hyper-V IOMMU driver currently only supports IRQ remapping. > As it will be adding DMA remapping support, prepare a directory > to contain all the different feature files. Any possibility we could put the irq remapping thing under the irq directory? The other drivers have it here because they are co-mingled with their iommu HW, will hyperv have the same issue? Jason
