Re: [PATCH v1 1/7] mfd: stmpe-spi: Correct the name used in MODULE_DEVICE_TABLE

2025-05-01 Thread Lee Jones
On Sun, 27 Apr 2025, Krzysztof Kozlowski wrote:

> On 26/04/2025 18:16, Alexey Gladkov wrote:
> > The name used in the macro does not exist.
> > 
> > drivers/mfd/stmpe-spi.c:132:26: error: use of undeclared identifier 
> > 'stmpe_id'
> >   132 | MODULE_DEVICE_TABLE(spi, stmpe_id);
> >   |  ^
> > 1 error generated.
> 
> 
> Reviewed-by: Krzysztof Kozlowski 
> 
> P.S. You can trim the error messages to relevant parts, e.g. "1 error
> generated" is really redundant and not needed to store in git history.

Trimmed on apply, thanks.

-- 
Lee Jones [李琼斯]



Re: [PATCH v1 1/7] mfd: stmpe-spi: Correct the name used in MODULE_DEVICE_TABLE

2025-04-27 Thread Krzysztof Kozlowski
On 26/04/2025 18:16, Alexey Gladkov wrote:
> The name used in the macro does not exist.
> 
> drivers/mfd/stmpe-spi.c:132:26: error: use of undeclared identifier 'stmpe_id'
>   132 | MODULE_DEVICE_TABLE(spi, stmpe_id);
>   |  ^
> 1 error generated.


Reviewed-by: Krzysztof Kozlowski 

P.S. You can trim the error messages to relevant parts, e.g. "1 error
generated" is really redundant and not needed to store in git history.

> 

Best regards,
Krzysztof