Re: [PATCH v2 09/16] tools/nolibc: add limits.h shim header

[Willy Tarreau]

On Wed, Feb 26, 2025 at 12:44:48PM +0100, Thomas Weißschuh wrote:
> limits.h is a widely used standard header.
> Missing it from nolibc requires adoption effort to port applications.
> 
> Add a shim header which includes the global nolibc.h header.
> It makes all nolibc symbols available.
> 
> Signed-off-by: Thomas Weißschuh 

Works fine here. Pick any combination you'd like of those below ;-)

  Acked-by: Willy Tarreau 
  Tested-by: Willy Tarreau 

Thanks!
Willy

Re: [PATCH v2 09/16] tools/nolibc: add limits.h shim header

[Vincenzo Frascino]

On 26/02/2025 11:44, Thomas Weißschuh wrote:
> limits.h is a widely used standard header.
> Missing it from nolibc requires adoption effort to port applications.
> 
> Add a shim header which includes the global nolibc.h header.
> It makes all nolibc symbols available.
> 
> Signed-off-by: Thomas Weißschuh 

Reviewed-by: Vincenzo Frascino 

> ---
>  tools/include/nolibc/Makefile | 1 +
>  tools/include/nolibc/limits.h | 7 +++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/tools/include/nolibc/Makefile b/tools/include/nolibc/Makefile
> index 
> a1f55fb24bb38c1f49c653af5825e8bcc569a56d..c1299a053145786da89001a5f95f5527ffbe2fa4
>  100644
> --- a/tools/include/nolibc/Makefile
> +++ b/tools/include/nolibc/Makefile
> @@ -30,6 +30,7 @@ all_files := \
>   crt.h \
>   ctype.h \
>   errno.h \
> + limits.h \
>   nolibc.h \
>   signal.h \
>   stackprotector.h \
> diff --git a/tools/include/nolibc/limits.h b/tools/include/nolibc/limits.h
> new file mode 100644
> index 
> ..306d4141f4d245ca3f801f451745540b0f7294cd
> --- /dev/null
> +++ b/tools/include/nolibc/limits.h
> @@ -0,0 +1,7 @@
> +/* SPDX-License-Identifier: LGPL-2.1 OR MIT */
> +/*
> + * Shim limits.h header for NOLIBC.
> + * Copyright (C) 2025 Thomas Weißschuh 
> + */
> +
> +#include "nolibc.h"
> 

-- 
Regards,
Vincenzo