Re: [PATCH v4 6/7] modpost: Add modname to mod_device_table alias
On Sat, 21 Jun 2025 17:20:49 +0200 Miguel Ojeda wrote: > On Sat, Jun 21, 2025 at 3:57 PM Alexey Gladkov wrote: >> >> +/* Format: __mod_device_table__kmod_ */ > > Should we mention that `__kmod_` and `__` will be the search strings, > or otherwise the Rust formatting (i.e. that is carries a line etc.)? > > Cc'ing Tomo: do we need an update on `rust/kernel/net/phy.rs`? Should > we factor out the formatting? Yeah, looks like the update is necessary. Thanks for the heads-up. I've just send a patchset to convert the PHY abstractions to use device_id crate: https://lore.kernel.org/lkml/[email protected]/
Re: [PATCH v4 6/7] modpost: Add modname to mod_device_table alias
On Sat, Jun 21, 2025 at 05:20:49PM +0200, Miguel Ojeda wrote: > On Sat, Jun 21, 2025 at 3:57 PM Alexey Gladkov wrote: > > > > +/* Format: __mod_device_table__kmod_ */ > > Should we mention that `__kmod_` and `__` will be the search strings, > or otherwise the Rust formatting (i.e. that is carries a line etc.)? Ok. Make sense. Basically there's a comment for the MODULE_DEVICE_TABLE macro that tells where and how that symbol is parsed. > Cc'ing Tomo: do we need an update on `rust/kernel/net/phy.rs`? Should > we factor out the formatting? > > Thanks! > > Cheers, > Miguel > -- Rgrds, legion
Re: [PATCH v4 6/7] modpost: Add modname to mod_device_table alias
On Sat, Jun 21, 2025 at 3:57 PM Alexey Gladkov wrote: > > +/* Format: __mod_device_table__kmod_ */ Should we mention that `__kmod_` and `__` will be the search strings, or otherwise the Rust formatting (i.e. that is carries a line etc.)? Cc'ing Tomo: do we need an update on `rust/kernel/net/phy.rs`? Should we factor out the formatting? Thanks! Cheers, Miguel
Re: [PATCH v4 6/7] modpost: Add modname to mod_device_table alias
On Sat, Jun 21, 2025 at 3:57 PM Alexey Gladkov wrote: > > rust/kernel/device_id.rs | 8 Cc'ing maintainers and list. Cheers, Miguel
