Re: [RFT net-next v4 0/2] net: Split ndo_set_rx_mode into snapshot and deferred write
On Wed, 19 Nov 2025 09:27:58 +0530 I Viswanath wrote: > > Also I'm not sure what you mean by RFT, doubt anyone will test this > > for you, and you're modifying virtio which you should be able to test > > yourself.. RFC or PATCH is the choice. > > Just to be clear, would testing packet flow with all the possible mode > combinations > under heavy traffic be sufficient and exhaustive? I think this should > be PATCH once I sort everything out I don't think traffic matters all that much, we're talking about control path change. It's more important to exercise all the address lists (l2 unicast, multicast) and rx modes (promisc, allmulti) etc. Then whatever other paths may load to touching the relevant state in the driver (eg virtnet_freeze_down(), not triggers that, suspend?, migration?). In terms of traffic simple ping or a few UDP packets would be enough, mostly to confirm the filtering is working as expected.
Re: [RFT net-next v4 0/2] net: Split ndo_set_rx_mode into snapshot and deferred write
On Wed, 19 Nov 2025 at 00:20, Jakub Kicinski wrote: > > Broken as in patch titles or broken as in it crashes the kernel? > Both are true. Yeah, I will fix both > Just to be safe "as soon as possible" hopefully > takes into account our "no reposts within 24h" rule. > https://www.kernel.org/doc/html/next/process/maintainer-netdev.html Yes, It does > Also I'm not sure what you mean by RFT, doubt anyone will test this > for you, and you're modifying virtio which you should be able to test > yourself.. RFC or PATCH is the choice. Just to be clear, would testing packet flow with all the possible mode combinations under heavy traffic be sufficient and exhaustive? I think this should be PATCH once I sort everything out
Re: [RFT net-next v4 0/2] net: Split ndo_set_rx_mode into snapshot and deferred write
On Tue, 18 Nov 2025 22:26:42 +0530 I Viswanath wrote: > I am sorry that it is broken. I will submit a v5 as soon as possible Broken as in patch titles or broken as in it crashes the kernel? Both are true. Just to be safe "as soon as possible" hopefully takes into account our "no reposts within 24h" rule. https://www.kernel.org/doc/html/next/process/maintainer-netdev.html Also I'm not sure what you mean by RFT, doubt anyone will test this for you, and you're modifying virtio which you should be able to test yourself.. RFC or PATCH is the choice.
Re: [RFT net-next v4 0/2] net: Split ndo_set_rx_mode into snapshot and deferred write
Hi, I am sorry that it is broken. I will submit a v5 as soon as possible
