Re: [RFC/PATCH v6 02/12] media: Media device

2010-11-25 Thread Alan Cox
On Thu, 25 Nov 2010 12:20:31 -0500 Andy Walls wrote: > The signedness of char is ambiguous for 8 bit data, which is why an API would > normally use u8 (or s8, I guess). > > Since this is known to be character data, I would think char would be fine. > I am assuming C compilers would never assu

Re: [RFC/PATCH v6 02/12] media: Media device

2010-11-25 Thread Laurent Pinchart
Hi Andy, On Thursday 25 November 2010 18:20:31 Andy Walls wrote: > The signedness of char is ambiguous for 8 bit data, which is why an API > would normally use u8 (or s8, I guess). > > Since this is known to be character data, I would think char would be fine. I think so too. > I am assuming C

Re: [RFC/PATCH v6 02/12] media: Media device

2010-11-25 Thread Andy Walls
The signedness of char is ambiguous for 8 bit data, which is why an API would normally use u8 (or s8, I guess). Since this is known to be character data, I would think char would be fine. I am assuming C compilers would never assume multibyte "char"s. Regards, Andy Laurent Pinchart wrote: >

Re: [RFC/PATCH v6 02/12] media: Media device

2010-11-25 Thread Laurent Pinchart
Hi Clemens, Thanks for the review. On Thursday 25 November 2010 10:33:02 Clemens Ladisch wrote: > Laurent Pinchart wrote: > > +struct media_device { > > ... > > + u8 model[32]; > > + u8 serial[40]; > > + u8 bus_info[32]; > > All drivers and userspace applications have to treat this as char

Re: [RFC/PATCH v6 02/12] media: Media device

2010-11-25 Thread Clemens Ladisch
Laurent Pinchart wrote: > +struct media_device { > ... > + u8 model[32]; > + u8 serial[40]; > + u8 bus_info[32]; All drivers and userspace applications have to treat this as char[], so why u8[]? Regards, Clemens -- To unsubscribe from this list: send the line "unsubscribe linux-media

[RFC/PATCH v6 02/12] media: Media device

2010-11-24 Thread Laurent Pinchart
The media_device structure abstracts functions common to all kind of media devices (v4l2, dvb, alsa, ...). It manages media entities and offers a userspace API to discover and configure the media device internal topology. Signed-off-by: Laurent Pinchart --- Documentation/DocBook/media-entities.t