Re: mmc_spi and flash cards

2009-12-28 Thread Cliff Brake
Some more decoding of response codes. Its interesting the both cards return an error at the same place in the init sequence. I suspect that we are sending something bogus to the cards, but the transcend and ATP cards seems to recover, but the Sandisk does not. It appears that all this activity h

Re: [PATCH] arch/avr32: Fix build failure for avr32 caused by typo

2009-12-28 Thread Hans-Christian Egtvedt
On Mon, 28 Dec 2009 12:07:23 +0100 Hans-Christian Egtvedt wrote: > On Mon, 28 Dec 2009 11:34:36 +0100 > Peter Hüwe wrote: > > > I think your first patch is good as it is, so I will apply it. Please > > > send any additional fixes as a separate patch. > > > > Okay thanks for applying. > > >

Re: [PATCH] arch/avr32: Fix build failure for avr32 caused by typo

2009-12-28 Thread Hans-Christian Egtvedt
On Mon, 28 Dec 2009 11:34:36 +0100 Peter Hüwe wrote: > Am Montag 28 Dezember 2009 11:20:28 schrieb Haavard Skinnemoen: > > Peter Hüwe wrote: > > > Great, thanks for the update. > > > The only thing that still catches my eye is that the kzalloc line can > > > fail, so you should perhaps add somet

Re: [PATCH] arch/avr32: Fix build failure for avr32 caused by typo

2009-12-28 Thread Peter Hüwe
Am Montag 28 Dezember 2009 11:20:28 schrieb Haavard Skinnemoen: > Peter Hüwe wrote: > > Great, thanks for the update. > > The only thing that still catches my eye is that the kzalloc line can > > fail, so you should perhaps add something like > > if (!slave) { > > printk(KERN_ERR "No memory le

Re: [PATCH] arch/avr32: Fix build failure for avr32 caused by typo

2009-12-28 Thread Haavard Skinnemoen
Peter Hüwe wrote: > Great, thanks for the update. > The only thing that still catches my eye is that the kzalloc line can fail, > so > you should perhaps add something like > if (!slave) { > printk(KERN_ERR "No memory left for at32ap700x: at32_add_device_mc"); > goto fail; > } I agr

Re: [PATCH] arch/avr32: Fix build failure for avr32 caused by typo

2009-12-28 Thread Hans-Christian Egtvedt
On Mon, 28 Dec 2009 10:59:30 +0100 Peter Hüwe wrote: > Am Montag 28 Dezember 2009 09:13:18 schrieb Hans-Christian Egtvedt: > > On Fri, 25 Dec 2009 20:08:45 +0100 > > > > Peter Huewe wrote: > > > This patch fixes a build failure introduced by the patch > > > atmel-mci: change use of dma slave

Re: [PATCH] arch/avr32: Fix build failure for avr32 caused by typo

2009-12-28 Thread Peter Hüwe
Am Montag 28 Dezember 2009 09:13:18 schrieb Hans-Christian Egtvedt: > On Fri, 25 Dec 2009 20:08:45 +0100 > > Peter Huewe wrote: > > This patch fixes a build failure introduced by the patch > > atmel-mci: change use of dma slave interface by Nicolas Ferre > > by changing mci_dma_slave to the cor

Re: [PATCH] arch/avr32: Fix build failure for avr32 caused by typo

2009-12-28 Thread Hans-Christian Egtvedt
On Fri, 25 Dec 2009 20:08:45 +0100 Peter Huewe wrote: > This patch fixes a build failure introduced by the patch > atmel-mci: change use of dma slave interface by Nicolas Ferre > by changing mci_dma_slave to the correct name of mci_dma_data > > This should make the avr32 tree build again. >