[PATCH] sdhci: add adma descriptor set call

2010-01-27 Thread Ben Dooks
The code to write the ADMA descriptor into memory is repeated several times throughout sdhci_adma_table_pre, and thus should be moved into a common function. This will also be useful if the patch to make the write more efficient is accepted. Signed-off-by: Ben Dooks --- drivers/mmc/host/sdhci.c

[PATCH] sdhci: improve sdhci sdhci_set_adma_desc() code

2010-01-27 Thread Ben Dooks
The sdhci_set_adma_desc is using byte-writes to write data in a specified order into memory. Change to using __le16 for the two byte and __le32 for the four byte cases and use the cpu_to_{le16,le32} to do the conversion before writing. This will reduce the size of the code and the number of writes

SDHCI ADMA clenaups

2010-01-27 Thread Ben Dooks
ADMA code cleanps for SDHCI driver. Makes the code shorter and more efficient. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH-Resend] S3C: sdhci: Enable ADMA feature in S3C sdhci controller.

2010-01-27 Thread Ben Dooks
On Thu, Jan 28, 2010 at 10:50:38AM +0900, Thomas Abraham wrote: > This patch enables ADMA feature in S3C SDHCI controller driver. This patch > depends on the following patch. > > [PATCH] sdhci: Add new quirk in sdhci driver and update ADMA descriptor build. > > Signed-off-by: Thomas Abraham Acke

Re: [PATCH-Resend] sdhci: Add new quirk in sdhci driver and update ADMA descriptor build.

2010-01-27 Thread Ben Dooks
On Thu, Jan 28, 2010 at 10:50:22AM +0900, Thomas Abraham wrote: > The s3c6410 sdhci controller does not support the 'End' attribute and > NOP attribute in the same 8-Byte ADMA descriptor. This patch adds a > new quirk to identify sdhci host contollers with such behaviour. > In addition to this, for

[PATCH-Resend] S3C: sdhci: Enable ADMA feature in S3C sdhci controller.

2010-01-27 Thread Thomas Abraham
This patch enables ADMA feature in S3C SDHCI controller driver. This patch depends on the following patch. [PATCH] sdhci: Add new quirk in sdhci driver and update ADMA descriptor build. Signed-off-by: Thomas Abraham --- drivers/mmc/host/sdhci-s3c.c |7 +-- 1 files changed, 1 insertions(

[PATCH-Resend] sdhci: Add new quirk in sdhci driver and update ADMA descriptor build.

2010-01-27 Thread Thomas Abraham
The s3c6410 sdhci controller does not support the 'End' attribute and NOP attribute in the same 8-Byte ADMA descriptor. This patch adds a new quirk to identify sdhci host contollers with such behaviour. In addition to this, for controllers using the new quirk, the last entry in the ADMA descritor t

+ sdio-add-quirk-to-clamp-byte-mode-transfer.patch added to -mm tree

2010-01-27 Thread akpm
The patch titled sdio: add quirk to clamp byte mode transfer has been added to the -mm tree. Its filename is sdio-add-quirk-to-clamp-byte-mode-transfer.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list a

Re: sdio irq hack for omap_hsmmc.c (was: Re: [PATCH] OMAP35xx:SDIO IRQ Support for OMAP35xx)

2010-01-27 Thread John Rigby
Just to be clear, my post was in response to the reported problems with enabling sdio irqs with this patch: http://patchwork.kernel.org/patch/69122/ The patch originator reported good results but others reported complete failure. My hack fixed the problem for me. I believe this much more modest

RE: sdio irq hack for omap_hsmmc.c (was: Re: [PATCH] OMAP35xx:SDIO IRQ Support for OMAP35xx)

2010-01-27 Thread Madhusudhan
It is hard to comment on what is happening here without a patch. Is it a performance issue or that SDIO functionality failure with PM enabled? The MMC controller supports wakeup capability on the dat1 line using a GPIO for a SDIO interrupt. I guess that should help. Regards, Madhu > -Origina