RE: [PATCH 1/3] s3c64xx: Fix build without SDHCI controllers

2010-06-10 Thread Kukjin Kim
> -Original Message- > From: Kyungmin Park [mailto:kyungmin.p...@samsung.com] > Sent: Friday, June 11, 2010 1:35 PM > To: 'Kukjin Kim' > Cc: 'Marek Szyprowski'; linux-arm-ker...@lists.infradead.org; linux-samsung- > s...@vger.kernel.org; linux-mmc@vger.kernel.org; ben-li...@fluff.org > Sub

Re: [PATCH 3/3] s5pv210: Aquila: add definitions for sdhci devices

2010-06-10 Thread Kyungmin Park
On Fri, Jun 11, 2010 at 2:18 PM, Ben Dooks wrote: > On Wed, Jun 09, 2010 at 11:39:05AM +0200, Marek Szyprowski wrote: >> This patch add support for SDHCI blocks on Samsung Aquila board. The >> following host controllers are defined: >> 1. Internal MoviNAND device (permanently wired to the controll

[PATCH v2] s3c64xx: Fix build without SDHCI controllers

2010-06-10 Thread Marek Szyprowski
This patch fixes the following compilation problem if only NCP machine is selected: arch/arm/mach-s3c64xx/s3c6410.c: In function ‘s3c6410_map_io’: arch/arm/mach-s3c64xx/s3c6410.c:51: error: implicit declaration of function ‘s3c6410_default_sdhci2’ Signed-off-by: Marek Szyprowski Signed-off-by:

Re: [PATCH 1/5] sdhci-s3c: depend on plat-samsung

2010-06-10 Thread Kyungmin Park
On Fri, Jun 11, 2010 at 2:24 PM, Ben Dooks wrote: > On Fri, Jun 11, 2010 at 09:29:38AM +0900, Kukjin Kim wrote: >> Marek Szyprowski wrote: >> > >> > Most Samsung SoC have support for SDHCI block, so make the driver >> > dependent on the Samsung platform instead on listing all SoCs in the >> > Kcon

RE: [PATCH 3/3] s5pv210: Aquila: add definitions for sdhci devices

2010-06-10 Thread Marek Szyprowski
Hello, On Friday, June 11, 2010 7:18 AM Ben Dooks wrote: > On Wed, Jun 09, 2010 at 11:39:05AM +0200, Marek Szyprowski wrote: > > This patch add support for SDHCI blocks on Samsung Aquila board. The > > following host controllers are defined: > > 1. Internal MoviNAND device (permanently wired to t

Re: [PATCH 1/5] sdhci-s3c: depend on plat-samsung

2010-06-10 Thread Ben Dooks
On Fri, Jun 11, 2010 at 09:29:38AM +0900, Kukjin Kim wrote: > Marek Szyprowski wrote: > > > > Most Samsung SoC have support for SDHCI block, so make the driver > > dependent on the Samsung platform instead on listing all SoCs in the > > Kconfig (and updating it again when support for the new SoC v

Re: [PATCH 3/3] s5pv210: Aquila: add definitions for sdhci devices

2010-06-10 Thread Ben Dooks
On Wed, Jun 09, 2010 at 11:39:05AM +0200, Marek Szyprowski wrote: > This patch add support for SDHCI blocks on Samsung Aquila board. The > following host controllers are defined: > 1. Internal MoviNAND device (permanently wired to the controller) > 2. Internal WiFI SDIO device (card is activated by

RE: [PATCH 1/3] s3c64xx: Fix build without SDHCI controllers

2010-06-10 Thread Kyungmin Park
> -Original Message- > From: Kukjin Kim [mailto:kgene@samsung.com] > Sent: Friday, June 11, 2010 12:59 PM > To: 'Kyungmin Park' > Cc: 'Marek Szyprowski'; linux-arm-ker...@lists.infradead.org; linux- > samsung-...@vger.kernel.org; linux-mmc@vger.kernel.org; ben- > li...@fluff.org > Sub

Re: + s5pc110-sdhci-s3c-can-override-host-capabilities.patch added to -mm tree

2010-06-10 Thread Kyungmin Park
Hi, On Fri, Jun 11, 2010 at 12:48 PM, Ben Dooks wrote: > On Fri, Jun 11, 2010 at 12:24:00PM +0900, Kyungmin Park wrote: >> On Fri, Jun 11, 2010 at 9:34 AM, Ben Dooks wrote: >> > On Thu, Jun 10, 2010 at 01:43:14PM -0700, a...@linux-foundation.org wrote: >> >> >> >> The patch titled >> >>      s5p

RE: [PATCH 1/3] s3c64xx: Fix build without SDHCI controllers

2010-06-10 Thread Kukjin Kim
Kyungmin Park wrote: > > On Fri, Jun 11, 2010 at 9:56 AM, Kukjin Kim wrote: > > Marek Szyprowski wrote: > >> > >> This patch fixes the following compilation problem if only NCP machine > >> is selected: > >> > >> arch/arm/mach-s3c64xx/s3c6410.c: In function ‘s3c6410_map_io’: > >> arch/arm/mach-s3

Re: + s5pc110-sdhci-s3c-can-override-host-capabilities.patch added to -mm tree

2010-06-10 Thread Ben Dooks
On Fri, Jun 11, 2010 at 12:24:00PM +0900, Kyungmin Park wrote: > On Fri, Jun 11, 2010 at 9:34 AM, Ben Dooks wrote: > > On Thu, Jun 10, 2010 at 01:43:14PM -0700, a...@linux-foundation.org wrote: > >> > >> The patch titled > >>      s5pc110: SDHCI-s3c can override host capabilities > >> has been add

Re: [PATCH] sdhci-s3c: Add SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK quirk for Samsung SoC

2010-06-10 Thread Kyungmin Park
Hi, On Thu, Jun 10, 2010 at 8:39 PM, Kukjin Kim wrote: > From: Lee Hyuk > > On Samsung's SDMMC hosts the timeout clock is derivied from the SD > Clock, which is set dynamically. > So, checked 'SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK' quirk and removed > 'sdhci_s3c_get_timeout_clk' callback which doe

Re: [PATCH 1/3] s3c64xx: Fix build without SDHCI controllers

2010-06-10 Thread Kyungmin Park
On Fri, Jun 11, 2010 at 9:56 AM, Kukjin Kim wrote: > Marek Szyprowski wrote: >> >> This patch fixes the following compilation problem if only NCP machine >> is selected: >> >> arch/arm/mach-s3c64xx/s3c6410.c: In function ‘s3c6410_map_io’: >> arch/arm/mach-s3c64xx/s3c6410.c:51: error: implicit decl

Re: + sdhci-add-no-hi-speed-bit-quirk-support.patch added to -mm tree

2010-06-10 Thread Kyungmin Park
On Fri, Jun 11, 2010 at 9:42 AM, Ben Dooks wrote: > On Thu, Jun 10, 2010 at 01:43:19PM -0700, a...@linux-foundation.org wrote: >> >> The patch titled >>      SDHCI: add no hi-speed bit quirk support >> has been added to the -mm tree.  Its filename is >>      sdhci-add-no-hi-speed-bit-quirk-support

Re: + s5pc110-sdhci-s3c-can-override-host-capabilities.patch added to -mm tree

2010-06-10 Thread Kyungmin Park
On Fri, Jun 11, 2010 at 9:34 AM, Ben Dooks wrote: > On Thu, Jun 10, 2010 at 01:43:14PM -0700, a...@linux-foundation.org wrote: >> >> The patch titled >>      s5pc110: SDHCI-s3c can override host capabilities >> has been added to the -mm tree.  Its filename is >>      s5pc110-sdhci-s3c-can-override

RE: [PATCH 1/3] s3c64xx: Fix build without SDHCI controllers

2010-06-10 Thread Kukjin Kim
Marek Szyprowski wrote: > > This patch fixes the following compilation problem if only NCP machine > is selected: > > arch/arm/mach-s3c64xx/s3c6410.c: In function ‘s3c6410_map_io’: > arch/arm/mach-s3c64xx/s3c6410.c:51: error: implicit declaration of function > ‘s3c6410_default_sdhci2’ > > Signed

Re: + sdhci-add-no-hi-speed-bit-quirk-support.patch added to -mm tree

2010-06-10 Thread Ben Dooks
On Thu, Jun 10, 2010 at 01:43:19PM -0700, a...@linux-foundation.org wrote: > > The patch titled > SDHCI: add no hi-speed bit quirk support > has been added to the -mm tree. Its filename is > sdhci-add-no-hi-speed-bit-quirk-support.patch > > Before you just go and hit "reply", please: >

Re: + s5pc110-sdhci-s3c-support-on-s5pc110.patch added to -mm tree

2010-06-10 Thread Ben Dooks
On Thu, Jun 10, 2010 at 01:43:17PM -0700, a...@linux-foundation.org wrote: > > The patch titled > s5pc110: SDHCI-s3c support on s5pc110 > has been added to the -mm tree. Its filename is > s5pc110-sdhci-s3c-support-on-s5pc110.patch > > Before you just go and hit "reply", please: >a

Re: + s5pc110-sdhci-s3c-can-override-host-capabilities.patch added to -mm tree

2010-06-10 Thread Ben Dooks
On Thu, Jun 10, 2010 at 01:43:14PM -0700, a...@linux-foundation.org wrote: > > The patch titled > s5pc110: SDHCI-s3c can override host capabilities > has been added to the -mm tree. Its filename is > s5pc110-sdhci-s3c-can-override-host-capabilities.patch > > Before you just go and hit

RE: [PATCH 1/5] sdhci-s3c: depend on plat-samsung

2010-06-10 Thread Kukjin Kim
Marek Szyprowski wrote: > > Most Samsung SoC have support for SDHCI block, so make the driver > dependent on the Samsung platform instead on listing all SoCs in the > Kconfig (and updating it again when support for the new SoC variant is > added). > Hi, Marek Kyungmin Park already submitted same

Re: SD card on Dell D420 (Ricoh R5C822)

2010-06-10 Thread Maxim Levitsky
On Thu, 2010-06-10 at 22:54 +0100, Mark Hills wrote: > On Thu, 10 Jun 2010, Maxim Levitsky wrote: > > > On Thu, 2010-06-10 at 09:08 +0100, Mark Hills wrote: > > > On Wed, 9 Jun 2010, Chris Ball wrote: > > > > > > > Hi Mark, > > > > > > > >> mmc0: error -84 whilst initialising SD card > >

Re: SD card on Dell D420 (Ricoh R5C822)

2010-06-10 Thread Mark Hills
On Fri, 11 Jun 2010, Maxim Levitsky wrote: > On Thu, 2010-06-10 at 22:54 +0100, Mark Hills wrote: > > On Thu, 10 Jun 2010, Maxim Levitsky wrote: [...] > > > Did you do a suspend/resume cycle before this test? > > > > No, I didn't suspect or resume the laptop. The dmesg is from a cold > > reboo

Re: [PATCH] s5pc110: SDHCI-s3c can override host capabilities

2010-06-10 Thread Andrew Morton
On Sat, 05 Jun 2010 11:40:53 +0900 Kyungmin Park wrote: > From: Kyungmin Park > To: linux-arm-ker...@lists.infradead.org, linux-mmc@vger.kernel.org, > a...@linux-foundation.org, ben-li...@fluff.org > Subject: [PATCH] s5pc110: SDHCI-s3c can override host capabilities > Date: Sat, 05 Jun 2010 11:

+ s5pc110-sdhci-s3c-support-on-s5pc110.patch added to -mm tree

2010-06-10 Thread akpm
The patch titled s5pc110: SDHCI-s3c support on s5pc110 has been added to the -mm tree. Its filename is s5pc110-sdhci-s3c-support-on-s5pc110.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c)

+ s5pc110-sdhci-s3c-can-override-host-capabilities.patch added to -mm tree

2010-06-10 Thread akpm
The patch titled s5pc110: SDHCI-s3c can override host capabilities has been added to the -mm tree. Its filename is s5pc110-sdhci-s3c-can-override-host-capabilities.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable ma

+ sdhci-add-no-hi-speed-bit-quirk-support.patch added to -mm tree

2010-06-10 Thread akpm
The patch titled SDHCI: add no hi-speed bit quirk support has been added to the -mm tree. Its filename is sdhci-add-no-hi-speed-bit-quirk-support.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well

Re: [PATCH] s5pc110: SDHCI-s3c can override host capabilities

2010-06-10 Thread Kyungmin Park
hi, On Fri, Jun 11, 2010 at 5:43 AM, Andrew Morton wrote: > On Sat, 05 Jun 2010 11:40:53 +0900 > Kyungmin Park wrote: > >> From: Kyungmin Park >> To: linux-arm-ker...@lists.infradead.org, linux-mmc@vger.kernel.org, >> a...@linux-foundation.org, ben-li...@fluff.org >> Subject: [PATCH] s5pc110:

[PATCH] omap_hsmmc: Remove unused state variable

2010-06-10 Thread Sergio Aguirre
This fixes the following warning: drivers/mmc/host/omap_hsmmc.c: In function 'omap_hsmmc_suspend': drivers/mmc/host/omap_hsmmc.c:2275: warning: unused variable 'state' Introduced by commit ID: commit 1a13f8fa76c880be41d6b1e6a2b44404bcbfdf9e Author: Matt Fleming Date: Wed May 26 14:42:08

[PATCH 5/5 fixed] sdhci-s3c: add support for new card detection methods

2010-06-10 Thread Marek Szyprowski
On some Samsung SoCs not all SDHCI controllers have card detect (CD) line. For some embedded designs it is not even needed, because ususally the device (like SDIO flash memory or wifi controller) is permanently wired to the controller. There are also systems which have a card detect line connected

[PATCH] sdhci-s3c: Add SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK quirk for Samsung SoC

2010-06-10 Thread Kukjin Kim
From: Lee Hyuk On Samsung's SDMMC hosts the timeout clock is derivied from the SD Clock, which is set dynamically. So, checked 'SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK' quirk and removed 'sdhci_s3c_get_timeout_clk' callback which doesn't need any more. Signed-off-by: Hyuk Lee Signed-off-by: Kukjin

RE: [PATCH 3/5] sdhci-s3c: increase the timeout value

2010-06-10 Thread Kukjin Kim
Marek Szyprowski wrote: > > This patch increases the timeout value on sdhci-s3c controller by using > SDHCI_QUIRK_BROKEN_TIMEOUT_VAL quirk. Without it most transfers from > external mmc cards fails on Samsung s5pv210 SoCs based systems. Tested > on Samsung Aquila board. > Hi, Seems to use max t

Re: SD card on Dell D420 (Ricoh R5C822)

2010-06-10 Thread Maxim Levitsky
On Thu, 2010-06-10 at 09:08 +0100, Mark Hills wrote: > On Wed, 9 Jun 2010, Chris Ball wrote: > > > Hi Mark, > > > >> mmc0: error -84 whilst initialising SD card > > > > Not sure how much this'll help, but: > > > > errno -84 is defined in include/asm-generic/errno.h as EILSEQ, and > > ther

Re: [PATCH 1/4] block: Allow drivers to implement BLKDISCARD and add BLKSECDISCARD

2010-06-10 Thread Christoph Hellwig
On Fri, Jun 04, 2010 at 12:13:16AM +0300, Adrian Hunter wrote: > SD/MMC cards provide an erase operation that is too inefficient to > allow file systems to use it, however it is still useful for > userspace tools because it is still 10 - 100 times faster than > writing zeroes. Allow the MMC block

Re: SD card on Dell D420 (Ricoh R5C822)

2010-06-10 Thread Mark Hills
On Wed, 9 Jun 2010, Chris Ball wrote: > Hi Mark, > >> mmc0: error -84 whilst initialising SD card > > Not sure how much this'll help, but: > > errno -84 is defined in include/asm-generic/errno.h as EILSEQ, and > there are two occurences of EILSEQ in sdhci.c, one of which has a > printk ne

Re: [PATCH 1/4] block: Allow drivers to implement BLKDISCARD and add BLKSECDISCARD

2010-06-10 Thread Adrian Hunter
Adrian Hunter wrote: From 328a858c01be1e0d08f4a4b1f43d9fd117a295e5 Mon Sep 17 00:00:00 2001 From: Adrian Hunter Date: Thu, 3 Jun 2010 10:46:04 +0300 Subject: [PATCH 1/4] block: Allow drivers to implement BLKDISCARD and add BLKSECDISCARD SD/MMC cards provide an erase operation that is too ineff