Re: [PATCH v2 03/20] mmc: support embedded data field in mmc_host

2010-07-28 Thread Ohad Ben-Cohen
Hi Vitaly, On Wed, Jul 28, 2010 at 10:47 PM, Vitaly Wool wrote: > On Wed, Jul 21, 2010 at 7:33 PM, Ohad Ben-Cohen wrote: >> Add support to set/get mmc_host private embedded >> data. >> >> This is needed to allow software to dynamically >> create (and remove) SDIO functions which represents >> em

RE: [PATCHv5 3/4] sdhci-s3c: add support for new card detection methods (driver part)

2010-07-28 Thread Marek Szyprowski
Hello, On Wednesday, July 28, 2010 7:03 PM Ben Dooks wrote: > On 28/07/10 15:19, Marek Szyprowski wrote: > > On some Samsung SoCs not all SDHCI controllers have card detect (CD) > > line. For some embedded designs it is not even needed, because ususally > > the device (like SDIO flash memory or w

RE: [PATCHv2 1/4] sdhci-s3c: add support for the non standard minimal clock value

2010-07-28 Thread Marek Szyprowski
Hello, On Wednesday, July 28, 2010 6:48 PM Ben Dooks wrote: > On 28/07/10 15:19, Marek Szyprowski wrote: > > S3C SDHCI host controller can change the source for generating mmc clock. > > By default host bus clock is used, what causes some problems on machines > > with 133MHz bus, because the SDHC

RE: [PATCH 4/4] sdhci-s3c: add regulator support

2010-07-28 Thread Marek Szyprowski
Hello, On Wednesday, July 28, 2010 4:48 PM Maurus Cuelenaere wrote: > -Original Message- > From: [mailto:mcuelena...@gmail.com] > Sent: > To: Marek Szyprowski > Cc: linux-mmc@vger.kernel.org; linux-samsung-...@vger.kernel.org; linux- > arm-ker...@lists.infradead.org; kyungmin.p...@samsu

RE: [PATCHv5 3/4] sdhci-s3c: add support for new card detection methods (driver part)

2010-07-28 Thread Marek Szyprowski
Hello, On Wednesday, July 28, 2010 4:40 PM Maurus Cuelenaere wrote: > Op 28-07-10 16:19, Marek Szyprowski schreef: > > On some Samsung SoCs not all SDHCI controllers have card detect (CD) > > line. For some embedded designs it is not even needed, because ususally > > the device (like SDIO flash

Re: [PATCH v2 03/20] mmc: support embedded data field in mmc_host

2010-07-28 Thread Vitaly Wool
Hi Ohad, On Wed, Jul 21, 2010 at 7:33 PM, Ohad Ben-Cohen wrote: > Add support to set/get mmc_host private embedded > data. > > This is needed to allow software to dynamically > create (and remove) SDIO functions which represents > embedded SDIO devices. > > @@ -209,6 +209,8 @@ struct mmc_host {

Re: [PATCH 4/4] sdhci-s3c: add regulator support

2010-07-28 Thread Mark Brown
On Wed, Jul 28, 2010 at 04:19:57PM +0200, Marek Szyprowski wrote: > static int sdhci_s3c_suspend(struct platform_device *dev, pm_message_t pm) > { > + int ret = 0; > struct sdhci_host *host = platform_get_drvdata(dev); > + struct sdhci_s3c *sc = sdhci_priv(host); > > sdhci_

Re: [PATCH v5 3/3] sdhci-s3c: Add SDHCI_QUIRK_NO_WP_BIT quirk for Samsung SoC

2010-07-28 Thread Ben Dooks
On 28/07/10 06:23, Kukjin Kim wrote: > From: Hyuk Lee > > If host controller doesn't have WP pin which should be connnected with SDMMC > card WP pin, can implement get_ro function with using the allocated gpio. > In order to use this quirk wp_gpio in the platform data must be set. > > Signed-off

Re: [PATCHv2 1/4] sdhci-s3c: add support for the non standard minimal clock value

2010-07-28 Thread Ben Dooks
On 28/07/10 15:19, Marek Szyprowski wrote: > S3C SDHCI host controller can change the source for generating mmc clock. > By default host bus clock is used, what causes some problems on machines > with 133MHz bus, because the SDHCI divider cannot be as high get proper > clock value for identificatio

Re: [PATCH 4/4] sdhci-s3c: add regulator support

2010-07-28 Thread Mark Brown
On Wed, Jul 28, 2010 at 07:06:22PM +0200, Maurus Cuelenaere wrote: > Op 28-07-10 17:41, Mark Brown schreef: > >>> + if (sc->vmmc) { > >>> + int ret = regulator_disable(sc->vmmc); > >>> + if (ret) > >>> + return ret; > >>> + mdelay(2); > >> Shouldn't these

Re: [PATCH 4/4] sdhci-s3c: add regulator support

2010-07-28 Thread Maurus Cuelenaere
Op 28-07-10 17:41, Mark Brown schreef: > On 28 Jul 2010, at 07:48, Maurus Cuelenaere wrote: >>> + struct sdhci_s3c *sc = sdhci_priv(host); >>> + >>> + if (sc->vmmc) { >>> + int ret = regulator_disable(sc->vmmc); >>> + if (ret) >>> + return ret; >>> +

Re: [PATCHv5 3/4] sdhci-s3c: add support for new card detection methods (driver part)

2010-07-28 Thread Ben Dooks
On 28/07/10 15:19, Marek Szyprowski wrote: > On some Samsung SoCs not all SDHCI controllers have card detect (CD) > line. For some embedded designs it is not even needed, because ususally > the device (like SDIO flash memory or wifi controller) is permanently > wired to the controller. There are al

Re: [PATCH 4/4] sdhci-s3c: add regulator support

2010-07-28 Thread Maurus Cuelenaere
Op 28-07-10 16:19, Marek Szyprowski schreef: > This patch adds support for regulator API to sdhci-s3c driver. Regulators > can be used to disable power in suspended state to reduce dissipated > energy. I'm not sure about this, when I would try to do this I'd look at implementing this in the sdhci

Re: [PATCHv5 3/4] sdhci-s3c: add support for new card detection methods (driver part)

2010-07-28 Thread Maurus Cuelenaere
Op 28-07-10 16:19, Marek Szyprowski schreef: > On some Samsung SoCs not all SDHCI controllers have card detect (CD) > line. For some embedded designs it is not even needed, because ususally > the device (like SDIO flash memory or wifi controller) is permanently > wired to the controller. There are

[PATCHv5 3/4] sdhci-s3c: add support for new card detection methods (driver part)

2010-07-28 Thread Marek Szyprowski
On some Samsung SoCs not all SDHCI controllers have card detect (CD) line. For some embedded designs it is not even needed, because ususally the device (like SDIO flash memory or wifi controller) is permanently wired to the controller. There are also systems which have a card detect line connected

[PATCHv2 1/4] sdhci-s3c: add support for the non standard minimal clock value

2010-07-28 Thread Marek Szyprowski
S3C SDHCI host controller can change the source for generating mmc clock. By default host bus clock is used, what causes some problems on machines with 133MHz bus, because the SDHCI divider cannot be as high get proper clock value for identification mode. This is not a problem for the controller, b

[PATCH] SDHCI-S3C updates

2010-07-28 Thread Marek Szyprowski
Hello, This patch series includes various updates to sdhci-s3c driver. The patches has been rebased onto latest -mm kernel tree from git://zen-kernel.org/kernel/mmotm.git (2010-07-27-14-56 snapshot). Some patches has been already accepted by Andrew Morton, but they became incompatible after threa

[PATCH 4/4] sdhci-s3c: add regulator support

2010-07-28 Thread Marek Szyprowski
This patch adds support for regulator API to sdhci-s3c driver. Regulators can be used to disable power in suspended state to reduce dissipated energy. Signed-off-by: Marek Szyprowski Signed-off-by: Kyungmin Park --- drivers/mmc/host/sdhci-s3c.c | 30 +- 1 files cha

[PATCH 2/4] sdhci-s3c: enable SDHCI_QUIRK_NO_HISPD_BIT quirk

2010-07-28 Thread Marek Szyprowski
This patch enables SDHCI_QUIRK_NO_HISPD_BIT on Samsung SDHCI driver. This solves detection problems with some external SD cards. This change has been tested on S5PC100 and S5PC110. It has no inpact on driver speed. Signed-off-by: Kyungmin Park Signed-off-by: Marek Szyprowski --- drivers/mmc/hos

RE: [PATCH 3/3] mmc: Add ESDHC weird register workaround

2010-07-28 Thread Zang Roy-R61911
> -Original Message- > From: Anton Vorontsov [mailto:cbouatmai...@gmail.com] > Sent: Wednesday, July 28, 2010 16:03 PM > To: Zang Roy-R61911 > Cc: linux-mmc-appro...@vger.kernel.org; linuxppc-...@ozlabs.org > Subject: Re: [PATCH 3/3] mmc: Add ESDHC weird register workaround > > On Wed,

RE: [PATCH] mmc: add the MMC/SD/SDIO Arasan host controller

2010-07-28 Thread Peppe CAVALLARO
Hi David, > -Original Message- > From: David Vrabel [mailto:david.vra...@csr.com] > Sent: Wednesday, July 28, 2010 10:40 AM > To: Peppe CAVALLARO > Cc: linux-mmc@vger.kernel.org > Subject: Re: [PATCH] mmc: add the MMC/SD/SDIO Arasan host controller > > Giuseppe CAVALLARO wrote: > > This p

Re: [PATCH] mmc: failure of block read wait for long time

2010-07-28 Thread Adrian Hunter
ext Ghorai, Sukumar wrote: -Original Message- From: Adrian Hunter [mailto:adrian.hun...@nokia.com] Sent: Tuesday, July 27, 2010 6:52 PM To: Ghorai, Sukumar Cc: linux-mmc@vger.kernel.org; linux-arm-ker...@lists.infradead.org Subject: Re: [PATCH] mmc: failure of block read wait for long t

Re: [PATCH] mmc: add the MMC/SD/SDIO Arasan host controller

2010-07-28 Thread David Vrabel
Giuseppe CAVALLARO wrote: > This patch adds the MMC/SD/SDIO Arasan host controller. > Advanced DMA, Single DMA and PIO modes are supported. > The former is the default. The Arasan IP is a Standard Host Controller so you should look at using the existing sdhci driver. The sdhci-s3c driver provides

[PATCH] mmc: add the MMC/SD/SDIO Arasan host controller

2010-07-28 Thread Giuseppe CAVALLARO
This patch adds the MMC/SD/SDIO Arasan host controller. Advanced DMA, Single DMA and PIO modes are supported. The former is the default. This has been tested on the 7108/06 STM platforms. Signed-off-by: Giuseppe Cavallaro --- drivers/mmc/host/Kconfig|7 + drivers/mmc/host/Makefile