Re: [RFC/PATCH RESEND] mmc: sdhci: Enable high speed support for MMC cards

2010-08-27 Thread Kyungmin Park
Hi Chris, On Sat, Aug 28, 2010 at 4:19 AM, Chris Ball wrote: > Hi, > > This patch wasn't responded to -- any feedback from the list? > > From: George G. Davis > Date: Thu, 18 Feb 2010 15:27:53 -0500 > > Allow high speed mode for high speed capable ver 4.x MMC cards. > > Comments and/or feedback

Re: [PATCH 4/5] sdhci-s3c: add support for the non standard minimal clock value

2010-08-27 Thread Chris Ball
Hi Kgene, >> Looks like this wasn't merged. Any thoughts on doing so? > Updated patch(v3) of this was merged. You're right, my mistake. Sorry for the noise! -- Chris Ball One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a me

Re: sdhci : reduce irq off latency

2010-08-27 Thread Chris Ball
Hi Matthieu, This patch didn't make it upstream. Kyungmin offered a suggestion for fixing it -- would you like to resend an updated patch? (As a minor aside, I have a fairly irrational preference for "time_after(jiffies, timeout)" over "time_is_before_jiffies(timeout)", because the latter read

[PATCH RESEND 2.6.32-rc8 1/3] mmc: Unify and generalize UNSTUFF_BITS macro

2010-08-27 Thread Chris Ball
Hi, No replies on the list, and not merged; any comments on these three patches from Don? - Chris. Date: Sun, 29 Nov 2009 19:28:12 -0800 From: don.mul...@gmail.com Unify duplicated implementations of UNSTUFF_BITS() into a shared .h file. Recode UNSTUFF_BITS() as an invocation of a new more gen

Re: [PATCH v3] mmc: Make ID freq configurable

2010-08-27 Thread Hein_Tibosch
On 28-8-2010 04:44, Chris Ball wrote: > Hi, > > This looks like the best of the min_freq patches I've seen, and is > implementing a suggestion of Pierre's. Should we take it? > > - Chris. > > On Tue, Jan 05, 2010 at 05:58:34AM +0800, Hein_Tibosch wrote: >> Below a patch which tries mmc-initializa

RE: [PATCH 4/5] sdhci-s3c: add support for the non standard minimal clock value

2010-08-27 Thread Kukjin Kim
Chris Ball wrote: > > Hi, > Hi again ;-) > Looks like this wasn't merged. Any thoughts on doing so? > Updated patch(v3) of this was merged. http://marc.info/?l=linux-arm-kernel&m=128040710023029&w=2 (commit ID: ce5f036bbbfc6c21d7b55b8fdaa2e2bd56392d94) Thanks. Best regards, Kgene. -- Kukji

RE: [PATCH] sdhci-s3c: Add SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK quirk for Samsung SoC

2010-08-27 Thread Kukjin Kim
Chris Ball wrote: > > Hi, > Hi :-) > This wasn't merged, after some questions from Kyungmin Park -- is > the patch still desirable? > This patch is being in mainline now. (Commit ID: 3fe42e077f65351503f5004031549db330bb105e) Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW So

Re: [PATCH RESEND] au1xmmc.c: use resource_size()

2010-08-27 Thread Matt Fleming
On Sat, Aug 28, 2010 at 12:38:56AM +0200, Manuel Lauss wrote: > > Wasn't that posted ages ago? I'm fine with it. Yep, but it never got merged. Thanks for the ACK. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More ma

Re: [PATCH RESEND] au1xmmc.c: use resource_size()

2010-08-27 Thread Manuel Lauss
On Fri, Aug 27, 2010 at 9:26 PM, Matt Fleming wrote: > [Adding maintainer to CC] > > On Fri, Aug 27, 2010 at 08:11:34PM +0100, Chris Ball wrote: >> From: H Hartley Sweeten >> Date: Mon, 14 Dec 2009 14:28:06 -0500 >> >> Use resource_size(). >> >> Signed-off-by: H Hartley Sweeten >> [cjb: rebased

Re: [PATCH] sdio: add MMC_PM_SKIP_RESUME_PROBE to workaround powered resume

2010-08-27 Thread Nicolas Pitre
On Fri, 27 Aug 2010, Nicolas Pitre wrote: > On Fri, 27 Aug 2010, Chris Ball wrote: > > > Hi, > > > > Any comments on this patch from the list? > > Looks rather hackish to me. There should be a more elegant way to > achieve the same result. I have no time to look at it and propose an > alter

Re: [PATCH] sdio: add MMC_PM_SKIP_RESUME_PROBE to workaround powered resume

2010-08-27 Thread Nicolas Pitre
On Fri, 27 Aug 2010, Chris Ball wrote: > Hi, > > Any comments on this patch from the list? Looks rather hackish to me. There should be a more elegant way to achieve the same result. I have no time to look at it and propose an alternative solution though. > > From: Bing Zhao > Date: Wed,

+ drivers-mmc-host-imxmmcc-adjust-confusing-if-indentation.patch added to -mm tree

2010-08-27 Thread akpm
The patch titled drivers/mmc/host/imxmmc.c: adjust confusing if indentation has been added to the -mm tree. Its filename is drivers-mmc-host-imxmmcc-adjust-confusing-if-indentation.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to

[PATCH RESEND] drivers/mmc/host: Adjust confusing if indentation

2010-08-27 Thread Chris Ball
Hi Andrew, doesn't look like anyone else has taken this yet. From: Julia Lawall Date: Thu, 5 Aug 2010 22:19:52 +0200 (CEST) Move the second if (reg & ...) test into the branch indicated by its indentation. The test was previously always executed after the if containing that branch, but it was a

Re: [PATCH] mmc: failure of block read wait for long time

2010-08-27 Thread Chris Ball
Hi, On Tue, Jul 27, 2010 at 04:57:46PM +0530, Sukumar Ghorai wrote: > multi-block read failure retries in single block read one by one. It > continues > retry of subsequent blocks, even after failure. Application will not be able > to decode the interleave data (even if few single block read s

+ omap-hsmmc-fix-a-racing-case-between-kmmcd-and-omap_hsmmc_suspend.patch added to -mm tree

2010-08-27 Thread akpm
The patch titled omap hsmmc: fix a racing case between kmmcd and omap_hsmmc_suspend has been added to the -mm tree. Its filename is omap-hsmmc-fix-a-racing-case-between-kmmcd-and-omap_hsmmc_suspend.patch Before you just go and hit "reply", please: a) Consider who else should be cc'e

[PATCH] sdio: add MMC_PM_SKIP_RESUME_PROBE to workaround powered resume

2010-08-27 Thread Chris Ball
Hi, Any comments on this patch from the list? From: Bing Zhao Date: Wed, 21 Jul 2010 18:46:55 -0700 Marvell 8686/8688 device will not respond to re-probe attemps in powered resume, if the card is in sleep mode. The added MMC_PM_SKIP_RESUME_PROBE flag is checked so that call to mmc_sdio_init_car

+ drivers-mmc-host-omap_hsmmcc-use-resource_size.patch added to -mm tree

2010-08-27 Thread akpm
The patch titled drivers/mmc/host/omap_hsmmc.c: use resource_size() has been added to the -mm tree. Its filename is drivers-mmc-host-omap_hsmmcc-use-resource_size.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mai

+ drivers-mmc-host-omapc-use-resource_size.patch added to -mm tree

2010-08-27 Thread akpm
The patch titled drivers/mmc/host/omap.c: use resource_size() has been added to the -mm tree. Its filename is drivers-mmc-host-omapc-use-resource_size.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as

omap_hsmmc.c: use resource_size()

2010-08-27 Thread Chris Ball
Use resource_size(). Signed-off-by: Chris Ball --- drivers/mmc/host/omap_hsmmc.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 4a8776f..077bbdb 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/dri

omap.c: use resource_size()

2010-08-27 Thread Chris Ball
Use resource_size(). Signed-off-by: Chris Ball --- drivers/mmc/host/omap.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c index d98ddcf..23ce2f1 100644 --- a/drivers/mmc/host/omap.c +++ b/drivers/mmc/host/omap.c @@

Re: [PATCH v3] mmc: Make ID freq configurable

2010-08-27 Thread Chris Ball
Hi, This looks like the best of the min_freq patches I've seen, and is implementing a suggestion of Pierre's. Should we take it? - Chris. On Tue, Jan 05, 2010 at 05:58:34AM +0800, Hein_Tibosch wrote: > > In my last mail the spaces in the patch were mistreated, sorry for that. > > Below a patc

[PATCH RESEND] MMC:mmc_spi: Recover from CRC error for SD read/write operation over SPI.

2010-08-27 Thread Chris Ball
Hi, There were no comments about this patch -- Andrew, please take it if there are no objections. From: Sonic Zhang Date: Mon, 12 Jul 2010 15:50:56 +0800 Subject: [PATCH] mmc_spi: Recover from CRC error for SD read/write operation over SPI. SPI bus is not reliable on all platforms when doing l

Re: [PATCH FINAL] sdhci-clk-gating-support

2010-08-27 Thread Chris Ball
Hi, I reviewed this patch, but still feel uneasy about merging it -- it's hard to know if any controllers will handle this badly, or suffer performance problems if their clock takes a long time to stabilize. Is pushing to -mm a reasonable thing to do if we want more testing, or should we hold of

Re: + arm-samsung-mmc-fix-build-error-when-both-dma-and-pio-mode-selected.patch added to -mm tree

2010-08-27 Thread Matt Fleming
Best get Ben's opinion on this (now Cc'd). On Fri, Aug 27, 2010 at 01:03:39PM -0700, Andrew Morton wrote: > > The patch titled > ARM: SAMSUNG: MMC: fix build error when both DMA and PIO mode selected > has been added to the -mm tree. Its filename is > arm-samsung-mmc-fix-build-error-wh

[PATCH RESEND] OMAP HSMMC: fix a racing case between kmmcd and omap_hsmmc_suspend

2010-08-27 Thread Chris Ball
Hi, This doesn't seem to have been merged -- Andrew, could you take it? From: Ethan Du Date: Mon, 21 Jun 2010 19:20:41 +0800 If suspend called when kmmcd is doing host->ops->disable, as kmmcd already increased host->en_dis_recurs to 1, the mmc_host_enable in suspend function will return directl

[PATCH RESEND] mmc: at91_mci: add missing linux/highmem.h include

2010-08-27 Thread Chris Ball
Hi Andrew, This patch wasn't merged, and Marc adds that he think his kernel config could have been to blame. Looks harmless, though; want to take it? From: Marc Kleine-Budde Date: Sat, 19 Jun 2010 19:24:17 +0200 This patch fixes the following error: at91_mci.c: In function 'at91_mci_sg_to_dma

+ mmc-use-snprintf-not-sprintf.patch added to -mm tree

2010-08-27 Thread akpm
The patch titled drivers/mmc/card/block.c: use snprintf not sprintf has been added to the -mm tree. Its filename is mmc-use-snprintf-not-sprintf.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well

+ omap_hsmmc-remove-unused-state-variable.patch added to -mm tree

2010-08-27 Thread akpm
The patch titled omap_hsmmc: remove unused local `state' has been added to the -mm tree. Its filename is omap_hsmmc-remove-unused-state-variable.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well

+ arm-samsung-mmc-fix-build-error-when-both-dma-and-pio-mode-selected.patch added to -mm tree

2010-08-27 Thread akpm
The patch titled ARM: SAMSUNG: MMC: fix build error when both DMA and PIO mode selected has been added to the -mm tree. Its filename is arm-samsung-mmc-fix-build-error-when-both-dma-and-pio-mode-selected.patch Before you just go and hit "reply", please: a) Consider who else should b

Re: [PATCH] MMC driver full patch for Moorestown platform

2010-08-27 Thread Chris Ball
Hi, This wasn't merged -- Kyungmin Park pointed out a conflict with other newly-added 8-bit support. Alan (or Kyungmin?), are you interested in rebasing and sending to Andrew? On Thu, Jun 17, 2010 at 04:17:00PM +0100, Alan Cox wrote: > From: JiebingLi > > This patch enables Moorestown Langwell

Re: [PATCH RESEND] initialise DMA engine before MMC

2010-08-27 Thread Andrew Morton
On Fri, 27 Aug 2010 20:49:39 +0100 Chris Ball wrote: > Hi, > > Andrew, mind taking this one? > > From: Guennadi Liakhovetski > Date: Mon, 7 Jun 2010 13:16:36 +0200 (CEST) > > To use DMA engine based DMA with MMC in a non-modular build, the DMA > engine has to initialise before MMC. > > Sign

[PATCH RESEND] mmc: use snprintf not sprintf

2010-08-27 Thread Chris Ball
Hi Alan, This wasn't merged, because it went to Pierre rather than Andrew. Andrew, could you take it? From: JiebingLi Date: Thu, 17 Jun 2010 15:58:46 +0100 This patch fixes an issue found by klockwork. Just paranoia. Signed-off-by: JiebingLi Signed-off-by: Alan Cox --- drivers/mmc/card/blo

Re: [PATCH] sdhci-s3c: Add SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK quirk for Samsung SoC

2010-08-27 Thread Chris Ball
Hi, This wasn't merged, after some questions from Kyungmin Park -- is the patch still desirable? On Thu, Jun 10, 2010 at 08:39:51PM +0900, Kukjin Kim wrote: > From: Lee Hyuk > > On Samsung's SDMMC hosts the timeout clock is derivied from the SD > Clock, which is set dynamically. > So, checked '

Re: [PATCH 4/5] sdhci-s3c: add support for the non standard minimal clock value

2010-08-27 Thread Chris Ball
Hi, Looks like this wasn't merged. Any thoughts on doing so? On Wed, Jun 09, 2010 at 11:39:42AM +0200, Marek Szyprowski wrote: > S3C SDHCI host controller can change the source for generating mmc clock. > By default host bus clock is used, what causes some problems on machines > with 133MHz bus,

Re: [PATCH 3/5] sdhci-s3c: increase the timeout value

2010-08-27 Thread Chris Ball
Hi Marek, On Wed, Jun 09, 2010 at 11:39:41AM +0200, Marek Szyprowski wrote: > This patch increases the timeout value on sdhci-s3c controller by using > SDHCI_QUIRK_BROKEN_TIMEOUT_VAL quirk. Without it most transfers from > external mmc cards fails on Samsung s5pv210 SoCs based systems. Tested > on

[PATCH RESEND] omap_hsmmc: Remove unused state variable

2010-08-27 Thread Chris Ball
Hi, Andrew, please take this one. From: Sergio Aguirre Date: Thu, 10 Jun 2010 09:00:06 -0500 This fixes the following warning: drivers/mmc/host/omap_hsmmc.c: In function 'omap_hsmmc_suspend': drivers/mmc/host/omap_hsmmc.c:2275: warning: unused variable 'state' Introduced by commit ID: comm

[PATCH RESEND] initialise DMA engine before MMC

2010-08-27 Thread Chris Ball
Hi, Andrew, mind taking this one? From: Guennadi Liakhovetski Date: Mon, 7 Jun 2010 13:16:36 +0200 (CEST) To use DMA engine based DMA with MMC in a non-modular build, the DMA engine has to initialise before MMC. Signed-off-by: Guennadi Liakhovetski Acked-by: Dan Williams --- diff --git a/dr

[PATCH RESEND] ARM: SAMSUNG: MMC: Fix build error when both DMA and PIO mode selected

2010-08-27 Thread Chris Ball
From: Jiri Pinkava Date: Tue, 25 May 2010 09:48:58 +0200 Signed-off-by: Jiri Pinkava [cjb: fix line-wrapped patch] --- drivers/mmc/host/s3cmci.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/host/s3cmci.c b/drivers/mmc/host/s3cmci.c index 2fdf768..4426a4b

Re: [PATCH] mmci-omap: Use resource_size

2010-08-27 Thread Chris Ball
Hi, On Thu, May 06, 2010 at 10:04:19AM +0200, Tobias Klauser wrote: > Use the resource_size function instead of manually calculating the > resource size. This reduces the chance of introducing off-by-one > errors. > > Signed-off-by: Tobias Klauser > --- > drivers/mmc/host/omap.c |4 ++-- >

Re: [PATCH v8 0/2] sDMA descriptor autoloading feature

2010-08-27 Thread Chris Ball
Hi Venkatraman, On Thu, Apr 29, 2010 at 11:04:34PM +0530, Venkatraman S wrote: > This patch series is the introduction of new sDMA feature: descriptor > autoloading (v8) and it's adoption by the OMAP HSMMC driver. > >The previous version (v7) was blocked on achieving proper interrupt > sy

Re: [PATCH] sdhci - add public definition of quirks

2010-08-27 Thread Matt Fleming
On Fri, Aug 27, 2010 at 08:28:23PM +0100, Chris Ball wrote: > Hi, > > Any comments on this patch from the list? Are there no users of this patch? Who would want this? We generally don't add infrastructure to the kernel without a user. -- To unsubscribe from this list: send the line "unsubscribe l

Re: [PATCH 01/03] omap hsmmc: prevent race between dma and hsmmc callback

2010-08-27 Thread Chris Ball
Hi, Looks like the discussion on this patch stopped: do we think there's a race worth fixing here? On Wed, Mar 10, 2010 at 07:41:38PM +0530, Venkatraman S wrote: > See previous post http://patchwork.kernel.org/patch/82907/ > Rebased to 2.6.34-rc1 and fixed comment alignment. > > CC: Adrian Hunte

Re: [PATCH] SDHCI: Modify checks to determine the presense of card.

2010-08-27 Thread Chris Ball
Hi, This wasn't picked up -- any comments from the list? On Fri, Mar 05, 2010 at 12:29:37PM +0530, Thomas Abraham wrote: > In the sdhci_request function, the card is determined to be present based > on the SDCD pin status. SDHCI host controllers that do not use SDCD pin > but rely on other mechan

Re: [PATCH] S3C: SDHCI: Modify timeout clock calculation.

2010-08-27 Thread Chris Ball
Hi, This wasn't picked up -- any comments from the list? On Fri, Mar 05, 2010 at 12:32:43PM +0530, Thomas Abraham wrote: > In sdhci_s3c_set_clock function of S3C SDHCI controller driver, when a new > clock source is selected, the timeout clock is recalculated. This patch > modifies the calculati

Re: [PATCH 1/7] mmc: at91_mci: fix pointer errors

2010-08-27 Thread Chris Ball
On Fri, Aug 27, 2010 at 08:33:03PM +0100, Chris Ball wrote: > Looks like only the first half of this patch was applied? The > kunmap_atomic() line is still present as before in Linus' tree. Might be related to Dan Carpenter's suggestion that the spacing for that line should change to: k

Re: [PATCH 1/7] mmc: at91_mci: fix pointer errors

2010-08-27 Thread Chris Ball
Hi Andrew, Nicolas, On Fri, Feb 26, 2010 at 07:39:29PM +0100, Nicolas Ferre wrote: > From: Wolfgang Muees > > Fixes two pointer errors, one which leads to memory overwrites if used with > large chunks of data. > > Signed-off-by: Wolfgang Muees > Signed-off-by: Nicolas Ferre > --- > drivers/m

+ mmc-sdhci-make-consistent-use-of-config_mmc_debug-for-debugging.patch added to -mm tree

2010-08-27 Thread akpm
The patch titled mmc: sdhci: make consistent use of CONFIG_MMC_DEBUG for "DEBUG"ging has been added to the -mm tree. Its filename is mmc-sdhci-make-consistent-use-of-config_mmc_debug-for-debugging.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed

+ mmc-au1xmmcc-use-resource_size.patch added to -mm tree

2010-08-27 Thread akpm
The patch titled mmc: au1xmmc.c: use resource_size() has been added to the -mm tree. Its filename is mmc-au1xmmcc-use-resource_size.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally

+ mmc-at91_mcic-use-resource_size.patch added to -mm tree

2010-08-27 Thread akpm
The patch titled mmc: at91_mci.c: use resource_size() has been added to the -mm tree. Its filename is mmc-at91_mcic-use-resource_size.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideal

+ mmc-atmel-mcic-use-resource-size.patch added to -mm tree

2010-08-27 Thread akpm
The patch titled mmc: atmel-mci.c: use resource size() has been added to the -mm tree. Its filename is mmc-atmel-mcic-use-resource-size.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ide

Re: [PATCH] sdhci - add public definition of quirks

2010-08-27 Thread Chris Ball
Hi, Any comments on this patch from the list? On Mon, Feb 22, 2010 at 11:33:48PM +0300, dmitry pervushin wrote: > Hi Pierre, Richard, > > The patch adds ability to architectures that use sdhci-pltfm driver to > provide their own quirks via platform_data parameter of sdhci devices. > > Signed-of

Re: [PATCH RESEND] au1xmmc.c: use resource_size()

2010-08-27 Thread Matt Fleming
[Adding maintainer to CC] On Fri, Aug 27, 2010 at 08:11:34PM +0100, Chris Ball wrote: > From: H Hartley Sweeten > Date: Mon, 14 Dec 2009 14:28:06 -0500 > > Use resource_size(). > > Signed-off-by: H Hartley Sweeten > [cjb: rebased patch against Linus] > Signed-off-by: Chris Ball > --- > drive

Re: [PATCH RESEND] atmel-mci.c: use resource size()

2010-08-27 Thread Matt Fleming
[Adding Nicolas to Cc] On Fri, Aug 27, 2010 at 08:09:55PM +0100, Chris Ball wrote: > From: H Hartley Sweeten > Date: Mon, 14 Dec 2009 14:11:56 -0500 > > Use resource_size(). > > Signed-off-by: H Hartley Sweeten > [cjb: rebased patch against Linus] > Signed-off-by: Chris Ball > --- > drivers/

Re: [PATCH RESEND] at91_mci.c: use resource_size()

2010-08-27 Thread Matt Fleming
[Adding maintainer to CC] On Fri, Aug 27, 2010 at 08:08:13PM +0100, Chris Ball wrote: > From: H Hartley Sweeten > Date: Mon, 14 Dec 2009 14:10:26 -0500 > > Use resource_size(). > > Signed-off-by: H Hartley Sweeten > [cjb: rebased patch against Linus] > Signed-off-by: Chris Ball > --- > drive

Re: [PATCH 0/2] mmc: omap_hsmmc: support SDIO cards (#2)

2010-08-27 Thread Chris Ball
Hi David, On Mon, Feb 22, 2010 at 02:24:17PM +, David Vrabel wrote: > These patches add support for SDIO cards to the omap_hsmmc driver. > Power management changes to prevent SDIO cards from being turned off > and losing all state, and card interrupts. > > I've been unable to test these exact

[RFC/PATCH RESEND] mmc: sdhci: Enable high speed support for MMC cards

2010-08-27 Thread Chris Ball
Hi, This patch wasn't responded to -- any feedback from the list? From: George G. Davis Date: Thu, 18 Feb 2010 15:27:53 -0500 Allow high speed mode for high speed capable ver 4.x MMC cards. Comments and/or feedback appreciated. Signed-off-by: George G. Davis [cjb: rebase patch against Linus]

[PATCH RESEND] mmc: sdhci: Make consistent use of CONFIG_MMC_DEBUG for "DEBUG"ging

2010-08-27 Thread Chris Ball
Hi, This patch wasn't merged, but still applies -- Andrew, mind taking it? - Chris. Date: Thu, 18 Feb 2010 12:32:12 -0500 From: "George G. Davis" The "6882a8c sdhci: Add better ADMA error reporting" commit added sdhci_show_adma_error() which is built when DEBUG is defined. Since we already hav

Re: [PATCH V7] mxc : Add i.MX21 support to mxcmmc driver

2010-08-27 Thread Chris Ball
Hi Martin, On Sat, Feb 13, 2010 at 04:36:32PM +0100, Martin Fuzzey wrote: > Even though the i.MX21 SDHC module has the same revision number as the i.MX27 > one there are a few differences!! > Some interrupt enables are inverted. > FIFO is only 16 bits wide. > The argument i

[PATCH RESEND] au1xmmc.c: use resource_size()

2010-08-27 Thread Chris Ball
From: H Hartley Sweeten Date: Mon, 14 Dec 2009 14:28:06 -0500 Use resource_size(). Signed-off-by: H Hartley Sweeten [cjb: rebased patch against Linus] Signed-off-by: Chris Ball --- drivers/mmc/host/au1xmmc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mmc

[PATCH RESEND] atmel-mci.c: use resource size()

2010-08-27 Thread Chris Ball
From: H Hartley Sweeten Date: Mon, 14 Dec 2009 14:11:56 -0500 Use resource_size(). Signed-off-by: H Hartley Sweeten [cjb: rebased patch against Linus] Signed-off-by: Chris Ball --- drivers/mmc/host/atmel-mci.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/m

[PATCH RESEND] at91_mci.c: use resource_size()

2010-08-27 Thread Chris Ball
From: H Hartley Sweeten Date: Mon, 14 Dec 2009 14:10:26 -0500 Use resource_size(). Signed-off-by: H Hartley Sweeten [cjb: rebased patch against Linus] Signed-off-by: Chris Ball --- drivers/mmc/host/at91_mci.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/driv

Re: [PATCH 3/3] MMC/SD: add callback function to detect card

2010-08-27 Thread Chris Ball
Hi, On Fri, Dec 04, 2009 at 03:55:09PM +0800, r66...@freescale.com wrote: > From: Jerry Huang > > Add callback function to check if the card has been removed. > > in order to check if the card has been removed, the function mmc_send_status > will send commad CMD13 to card and ask the card to s

Re: [PATCH] mmc: move regulator handling to core

2010-08-27 Thread Chris Ball
Hi Daniel, On Thu, Dec 03, 2009 at 01:46:30PM +0100, Daniel Mack wrote: > At the moment, regulator operations are done from individual mmc host > drivers. This is a problem because the regulators are not claimed > exclusively but the mmc core enables and disables them according to the > return val

Re: [PATCH] MMC: pxamci: call pdata->setpower even when regulator is used

2010-08-27 Thread Chris Ball
Hi, On Thu, Nov 26, 2009 at 12:10:13PM +0100, Daniel Mack wrote: > On platforms where the vmmc regulator is used, it might still be > necessary to call the platform data's setpower() callback in order to > drive GPIOs to power up hardware. > > I can't see any pxamci user with power regulators ena

RE: [PATCH] sdhci: disable MMC_CAP_NEEDS_POLL in nonremovable case

2010-08-27 Thread Gao, Yunpeng
>-Original Message- >From: linux-mmc-ow...@vger.kernel.org >[mailto:linux-mmc-ow...@vger.kernel.org] On Behalf Of Kyungmin Park >Sent: Friday, August 27, 2010 3:15 PM >To: Matt Fleming >Cc: Jaehoon Chung; linux-mmc@vger.kernel.org; Marek Szyprowski; Andrew Morton; >Ben Dooks >Subject: Re: [

Re: [PATCH] tmio_mmc: Prevents unexpected status clear

2010-08-27 Thread Magnus Damm
On Fri, Aug 27, 2010 at 7:10 AM, Matt Fleming wrote: > On Thu, Aug 26, 2010 at 02:12:37PM -0700, Andrew Morton wrote: >> On Thu, 26 Aug 2010 08:26:42 +0100 >> Matt Fleming wrote: >> >> > On Thu, Aug 26, 2010 at 03:58:38PM +0900, Magnus Damm wrote: >> > > >> > > Hi Matt, >> > > >> > > Just FYI, th

Re: [PATCH] sdhci: disable MMC_CAP_NEEDS_POLL in nonremovable case

2010-08-27 Thread Kyungmin Park
On Fri, Aug 27, 2010 at 4:09 PM, Matt Fleming wrote: > On Fri, Aug 27, 2010 at 03:34:54PM +0900, Jaehoon Chung wrote: >> If controller use SDHCI_QUIRK_BROKEN_CARD_DETECTION quirk, >> controller need always polling detect >> >> In this case, always generated interrupt.Because controller checked car

Re: [PATCH] sdhci: disable MMC_CAP_NEEDS_POLL in nonremovable case

2010-08-27 Thread Matt Fleming
On Fri, Aug 27, 2010 at 03:34:54PM +0900, Jaehoon Chung wrote: > If controller use SDHCI_QUIRK_BROKEN_CARD_DETECTION quirk, > controller need always polling detect > > In this case, always generated interrupt.Because controller checked card > status. > I think that is not efficiently. > > But i

Re: [PATCH] MMC: fix the use of kunmap_atomic() in tmio_mmc.h

2010-08-27 Thread Guennadi Liakhovetski
Hi Andrew On Thu, 26 Aug 2010, Andrew Morton wrote: > On Sat, 14 Aug 2010 22:29:40 +0200 (CEST) > Guennadi Liakhovetski wrote: > > > Signed-off-by: Guennadi Liakhovetski > > No changelog :( Sorry, I thought this was one of the cases, where the subject says it all. > - what was wrong with th