RFC: improved error recovery

2011-01-07 Thread Russell King - ARM Linux
This is my patch to improve error recovery. Note that in MMC mode, if a command fails as indicated by cmd->error being non-zero, that means we didn't get a valid response from the card, which in turn means that cmd->resp[] is invalid, and all other state should be ignored. (The way we set things

Re: SD power-control necessary?

2011-01-07 Thread Edward Falk
On 01/07/2011 07:37 AM, Edward A. Falk wrote: Just a random thought: allowing the driver to power off the SD card will defeat the "power-on memory protect" feature. This is how the supposedly secure G2 was jailbroken. Ahh, I see we're talking about a removable SD card. In that case, jailbrea

Re: [PATCH 15/23] Alternative mmc structure to support pxa168, pxa910, mmp2 family SD

2011-01-07 Thread Arnd Bergmann
On Friday 07 January 2011, Philip Rakity wrote: > Thanks for the suggestion. Let me see if I can implement this. > > A couple of points first > > a) current implementation once PXA168/910 is selected will no longer show > MMP2 boards so it is also broken. Play around and you will see the iss

Re: SD power-control necessary?

2011-01-07 Thread Chris Ball
On Fri, Jan 07, 2011 at 07:37:25AM -0800, Edward A. Falk wrote: >> Maybe a stupid question, but when designing new hardware with a slot >> for an sd-card, how essential is it that the driver is able to power off/on >> the card? > > Just a random thought: allowing the driver to power off the SD card

Re: [PATCH 15/23] Alternative mmc structure to support pxa168, pxa910, mmp2 family SD

2011-01-07 Thread Philip Rakity
On Jan 6, 2011, at 11:29 AM, Arnd Bergmann wrote: > On Friday 31 December 2010, Philip Rakity wrote: >> The patch selects ARCH-MMP (as now) but adds the ability >> to also know which specific SoC was chosen. (This is sort of done by >> choosing the development board today). > > On a larger sca

Re: [PATCH] mmc: mshci: Add support Mobile Storage Host Controller Interface

2011-01-07 Thread Will Newton
On Fri, Jan 7, 2011 at 11:51 AM, Wolfram Sang wrote: > >> The 'mshci.c' is based on 'linux/drivers/mmc/host/sdhci.c' and >> the role is exactly same with that. > > Can you sum up the differences why you cannot sdhci.c directly, please? The driver looks like it is for the same block (or very close

Re: SD power-control necessary?

2011-01-07 Thread Edward A. Falk
Hein_Tibosch wrote: Hello, Maybe a stupid question, but when designing new hardware with a slot for an sd-card, how essential is it that the driver is able to power off/on the card? Just a random thought: allowing the driver to power off the SD card will defeat the "power-on memory protect" f

Re: SD power-control necessary?

2011-01-07 Thread Michał Mirosław
2011/1/7 Hein_Tibosch : > Maybe a stupid question, but when designing new hardware with a slot > for an sd-card, how essential is it that the driver is able to power off/on > the card? For one, this is needed for power-management. In powered suspend case, when card's slot does not provide card cha

SD power-control necessary?

2011-01-07 Thread Hein_Tibosch
Hello, Maybe a stupid question, but when designing new hardware with a slot for an sd-card, how essential is it that the driver is able to power off/on the card? I would say essential, because I've seen sd-cards in a state in which they didn't respond to MMC_GO_IDLE_STATE anymore, until they were

Re: [PATCH 15/23] Alternative mmc structure to support pxa168, pxa910, mmp2 family SD

2011-01-07 Thread Arnd Bergmann
On Friday 31 December 2010, Philip Rakity wrote: > The patch selects ARCH-MMP (as now) but adds the ability > to also know which specific SoC was chosen. (This is sort of done by > choosing the development board today). On a larger scale, we try to go in the opposite direction: make it possible

Re: [PATCH] mmc: mshci: Add support Mobile Storage Host Controller Interface

2011-01-07 Thread Ben Dooks
On Fri, Jan 07, 2011 at 12:51:23PM +0100, Wolfram Sang wrote: > > > The 'mshci.c' is based on 'linux/drivers/mmc/host/sdhci.c' and > > the role is exactly same with that. > > Can you sum up the differences why you cannot sdhci.c directly, please? I second that. -- Ben Dooks, b...@fluff.org, ht

Re: [PATCH] mmc: mshci: Add support Mobile Storage Host Controller Interface

2011-01-07 Thread Wolfram Sang
> The 'mshci.c' is based on 'linux/drivers/mmc/host/sdhci.c' and > the role is exactly same with that. Can you sum up the differences why you cannot sdhci.c directly, please? Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Sol

[PATCH] mmc: mshci: Add support Mobile Storage Host Controller Interface

2011-01-07 Thread Kukjin Kim
From: Hyunsung Jang This patch adds support a new sdmmc controller which name is 'Mobile Storage Host Controller'. Its base version is 2.30a. The 'mshci.c' is based on 'linux/drivers/mmc/host/sdhci.c' and the role is exactly same with that. NOTE: This patch covers 1bit, 4bit and 8bit bus width

Re: mmc: sdhci stop SDCLK during asynchronous interrupt peroid

2011-01-07 Thread zhangfei gao
On Thu, Jan 6, 2011 at 10:52 AM, Philip Rakity wrote: > > On Jan 6, 2011, at 2:44 AM, zhangfei gao wrote: > >> On Wed, Jan 5, 2011 at 11:30 AM, Philip Rakity wrote: >>> >>> On Jan 5, 2011, at 1:39 AM, zhangfei gao wrote: >>> From 7554ead744bfdc7304a7ae9fb227212bf548161a Mon Sep 17 00:00:00 2