Hi Chris, Thanks for your review! Below is my answer about your concerns.
> -Original Message-
> From: Chris Ball [mailto:c...@laptop.org]
> Sent: Tuesday, January 11, 2011 7:20 AM
> To: Dong, Chuanxiao
> Cc: linux-mmc@vger.kernel.org; linux-ker...@vger.kernel.org;
> a...@linux-foundation.
Hi Chris,
Thanks for your comments. It is really helpful!
> -Original Message-
> From: linux-kernel-ow...@vger.kernel.org
> [mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of Chris Ball
> Sent: Monday, January 10, 2011 8:03 AM
> To: Dong, Chuanxiao
> Cc: linux-mmc@vger.kernel.org; li
Hi Linus,
Please pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git for-linus
to receive the MMC merge for 2.6.38-rc1. There are currently no merge
conflicts, and the patches have been tested in linux-next. Thanks.
Highlights are:
Core:
* Clock gating framework from Linus
Shouldn't one use mmc_op_conditional setting bit 30 to check for sector/byte
addressing
and then set the addressing mode based on the return value of this bit from
mmc_op_conditional.
We have seen cards doing sector addressing with sizes < 2GB and never seen a
card doing sector addressing tha
Update typo
>From 93873d40ea72b1ccd97c3629ffe555080ac4d0e4 Mon Sep 17 00:00:00 2001
From: Zhangfei Gao
Date: Sun, 9 Jan 2011 18:09:12 -0500
Subject: [PATCH] mmc: sdhci support emmc ddr50 mode
1. Spec sdhc 3.0 does not claim support 1.2v ddr mode, so sdhci.c
return error and SDR mode is b
Hi Richard,
On Tue, Jan 11, 2011 at 02:17:08AM +, Zhu Richard-R65037 wrote:
> Hi Chris:
> I keep all the info of the original patch into my local patch.
> The script the pull-tool used by us send out the emails to all the sign-off
> email address,
> When I used this tool to push the local pat
On Mon, Jan 10, 2011 at 7:06 PM, Philip Rakity wrote:
>
> On Jan 9, 2011, at 3:50 AM, zhangfei gao wrote:
>
>> From d65af1e0a51bd4cc6b7a55b48df2bc23ccb84f2d Mon Sep 17 00:00:00 2001
>> From: Zhangfei Gao
>> Date: Sun, 9 Jan 2011 18:09:12 -0500
>> Subject: [PATCH] mmc: sdhci support emmc ddr50 mod
Hi Chris:
I keep all the info of the original patch into my local patch.
The script the pull-tool used by us send out the emails to all the sign-off
email address,
When I used this tool to push the local patch into our mainline.
Sorry to bring any inconvenience to you.
Best Regards
Richard Zhu
B
Hi,
On Tue, Jan 11, 2011 at 10:02:48AM +0800, Richard Zhu wrote:
> Pick up the patch from the community.
>
> fc8a0985c2846292312556cba10b8a4182f55967
> From: Hanumath Prasad
> Date: Tue, 10 Aug 2010 18:01:45 -0700
> Subject: [REVIEW 2/2] mmc: only set blockaddressed for > 2GiB cards
>
> A non-z
Ok to push.
Best Regards
Lily Zhang
Freescale MAD Linux BSP
TEL: +86-21-28937573
FAX: +86-21-28937444
IM: r58...@im.freescale.net
mail to: r58...@freescale.com
-Original Message-
From: Zhu Richard-R65037
Sent: 2011年1月11日 10:03
To: Zhang Lily-R58066; r...@udp161639uds.ap.freescale.net
Pick up the patch from the community.
fc8a0985c2846292312556cba10b8a4182f55967
From: Hanumath Prasad
Date: Tue, 10 Aug 2010 18:01:45 -0700
Subject: [REVIEW 2/2] mmc: only set blockaddressed for > 2GiB cards
A non-zero value of SEC_COUNT does not indicate that the card is sector
addressed. Accord
On Jan 9, 2011, at 3:50 AM, zhangfei gao wrote:
> From d65af1e0a51bd4cc6b7a55b48df2bc23ccb84f2d Mon Sep 17 00:00:00 2001
> From: Zhangfei Gao
> Date: Sun, 9 Jan 2011 18:09:12 -0500
> Subject: [PATCH] mmc: sdhci support emmc ddr50 mode
>
> 1. spec sdhc 3.0 does not claim support 1.2v ddr m
Hi Chuanxiao,
On Mon, Dec 27, 2010 at 06:13:05PM +0800, Chuanxiao Dong wrote:
> Hi all,
>This is the version 6 of hardware reset feature implementation. When eMMC
>card cannot response any command, signal RST_n can help to reset eMMC
>card.
>
>patch1: enable HW reset capability if
On Tue, Jan 11, 2011 at 12:45:14AM +0900, Paul Mundt wrote:
> On Mon, Jan 10, 2011 at 10:10:19AM +, Pawel Moll wrote:
> > On Mon, 10 Jan 2011 07:50:42 +0900, Simon Horman
> > wrote:
> > >>> Documentation/arm/SH-Mobile/Makefile |8 +
> > >>> Documentation/arm/SH-Mobile/vrl4.c
2011/1/9 Pierre Tardy :
> this is a followup patchset of discussion that happen before on linux-mmc
> mailing list
> We add a mmc/core/quirk.c file holding list of quirks per devices or more
> generic quirks
> e.g. all sdio devices have this quirk.
I like this approach.
Acked-by: Linus Walleij
2011/1/8 Russell King - ARM Linux :
> This is my patch to improve error recovery.
Looks sane to me.
Acked-by: Linus Walleij
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
On Mon, 10 Jan 2011, Chris Ball wrote:
> Hi Jesper,
>
> On Mon, Jan 10, 2011 at 10:19:11PM +0100, Jesper Juhl wrote:
> > > On Mon, Jan 10, 2011 at 09:56:08PM +0100, Jesper Juhl wrote:
> > > >
> > > > Including usb.h once is enough in drivers/mmc/host/ushc.c
> > > > This removes the duplicate.
>
On Mon, 10 Jan 2011, Jesper Juhl wrote:
>
> Including usb.h once is enough in drivers/mmc/host/ushc.c
> This removes the duplicate.
>
>
> Signed-off-by: Jesper Juhl
> ---
> ushc.c |1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/ushc.c b/drivers/mmc/host/ushc.c
> i
Hi Jesper,
On Mon, Jan 10, 2011 at 10:19:11PM +0100, Jesper Juhl wrote:
> > On Mon, Jan 10, 2011 at 09:56:08PM +0100, Jesper Juhl wrote:
> > >
> > > Including usb.h once is enough in drivers/mmc/host/ushc.c
> > > This removes the duplicate.
> > >
> > >
> > > Signed-off-by: Jesper Juhl
Thanks,
On Mon, 10 Jan 2011, Wolfram Sang wrote:
> On Mon, Jan 10, 2011 at 09:56:08PM +0100, Jesper Juhl wrote:
> >
> > Including usb.h once is enough in drivers/mmc/host/ushc.c
> > This removes the duplicate.
> >
> >
> > Signed-off-by: Jesper Juhl
>
> Correct. Why the newlines in the commit-msg?
>
On Mon, Jan 10, 2011 at 09:56:08PM +0100, Jesper Juhl wrote:
>
> Including usb.h once is enough in drivers/mmc/host/ushc.c
> This removes the duplicate.
>
>
> Signed-off-by: Jesper Juhl
Correct. Why the newlines in the commit-msg?
Regards,
Wolfram
--
Pengutronix e.K.
Including usb.h once is enough in drivers/mmc/host/ushc.c
This removes the duplicate.
Signed-off-by: Jesper Juhl
---
ushc.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mmc/host/ushc.c b/drivers/mmc/host/ushc.c
index f8f65df..f08f944 100644
--- a/drivers/mmc/host/ushc.c
+++ b/
On Jan 10, 2011, at 8:57 AM, Pierre Tardy wrote:
>>
>>
>> Since the code is not called that often could you change the above code to:
>>
>>> if (mmc_card_sdio(card))
>>> return !(card->quirks & MMC_QUIRK_BROKEN_CLK_GATING);
> Well, The comment in the
>>return true;
>> +
>> + for (f = mmc_fixup_methods; f->hook; f++) {
>> + if ((f->vendor == card->cis.vendor
>> + || f->vendor == (u16) SDIO_ANY_ID) &&
>> + (f->device == card->cis.device
>> + || f->device == (u16) SDIO_ANY_ID)) {
>> +
>
>
> Since the code is not called that often could you change the above code to:
>
>> if (mmc_card_sdio(card))
>> return !(card->quirks & MMC_QUIRK_BROKEN_CLK_GATING);
Well, The comment in the
> return true;
>
> more obvious that quirk only applies to sdio.
Disagree.Act
On Jan 9, 2011, at 8:26 AM, Pierre Tardy wrote:
> From: Pierre Tardy
>
> Some cards have quirks valid for every platforms
> using current platform quirk hooks leads to a lot
> of code and debug duplication.
>
> So we inspire a bit from what exists in PCI subsystem
> and do our own per vendorid
On Jan 9, 2011, at 8:26 AM, Pierre Tardy wrote:
> Some sdio card are not following sdio standard, and does not work
> when the sdio bus's clock is gated
>
> To keep functionnality for all legacy driver, we turn this quirk on
> for every sdio card.
> Drivers needs to disable the quirk manually wh
On Mon, Jan 10, 2011 at 10:10:19AM +, Pawel Moll wrote:
> On Mon, 10 Jan 2011 07:50:42 +0900, Simon Horman
> wrote:
> >>> Documentation/arm/SH-Mobile/Makefile |8 +
> >>> Documentation/arm/SH-Mobile/vrl4.c| 169
> >>+
> >>How about puttin
If it is felt that the use of the quirk SDHCI_QUIRK_RESET_CMD_DATA_ON_IOS needs
to be protected against being interrupted the following code replaces the last
few lines of set_ios
sdhci_writeb(host, ctrl, SDHCI_HOST_CONTROL);
if (host->quirks & SDHCI_QUIRK_RESET_CMD_DA
In the current implementation of set_ios -- spin_lock with interrupts disabled
is held when mdelay is called. This is considered bad form.
This code changes how set_ios works to mask out interrupts on the sdhci device
rather than disable interrupts.
This code has been tested on mmp2 - linux-
On Mon, 10 Jan 2011 07:50:42 +0900, Simon Horman
wrote:
> Documentation/arm/SH-Mobile/Makefile |8 +
> Documentation/arm/SH-Mobile/vrl4.c| 169
+
How about putting those two into "tools" (in particular "tools/arm")
instead of "Documentation
Update with kernel warn when set_uhs fail.
>From 33a9fb7359c0d2136d58683517061a1144adc5e4 Mon Sep 17 00:00:00 2001
From: Zhangfei Gao
Date: Sun, 9 Jan 2011 18:09:12 -0500
Subject: [PATCH] mmc: sdhci support emmc ddr50 mode
1. spec sdhc 3.0 does not claim support 1.2v ddr mode
2.
32 matches
Mail list logo
