Re: [PATCH 3/3] mmc: remove anti clock gating quirk for wl1271

> > This adds a defined-but-not-used warning.  The MMC tree doesn't > currently generate any warnings, so it would be good to avoid adding new > ones, though I understand why it might make sense in this case. Yes, this is supposed to be used by future user patches. Do you suggest to add __attribut

Re: SDHC Read Performance

On Thu, Jan 20, 2011 at 01:01:04PM +0900, Magnus Damm wrote: > 1) Can you try a different SDHC Class 10 card? I'd just simply buy a > top-of-the-line SanDisk card myself and try that, but anything > different from what you're having is probably useful as a contrast. Sure, will do. > 2) How about

RE: [PATCH v2 1/1]mmc: implemented eMMC4.4 enhanced area feature

Hi Chris, > > On Thu, Jan 20, 2011 at 02:08:04PM +0800, Dong, Chuanxiao wrote: > > > I think these should probably be printed in decimal instead of hex. > > (Will assume you agree with this, let me know if not.) Agree with this. Sorry for missing it. > > > > Hm, this way the sysfs files will sh

Re: [PATCH v2 1/1]mmc: implemented eMMC4.4 enhanced area feature

Hi Chuanxiao, On Thu, Jan 20, 2011 at 02:08:04PM +0800, Dong, Chuanxiao wrote: > > I think these should probably be printed in decimal instead of hex. (Will assume you agree with this, let me know if not.) > > Hm, this way the sysfs files will show up regardless of whether we have > > an eMMC de

RE: [PATCH v2 1/1]mmc: implemented eMMC4.4 enhanced area feature

Hi Chris, Thanks for comments. I will fix the typo and line warp errors in the next submissions. :) > > MMC_DEV_ATTR(name, "%s\n", card->cid.prod_name); > > MMC_DEV_ATTR(oemid, "0x%04x\n", card->cid.oemid); > > MMC_DEV_ATTR(serial, "0x%08x\n", card->cid.serial); > > +MMC_DEV_ATTR(enhanced_area

Re: [PATCH v1 1/3]mmc: implemented runtime pm for mmc host

On Wed, Jan 19, 2011 at 09:45:57AM +, Tardy, Pierre wrote: > Chris, > (Sorry for top posting) > Seems we have a intel intern disagreement. > > Could we have maintainer opinion on this ? Linus W and Ohad, any input here? Thanks, -- Chris Ball One Laptop Per Child -

Re: [2.6.37/38] SDHCI spurious interrupt...

Hi Daniel, On Thu, Jan 20, 2011 at 11:21:14AM +0700, Daniel J Blueman wrote: > With 2.6.37 (and by extension 2.6.38-rc1, as the code hasn't changed), > I occasionally see an 'IRQ 16: nobody cared' message a second before > shutting down (previously reported [1]); the culprit is the SDHCI > driver

[2.6.37/38] SDHCI spurious interrupt...

With 2.6.37 (and by extension 2.6.38-rc1, as the code hasn't changed), I occasionally see an 'IRQ 16: nobody cared' message a second before shutting down (previously reported [1]); the culprit is the SDHCI driver for my Ricoh controller. I modified the interrupt handler to be unregistered later wi

Re: [PATCH 3/3] mmc: remove anti clock gating quirk for wl1271

Hi Pierre, On Sun, Jan 09, 2011 at 05:26:20PM +0100, Pierre Tardy wrote: > From: Pierre Tardy > > Signed-off-by: Pierre Tardy > --- > drivers/mmc/core/quirks.c | 18 ++ > 1 files changed, 18 insertions(+), 0 deletions(-) > > diff --git a/drivers/mmc/core/quirks.c b/drivers/m

Re: SDHC Read Performance

On Thu, Jan 20, 2011 at 12:30 PM, Simon Horman wrote: > I ran my tests again with CONFIG_SH_DMAE (and CONFIG_DMA_ENGINE) > enabled and the results are substantially better. Although > the results are still below the theoretical speeds of the cards. > > Read Speed - SHDI > SD1.1:           9.9 MB/s

Re: SDHC Read Performance

On Wed, Jan 19, 2011 at 05:05:49PM +0900, Simon Horman wrote: > On Wed, Jan 19, 2011 at 12:14:40PM +0900, Magnus Damm wrote: > > Hi Simon, > > > > On Wed, Jan 19, 2011 at 9:09 AM, Simon Horman wrote: > > > Hi, > > > > > > I am currently interested in the read performance of the SDHI driver.  I >

Re: [PATCH v2 1/1]mmc: implemented eMMC4.4 enhanced area feature

Hi Chuanxiao, On Thu, Jan 13, 2011 at 08:57:27PM +0800, Chuanxiao Dong wrote: > Enhanced area feature is a new feature defined in eMMC4.4 standard. This > kind of area can help to improve the performance. > > MMC driver will read out the enhanced area offset and size and add them > to be device a

RE: A MMC card transfer issue

Hi Chris, Thank you for your information. We will test using 2.6.38-rc1 and report to you. Thanks, - Tomoya MORINAGA OKI SEMICONDUCTOR CO., LTD. > -Original Message- > From: Chris Ball [mailto:c...@laptop.org] > Sent: Thursday, January 20, 2011

Re: A MMC card transfer issue

Hi, On Tue, Jan 18, 2011 at 10:05:04PM -0800, Philip Rakity wrote: > > For 1 bit transcend cards you need these 2 patches. > > >From 22113efd00491310da802f3b1a9a66cfcf415fac Mon Sep 17 00:00:00 2001 > From: Aries Lee > Date: Wed, 15 Dec 2010 08:14:24 +0100 > Subject: [PATCH] mmc: Test bus-width

RE: [PATCH v1 1/3]mmc: implemented runtime pm for mmc host

Chris, (Sorry for top posting) Seems we have a intel intern disagreement. Could we have maintainer opinion on this ? Regards, Pierre > -Original Message- > From: Dong, Chuanxiao > Sent: Wednesday, January 19, 2011 10:04 AM > To: Tardy, Pierre; linux-mmc@vger.kernel.org > Cc: linux-ker...

RE: [PATCH v1 1/3]mmc: implemented runtime pm for mmc host

Hi Pierre, I think the runtime pm should not have any dependency with clock gating. Even the MMC driver won't clock gate SD/MMC card, host controller should still enter runtime suspend state, right? So if auto suspended delay could be changed by user, then we can use pm_suspend_schedule to speci

Re: SDHC Read Performance

On Wed, Jan 19, 2011 at 12:14:40PM +0900, Magnus Damm wrote: > Hi Simon, > > On Wed, Jan 19, 2011 at 9:09 AM, Simon Horman wrote: > > Hi, > > > > I am currently interested in the read performance of the SDHI driver.  I > > ran the following tests on a Mackerel board using Linus's latest tree > >