Re: [PATCH v2] sdio: skip initialization on powered resume

2011-01-24 Thread Ohad Ben-Cohen
On Tue, Jan 25, 2011 at 9:11 AM, Ohad Ben-Cohen wrote: > One thing we can do is letting drivers register a wake-up function > within the SDIO core, just before suspending. Then, upon resume, if > such a wake-up function was registered, SDIO core would invoke it just > before it tries to read the C

Re: [PATCH v2] sdio: skip initialization on powered resume

2011-01-24 Thread Ohad Ben-Cohen
Hello Zhangfei, On Tue, Jan 25, 2011 at 5:10 AM, zhangfei gao wrote: > Could we remove mmc_card_is_removable(host) condition, the skip is not > related with whether card is removable or not, do you think so? But, as Nicolas pointed out before, what if the card is removed (or replaced) while the

Re: [PATCH v2] sdio: skip initialization on powered resume

2011-01-24 Thread zhangfei gao
On Mon, Jan 24, 2011 at 9:17 PM, Bing Zhao wrote: > Hi Ohad, > >> -Original Message- >> From: Ohad Ben-Cohen [mailto:o...@wizery.com] >> Sent: Saturday, January 22, 2011 2:01 PM >> To: zhangfei gao >> Cc: Nicolas Pitre; Bing Zhao; Sahitya Tummala; linux-mmc@vger.kernel.org; >> Michal Miro

RE: [PATCH v2] sdio: skip initialization on powered resume

2011-01-24 Thread Bing Zhao
Hi Ohad, > -Original Message- > From: Ohad Ben-Cohen [mailto:o...@wizery.com] > Sent: Saturday, January 22, 2011 2:01 PM > To: zhangfei gao > Cc: Nicolas Pitre; Bing Zhao; Sahitya Tummala; linux-mmc@vger.kernel.org; > Michal Miroslaw; Chris Ball; > Andrew Morton; Maxim Levitsky > Subject:

Re: [PATCH v1 1/3]mmc: implemented runtime pm for mmc host

2011-01-24 Thread Linus Walleij
2011/1/20 Chris Ball : > On Wed, Jan 19, 2011 at 09:45:57AM +, Tardy, Pierre wrote: >> Chris, >> (Sorry for top posting) >> Seems we have a intel intern disagreement. >> >> Could we have maintainer opinion on this ? > > Linus W and Ohad, any input here?  Thanks, What I see is orthogonal purpos

Re: [PATCH] MMC, USHC: Don't double include usb.h in ushc.c

2011-01-24 Thread Jesper Juhl
On Mon, 24 Jan 2011, Chris Ball wrote: > Hi, > > On Mon, Jan 24, 2011 at 10:05:05PM +0100, Jesper Juhl wrote: > > > I've already replied to you ACKing this patch, and pushed it to mmc-next. > > > > > Odd, I don't see that in my mailbox :-( But then I've had a few incidents > > of being bling i

Re: [PATCH] MMC, USHC: Don't double include usb.h in ushc.c

2011-01-24 Thread Chris Ball
Hi, On Mon, Jan 24, 2011 at 10:05:05PM +0100, Jesper Juhl wrote: > > I've already replied to you ACKing this patch, and pushed it to mmc-next. > > > Odd, I don't see that in my mailbox :-( But then I've had a few incidents > of being bling in that regard lately, so it's probably my fault. Sorry

Re: [PATCH] MMC, USHC: Don't double include usb.h in ushc.c

2011-01-24 Thread Jesper Juhl
On Mon, 24 Jan 2011, Chris Ball wrote: > Jesper, > > On Mon, Jan 24, 2011 at 09:59:25PM +0100, Jesper Juhl wrote: > > We include linux/usb.h twice in drivers/mmc/host/ushc.c - once is enough. > > > > Signed-off-by: Jesper Juhl > > --- > > ushc.c |1 - > > 1 file changed, 1 deletion(-) > >

Re: [PATCH] MMC, USHC: Don't double include usb.h in ushc.c

2011-01-24 Thread Chris Ball
Jesper, On Mon, Jan 24, 2011 at 09:59:25PM +0100, Jesper Juhl wrote: > We include linux/usb.h twice in drivers/mmc/host/ushc.c - once is enough. > > Signed-off-by: Jesper Juhl > --- > ushc.c |1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/mmc/host/ushc.c b/drivers/mmc/host/u

[PATCH] MMC, USHC: Don't double include usb.h in ushc.c

2011-01-24 Thread Jesper Juhl
We include linux/usb.h twice in drivers/mmc/host/ushc.c - once is enough. Signed-off-by: Jesper Juhl --- ushc.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mmc/host/ushc.c b/drivers/mmc/host/ushc.c index f8f65df..f08f944 100644 --- a/drivers/mmc/host/ushc.c +++ b/drivers/mmc/ho

Re: [patch]: sdhci support emmc ddr50 mode [v5]

2011-01-24 Thread zhangfei gao
On Fri, Jan 21, 2011 at 11:51 AM, zhangfei gao wrote: > On Mon, Jan 10, 2011 at 9:56 PM, zhangfei gao wrote: >> Update typo >> >> From 93873d40ea72b1ccd97c3629ffe555080ac4d0e4 Mon Sep 17 00:00:00 2001 >> From: Zhangfei Gao >> Date: Sun, 9 Jan 2011 18:09:12 -0500 >> Subject: [PATCH] mmc: sdhci su

Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Resubmission

2011-01-24 Thread Tony Olech
On Mon, 2011-01-24 at 11:28 -0500, Nicolas Pitre wrote: > > I had assumed that for a module the global initialized variables were > > loaded at module load. That then is a problem given that new devices > > (and drivers) are appearing quite rapidly. I therefore do not understand > > how the global

Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Resubmission

2011-01-24 Thread Nicolas Pitre
On Mon, 24 Jan 2011, Tony Olech wrote: > On Mon, 2011-01-24 at 10:55 -0500, Nicolas Pitre wrote: > > On Mon, 24 Jan 2011, Tony Olech wrote: > > > > > On Mon, 2011-01-24 at 09:43 -0500, Nicolas Pitre wrote: > > > > Uninitialized global scope variables are by definition assigned to the > > > > .bs

Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Resubmission

2011-01-24 Thread Tony Olech
On Sun, 2011-01-23 at 09:01 -0500, Nicolas Pitre wrote: > On Sun, 23 Jan 2011, Wolfram Sang wrote: > > On Sat, Jan 22, 2011 at 02:07:21PM -0500, Nicolas Pitre wrote: > > > On Sat, 22 Jan 2011, Wolfram Sang wrote: > > > > On Fri, Jan 21, 2011 at 04:14:46PM -0500, Nicolas Pitre wrote: > > > > > On Fr

Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Resubmission

2011-01-24 Thread Tony Olech
On Sun, 2011-01-23 at 11:09 +0100, Wolfram Sang wrote: > On Sat, Jan 22, 2011 at 02:07:21PM -0500, Nicolas Pitre wrote: > > On Sat, 22 Jan 2011, Wolfram Sang wrote: > > > On Fri, Jan 21, 2011 at 04:14:46PM -0500, Nicolas Pitre wrote: > > > > On Fri, 21 Jan 2011, Tony Olech wrote: > > > > > Add a dr

Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Resubmission

2011-01-24 Thread Tony Olech
On Sat, 2011-01-22 at 14:07 -0500, Nicolas Pitre wrote: > On Sat, 22 Jan 2011, Wolfram Sang wrote: > > On Fri, Jan 21, 2011 at 04:14:46PM -0500, Nicolas Pitre wrote: > > > On Fri, 21 Jan 2011, Tony Olech wrote: > > > > Add a driver for Elan Digital System's VUB300 chip > > > > which is a USB connec

Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Resubmission

2011-01-24 Thread Tony Olech
On Mon, 2011-01-24 at 10:55 -0500, Nicolas Pitre wrote: > On Mon, 24 Jan 2011, Tony Olech wrote: > > > On Mon, 2011-01-24 at 09:43 -0500, Nicolas Pitre wrote: > > > Uninitialized global scope variables are by definition assigned to the > > > .bss section. The .bss section is dynamically allocate

Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Resubmission

2011-01-24 Thread Nicolas Pitre
On Mon, 24 Jan 2011, Tony Olech wrote: > On Mon, 2011-01-24 at 09:43 -0500, Nicolas Pitre wrote: > > Uninitialized global scope variables are by definition assigned to the > > .bss section. The .bss section is dynamically allocated at run time > > rather than being stored in the compiled binary

Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Resubmission

2011-01-24 Thread Wolfram Sang
> > > > Should those be static anyhow? Being USB, you could probably hook up > > > > two of > > > > those and want to operate one of them in this and the other one in > > > > another > > > > mode? > > > > > > You could. Whether or not you would is another question. Until then I > > > don't t

Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Resubmission

2011-01-24 Thread Tony Olech
On Mon, 2011-01-24 at 09:43 -0500, Nicolas Pitre wrote: > On Mon, 24 Jan 2011, Tony Olech wrote: > > On Fri, 2011-01-21 at 16:14 -0500, Nicolas Pitre wrote: > > > On Fri, 21 Jan 2011, Tony Olech wrote: > > > > There are 5 "do not initialise statics" errors reported by > > > > scripts/checkpatch.pl

Re: [PATCH v1 1/3]mmc: implemented runtime pm for mmc host

2011-01-24 Thread Nicolas Pitre
On Sun, 23 Jan 2011, Ohad Ben-Cohen wrote: > On Sun, Jan 23, 2011 at 7:20 AM, Nicolas Pitre wrote: > > First case:  you want to stop the clock _to_ the _card_ when not talking > > to it.  That has nothing to do with power saving performed within the > > host controller.  This is for reducing powe

RE: [PATCH v1 1/3]mmc: implemented runtime pm for mmc host

2011-01-24 Thread Nicolas Pitre
On Sun, 23 Jan 2011, Tardy, Pierre wrote: > > > > First case: you want to stop the clock _to_ the _card_ when not talking > > to it. That has nothing to do with power saving performed within the > > host controller. This is for reducing power consumption by the _card_ > > (and possibly by the

Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Resubmission

2011-01-24 Thread Nicolas Pitre
On Mon, 24 Jan 2011, Tony Olech wrote: > On Fri, 2011-01-21 at 16:14 -0500, Nicolas Pitre wrote: > > On Fri, 21 Jan 2011, Tony Olech wrote: > > > There are 5 "do not initialise statics" errors reported by > > > scripts/checkpatch.pl > > > > you probably should fix those. They are due to lines s

RE: [PATCH v1 1/3]mmc: implemented runtime pm for mmc host

2011-01-24 Thread Dong, Chuanxiao
> -Original Message- > From: Ohad Ben-Cohen [mailto:o...@wizery.com] > Sent: Monday, January 24, 2011 4:40 AM > To: Nicolas Pitre > Cc: Chris Ball; Dong, Chuanxiao; Tardy, Pierre; linux-mmc@vger.kernel.org; > Linus > Walleij; Gao, Yunpeng > Subject: Re: [PATCH v1 1/3]mmc: implemented runti

Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Resubmission

2011-01-24 Thread Tony Olech
On Fri, 2011-01-21 at 16:14 -0500, Nicolas Pitre wrote: > On Fri, 21 Jan 2011, Tony Olech wrote: > > There are 5 "do not initialise statics" errors reported by > > scripts/checkpatch.pl > > you probably should fix those. They are due to lines such as: > > static int pad_input_to_usb_pkt = 0; >

Re: [PATCH] mmc: clear all interrupt in suspend before free_irq

2011-01-24 Thread zhangfei gao
On Fri, Jan 21, 2011 at 2:33 PM, Nicolas Pitre wrote: > On Fri, 21 Jan 2011, zhangfei gao wrote: > >> >From b7be39e0bbac3950057078ac66900ebc0871f77e Mon Sep 17 00:00:00 2001 >> From: Zhangfei Gao >> Date: Fri, 21 Jan 2011 18:02:47 -0500 >> Subject: [PATCH] mmc: clear all interrupt in suspend befo