Re: [PATCH] mmc: sdhci-tegra: free irq on error and remove

2011-02-20 Thread Wolfram Sang
On Thu, Feb 10, 2011 at 06:07:30PM +0100, Wolfram Sang wrote: > Signed-off-by: Wolfram Sang > Cc: Olof Johansson > Cc: Chris Ball > --- > > Found the leak while working on the esdhc-imx driver. Not even compile tested, > please check. Olof, do you have a minute for this one? > > drivers/mmc

[PATCH] omap: hsmmc: fix ocr mask usage

2011-02-20 Thread Anand Gadiyar
The OMAP HSMMC driver uses an ocr_mask to determine the list of voltages supported by the card. It populates this mask based on the list of voltages supported by the regulator that supplies the voltage. Commit 64be97822b (omap4 hsmmc: Update ocr mask for MMC2 for regulator to use) passed a fixed o

Re: [PATCH v2] mxcmmc: use dmaengine API

2011-02-20 Thread Chris Ball
Hi Sascha, On Fri, Feb 18, 2011 at 02:37:02PM +0100, Arnd Bergmann wrote: > On Friday 18 February 2011, Sascha Hauer wrote: > > This switches the mxcmmc driver to use the dmaengine API. Unlike > > the old one this one is always present in the tree, even if no DMA > > is implemented, hence we can r

Re: MMC quirks relating to performance/lifetime.

2011-02-20 Thread Arnd Bergmann
On Sunday 20 February 2011 06:56:39 Andrei Warkentin wrote: > On Sat, Feb 19, 2011 at 5:20 AM, Arnd Bergmann wrote: > > The numbers you see here are taken over multiple runs. Do you see a lot > > of fluctuation when doing this with --count=1? > > > > Yep. Quite a bit. > > # ./flashbench -c 1 -A

Re: MMC quirks relating to performance/lifetime.

2011-02-20 Thread Arnd Bergmann
On Sunday 20 February 2011 05:39:06 Andrei Warkentin wrote: > Actually it would be a good idea to also bail/warn if you do the au > test with more open au's than the size of the passed device allows, > since it'll just wrap around and skew the results. Yes, that's a bug. I never noticed because al

Re: MMC quirks relating to performance/lifetime.

2011-02-20 Thread Arnd Bergmann
[adding linux-fsdevel to Cc, see http://lwn.net/Articles/428941/ and http://comments.gmane.org/gmane.linux.ports.arm.kernel/105607 for more on this discussion.] On Sunday 20 February 2011 12:27:39 Andrei Warkentin wrote: > On Thu, Feb 17, 2011 at 9:47 AM, Arnd Bergmann wrote: > > I think I'd try

Re: MMC quirks relating to performance/lifetime.

2011-02-20 Thread Andrei Warkentin
On Thu, Feb 17, 2011 at 9:47 AM, Arnd Bergmann wrote: > I think I'd try to reduce the number of sysfs files needed for this. > What are the values you would typically set here? > > My feeling is that separating unaligned page writes from full pages > or multiples of pages could always be benefitia