Re: [PATCH resend] mmc: Added ioctl to let userspace apps send ACMDs

2011-03-17 Thread Arnd Bergmann
On Thursday 17 March 2011 19:28:55 John Calixto wrote: > Part 3 of the SD Specification (SD Card Association; www.sdcard.org) describes > how to use the security function of an SD card using application specific > commands in conjunction with CPRM algorithms and keys licensed from the 4C > Entity (

Re: [PATCH V6 3/4] mmc: sdhci-esdhc: make the writel/readl as the general APIs

2011-03-17 Thread Wolfram Sang
Hi Richard, On Thu, Mar 17, 2011 at 02:34:06PM +0800, Richard Zhu wrote: > Add one flag to indicate the GPIO CD/WP is enabled or not > on imx platforms, and reuse the writel/readl as the general > APIs for imx SOCs. > > Signed-off-by: Richard Zhu > --- > drivers/mmc/host/sdhci-esdhc-imx.c | 4

Re: [PATCH 5/7] mmc: support sdhci-esdhc-imx as an OF device

2011-03-17 Thread Rob Herring
On 03/17/2011 03:22 PM, Grant Likely wrote: [cc'ing linux-mmc to continue this discussion] On Wed, Mar 16, 2011 at 10:39:16PM +0800, Shawn Guo wrote: On Tue, Mar 15, 2011 at 01:59:26PM -0600, Grant Likely wrote: On Mon, Mar 14, 2011 at 10:25:57PM +0800, Shawn Guo wrote: Signed-off-by: Shawn G

Re: [PATCH 4/7] mmc: consolidate sdhci_pltfm_data and sdhci_of_data into one

2011-03-17 Thread Grant Likely
[cc'ing linux-mmc@vger.kernel.org] On Thu, Mar 17, 2011 at 02:33:20PM +0800, Shawn Guo wrote: > On Tue, Mar 15, 2011 at 01:55:13PM -0600, Grant Likely wrote: > > On Mon, Mar 14, 2011 at 10:25:56PM +0800, Shawn Guo wrote: > > > This patch is motivated by the work of supporting sdhci-esdhc-imx as >

Re: [PATCH 1/3] dw_mmc: set fixed burst in BMOD register

2011-03-17 Thread Will Newton
On Thu, Mar 17, 2011 at 6:24 PM, Chris Ball wrote: > Hi Will, > > On Thu, Feb 24 2011, Jaehoon Chung wrote: >> This patch is applied fixed burst. >> If use internal DMA controller, i think that need to set this bit. >> >> I tested when set this bit or not. I found that increase performance with >

Re: [PATCH 5/7] mmc: support sdhci-esdhc-imx as an OF device

2011-03-17 Thread Grant Likely
[cc'ing linux-mmc to continue this discussion] On Wed, Mar 16, 2011 at 10:39:16PM +0800, Shawn Guo wrote: > On Tue, Mar 15, 2011 at 01:59:26PM -0600, Grant Likely wrote: > > On Mon, Mar 14, 2011 at 10:25:57PM +0800, Shawn Guo wrote: > > > Signed-off-by: Shawn Guo > > > > dt support can be added

Re: [PATCH 2/3] dw_mmc: support mmc power control with regulator

2011-03-17 Thread Chris Ball
Hi, On Thu, Mar 17 2011, Chris Ball wrote: >> @@ -1438,6 +1439,13 @@ static int __init dw_mci_init_slot(struct dw_mci >> *host, unsigned int id) >> } >> #endif /* CONFIG_MMC_DW_IDMAC */ >> >> +host->vmmc = regulator_get(mmc_dev(mmc), "vmmc"); >> +if (IS_ERR(host->vmmc)) { >> +

[PATCH] mmc: enable ERASE caps for mvsdio host

2011-03-17 Thread Sascha Silbe
From: Sascha Silbe The Marvell SDIO host controller can transmit Erase commands to the card quite fine. Signed-off-by: Sascha Silbe --- drivers/mmc/host/mvsdio.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) Tested on OpenRD-Base using a SanDisk 4GB class 4 card (retail). The B

Re: [PATCH resend] mmc: Added ioctl to let userspace apps send ACMDs

2011-03-17 Thread Ben Dooks
On Thu, Mar 17, 2011 at 11:28:55AM -0700, John Calixto wrote: > Part 3 of the SD Specification (SD Card Association; www.sdcard.org) describes > how to use the security function of an SD card using application specific > commands in conjunction with CPRM algorithms and keys licensed from the 4C > E

[PATCH resend] mmc: Added ioctl to let userspace apps send ACMDs

2011-03-17 Thread John Calixto
Part 3 of the SD Specification (SD Card Association; www.sdcard.org) describes how to use the security function of an SD card using application specific commands in conjunction with CPRM algorithms and keys licensed from the 4C Entity (www.4centity.com). This allows userspace applications to acces

Re: [PATCH 1/3] dw_mmc: set fixed burst in BMOD register

2011-03-17 Thread Chris Ball
Hi Will, On Thu, Feb 24 2011, Jaehoon Chung wrote: > This patch is applied fixed burst. > If use internal DMA controller, i think that need to set this bit. > > I tested when set this bit or not. I found that increase performance with > IDMAC > > Signed-off-by: Jaehoon Chung > Signed-off-by: Kyu

Re: [PATCH] dw_mmc: fix suspend/resume operation

2011-03-17 Thread Chris Ball
Hi, On Thu, Mar 17 2011, Jaehoon Chung wrote: > This patch is applied about re-init processing when suspend/resume. > > When card is resuming, some register is reset. > If card is removable, maybe controller should be rescan for card. > But if assume card is non-removable, need to restore the old

Re: [PATCH 3/3] dw_mmc: add quirks unreliable detect and capabilities

2011-03-17 Thread Chris Ball
Hi, On Thu, Feb 24 2011, Jaehoon Chung wrote: > This patch added quirks and capabilities in platdata. > > Some card didn't use the CDn pin. In that case, We assume card inserted, > then the card initialized or not. > And Some board need other capabilities. So added capabilities in board > platdat

Re: [PATCH 2/3] dw_mmc: support mmc power control with regulator

2011-03-17 Thread Chris Ball
Hi Jaehoon, On Thu, Feb 24 2011, Jaehoon Chung wrote: > This patch is applied the power control with regulator. > > Signed-off-by: Jaehoon Chung > Signed-off-by: kyungmin Park > --- > drivers/mmc/host/dw_mmc.c | 25 + > include/linux/mmc/dw_mmc.h |2 ++ > 2 files

[PATCH] MMC: use pci_dev->revision

2011-03-17 Thread Sergei Shtylyov
The SDHCI driver uses PCI_CLASS_REVISION instead of PCI_REVISION_ID, so it was not converted by commit 44c10138fd4bbc4b6d6bff0873c24902f2a9da65 (PCI: Change all drivers to use pci_device->revision). The newer VIA driver has the similar code too. So convert both drivers to using the 'revision' field

Re: [PATCH] dw_mmc: fix suspend/resume operation

2011-03-17 Thread Will Newton
On Thu, Mar 17, 2011 at 11:32 AM, Jaehoon Chung wrote: > This patch is applied about re-init processing when suspend/resume. > > When card is resuming, some register is reset. > If card is removable, maybe controller should be rescan for card. > But if assume card is non-removable, need to restore

[PATCH] dw_mmc: fix suspend/resume operation

2011-03-17 Thread Jaehoon Chung
This patch is applied about re-init processing when suspend/resume. When card is resuming, some register is reset. If card is removable, maybe controller should be rescan for card. But if assume card is non-removable, need to restore the old value at registers. Signed-off-by: Jaehoon Chung Signe

Re: [PATCH 2/3] dw_mmc: support mmc power control with regulator

2011-03-17 Thread Jaehoon Chung
Hi Chris.. I want to know this patch.. Regard, Jaehoon Chung Will Newton wrote: > On Fri, Feb 25, 2011 at 2:08 AM, Jaehoon Chung wrote: >> This patch is applied the power control with regulator. >> >> Signed-off-by: Jaehoon Chung >> Signed-off-by: kyungmin Park >> --- >> drivers/mmc/host/dw_

Re: [PATCH 3/3] dw_mmc: add quirks unreliable detect and capabilities

2011-03-17 Thread Jaehoon Chung
Hi Chris.. I want to know your opinion.. Regards, Jaehoon Chung Will Newton wrote: > On Fri, Feb 25, 2011 at 2:08 AM, Jaehoon Chung wrote: >> This patch added quirks and capabilities in platdata. >> >> Some card didn't use the CDn pin. In that case, We assume card inserted, >> then the card ini

Re: [PATCH] arm: mmci: Add ARM variant with extended FIFO

2011-03-17 Thread Pawel Moll
> If your hardware engineers are listening, I suggest that hardware clock > gating (as suggested in some earlier mail) I've discussed this idea with our FPGA magician at the very beginning, but for some reason we wasn't very happy about this... I can't really blame him - it's not really his job to

Re: [PATCH] arm: mmci: Add ARM variant with extended FIFO

2011-03-17 Thread Linus Walleij
On Fri, Mar 11, 2011 at 6:18 PM, Pawel Moll wrote: > New IO FPGA implementation for Versatile Express boards contain > MMCI (PL180) cell with FIFO extended to 128 words (512 bytes). OK that's the quick fix, and deeper FIFOs are always nice. If your hardware engineers are listening, I suggest th