Re: [PATCH] dw_mmc: add support for pre_req and post_req

2011-04-17 Thread Jaehoon Chung
Hi Shawn, Shawn Guo wrote: > > if (slot->host->use_dma) { > if (dw_mci_pre_dma_transfer(slot->host, mrq->data, > &slot->host->next_data) < 0) > mrq->data->host_cookie = 0; > Ok..I understood yours..:) i'll check and

Re: [PATCH] dw_mmc: add support for pre_req and post_req

2011-04-17 Thread Shawn Guo
On Mon, Apr 18, 2011 at 01:55:11PM +0900, Jaehoon Chung wrote: > Hi Shawn.. > > Shawn Guo wrote: > > Hi Jaehoon, > > > > On Thu, Apr 07, 2011 at 05:04:52PM +0900, Jaehoon Chung wrote: > > [...] > >> +static unsigned int dw_mci_pre_dma_transfer(struct dw_mci *host, > >> + struct m

Re: [PATCH] dw_mmc: add support for pre_req and post_req

2011-04-17 Thread Jaehoon Chung
Hi Shawn.. Shawn Guo wrote: > Hi Jaehoon, > > On Thu, Apr 07, 2011 at 05:04:52PM +0900, Jaehoon Chung wrote: > [...] >> +static unsigned int dw_mci_pre_dma_transfer(struct dw_mci *host, >> +struct mmc_data *data, struct dw_mci_next *next) >> +{ >> +unsigned int sg_len; >>

Re: [patchv3 5/5] MMC: SDHCI AutoCMD23 support.

2011-04-17 Thread Andrei Warkentin
Hi Arnd, On Sun, Apr 17, 2011 at 12:25 PM, Arnd Bergmann wrote: > On Saturday 16 April 2011, Andrei Warkentin wrote: >> @@ -68,6 +68,15 @@ config MMC_SDHCI_PCI >> >>           If unsure, say N. >> >> +config MMC_SDHCI_AUTO_CMD23 >> +       tristate "SDHCI 3.0 Auto-CMD23 support (EXPERIMENTAL)" >>

Re: [patchv3 2/5] MMC: Use CMD23 for multiblock transfers when we can.

2011-04-17 Thread Andrei Warkentin
Hi Arnd, On Sun, Apr 17, 2011 at 12:23 PM, Arnd Bergmann wrote: > On Saturday 16 April 2011, Andrei Warkentin wrote: >> @@ -982,6 +1016,26 @@ static const struct mmc_fixup blk_fixups[] = >>         MMC_FIXUP("SEM08G", 0x2, 0x100, add_quirk, MMC_QUIRK_INAND_CMD38), >>         MMC_FIXUP("SEM16G", 0

Re: [patchv3 5/5] MMC: SDHCI AutoCMD23 support.

2011-04-17 Thread Arnd Bergmann
On Saturday 16 April 2011, Andrei Warkentin wrote: > @@ -68,6 +68,15 @@ config MMC_SDHCI_PCI > > If unsure, say N. > > +config MMC_SDHCI_AUTO_CMD23 > + tristate "SDHCI 3.0 Auto-CMD23 support (EXPERIMENTAL)" > + depends on MMC_SDHCI && EXPERIMENTAL > + help > +

Re: [patchv3 2/5] MMC: Use CMD23 for multiblock transfers when we can.

2011-04-17 Thread Arnd Bergmann
On Saturday 16 April 2011, Andrei Warkentin wrote: > @@ -982,6 +1016,26 @@ static const struct mmc_fixup blk_fixups[] = > MMC_FIXUP("SEM08G", 0x2, 0x100, add_quirk, MMC_QUIRK_INAND_CMD38), > MMC_FIXUP("SEM16G", 0x2, 0x100, add_quirk, MMC_QUIRK_INAND_CMD38), > MMC_FIXUP("SEM3

Re: [PATCH] mmc: mxs-mmc: add support for pre_req and post_req

2011-04-17 Thread Shawn Guo
On Mon, Apr 18, 2011 at 12:33:30AM +0800, Shawn Guo wrote: > pre_req() runs dma_map_sg() post_req() runs dma_unmap_sg. > If not calling pre_req() before mxs_mmc_request(), request() > will prepare the cache just like it did it before. > It is optional to use pre_req() and post_req(). > > Signed-of

[PATCH] mmc: mxs-mmc: add support for pre_req and post_req

2011-04-17 Thread Shawn Guo
pre_req() runs dma_map_sg() post_req() runs dma_unmap_sg. If not calling pre_req() before mxs_mmc_request(), request() will prepare the cache just like it did it before. It is optional to use pre_req() and post_req(). Signed-off-by: Shawn Guo --- drivers/mmc/host/mxs-mmc.c | 75 +++

Re: [PATCH v2 03/12] mmc: mmc_test: add test for none blocking transfers

2011-04-17 Thread Shawn Guo
On Wed, Apr 06, 2011 at 09:07:04PM +0200, Per Forlin wrote: [...] > +static int mmc_test_rw_multiple(struct mmc_test_card *test, > + struct mmc_test_multiple_rw *tdata, > + unsigned int reqsize, unsigned int size) > +{ > + unsigned int dev

RE: [PATCH v2 03/12] mmc: mmc_test: add test for none blocking transfers

2011-04-17 Thread Lin Tony-B19295
Hi Per Just have a glance of your patch, good thinking. But I have a question about this patch. You modified mmc_test to test your driver. Does it mean your driver's performance enhancement depends on application? The caller must have to know the next request so that could make driver p