Re: [PATCH] sdio: optimized SDIO IRQ handling for single function

2011-05-03 Thread Nicolas Pitre
On Tue, 3 May 2011, Per Forlin wrote: > From: Stefan Nilsson XK > > If there is only 1 function registered, and IRQ:s are supported and > currently enabled, call the callback handler directly > without checking the CCCR registers. > > Signed-off-by: Stefan Nilsson XK > Signed-off-by: Per Forli

[PATCH resend] sdio: optimized SDIO IRQ handling for single function

2011-05-03 Thread Per Forlin
From: Stefan Nilsson XK If there is only 1 function registered it is possible to improve performance by avoiding the overhead of reading the CCCR registers and directly call the function handler. Signed-off-by: Stefan Nilsson XK Signed-off-by: Per Forlin --- drivers/mmc/core/sdio_irq.c | 14

Re: mmc blkqueue is empty even if there are pending reads in do_generic_file_read()

2011-05-03 Thread Per Forlin
On 3 May 2011 22:02, Arnd Bergmann wrote: > On Tuesday 03 May 2011 20:54:43 Per Forlin wrote: >> >> page_not_up_to_date: >> >> /* Get exclusive access to the page ... */ >> >> error = lock_page_killable(page); >> > I looked at the code in do_generic_file_read(). lock_page_killable >> > waits until

[PATCH] sdio: optimized SDIO IRQ handling for single function

2011-05-03 Thread Per Forlin
From: Stefan Nilsson XK If there is only 1 function registered, and IRQ:s are supported and currently enabled, call the callback handler directly without checking the CCCR registers. Signed-off-by: Stefan Nilsson XK Signed-off-by: Per Forlin --- drivers/mmc/core/sdio_irq.c | 14

Re: mmc blkqueue is empty even if there are pending reads in do_generic_file_read()

2011-05-03 Thread Arnd Bergmann
On Tuesday 03 May 2011 20:54:43 Per Forlin wrote: > >> page_not_up_to_date: > >> /* Get exclusive access to the page ... */ > >> error = lock_page_killable(page); > > I looked at the code in do_generic_file_read(). lock_page_killable > > waits until the current read ahead is completed. > > Is it po

Re: mmc blkqueue is empty even if there are pending reads in do_generic_file_read()

2011-05-03 Thread Per Forlin
On 3 May 2011 15:16, Arnd Bergmann wrote: > On Thursday 28 April 2011, Per Forlin wrote: > >> For reads on the other hand it look like this >> root@(none):/ dd if=/dev/mmcblk0 of=/dev/null bs=4k count=256 >> 256+0 records in >> 256+0 records out >> root@(none):/ dmesg >> [mmc_queue_thread] req d95

Re: Is it possible for the ext4/btrfs file system to pass some context related info to low level block driver?

2011-05-03 Thread Martin K. Petersen
> "Yunpeng" == Gao, Yunpeng writes: Yunpeng> So, my question is, is there any plan or discussion on Yunpeng> supporting this feature (passing data type info to low level Yunpeng> block device driver) on file system developments? Especially Yunpeng> for ext4/btrfs, since now they are very hot

Re: mmc blkqueue is empty even if there are pending reads in do_generic_file_read()

2011-05-03 Thread Arnd Bergmann
On Thursday 28 April 2011, Per Forlin wrote: > For reads on the other hand it look like this > root@(none):/ dd if=/dev/mmcblk0 of=/dev/null bs=4k count=256 > 256+0 records in > 256+0 records out > root@(none):/ dmesg > [mmc_queue_thread] req d954cec0 blocks 32 > [mmc_queue_thread] req (null) bl

Re: [PATCH] mmc: mmc_add_card(): fix missing break in switch statement

2011-05-03 Thread Prashanth Bhat
To be more specific, I would think that the code change required in include/linux/mmc/card.h is: #define mmc_card_mmc(c) ((c)->type == MMC_TYPE_MMC) - #define mmc_card_sd(c) ((c)->type == MMC_TYPE_SD) - #define mmc_card_sdio(c)((c)->type == MMC_TYPE_SDIO) + #define mmc_

Re: [PATCH] mmc: mmc_add_card(): fix missing break in switch statement

2011-05-03 Thread Prashanth Bhat
Michal, I hope you remember the email exchange we had about a month ago. I think I see an issue with SD-COMBO support. In include/linux/mmc/card.h, there are macros: #define mmc_card_mmc(c) ((c)->type == MMC_TYPE_MMC) #define mmc_card_sd(c) ((c)->type == MMC_TYPE_SD) #define

[GIT PULL] MMC fixes for 2.6.39-rc6

2011-05-03 Thread Chris Ball
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git for-linus to receive seven small fixes for MMC. These have been tested in linux-next. Thanks. The following changes since commit e8dad69408a9812d6bb42d03e74d2c314534a4fa: Linus Torvalds (1): Merg