Re: MMC runtime PM patches break libertas probe

2011-05-29 Thread Ohad Ben-Cohen
Hi Daniel, On Sun, May 29, 2011 at 7:21 PM, Daniel Drake wrote: > It's certainly possible that there's something weird about the > hardware in question, but we *are* able to successfully power down and > up the card with a hacky rfkill driver that calls mmc_stop_host / > mmc_start_host. Are we t

Re: [PATCH v2 1/3] mmc: support sdhci-mmp2

2011-05-29 Thread Philip Rakity
On May 29, 2011, at 10:42 PM, zhangfei gao wrote: > On Fri, May 27, 2011 at 11:46 AM, Arnd Bergmann wrote: >> On Wednesday 25 May 2011, Zhangfei Gao wrote: >>> Instead of sharing sdhci-pxa.c, use sdhci-mmp2.c specificlly for mmp2. >>> sdhci-pxa.c is used to share among pxa serious, l

Re: [PATCH v2 1/3] mmc: support sdhci-mmp2

2011-05-29 Thread zhangfei gao
On Fri, May 27, 2011 at 11:46 AM, Arnd Bergmann wrote: > On Wednesday 25 May 2011, Zhangfei Gao wrote: >>       Instead of sharing sdhci-pxa.c, use sdhci-mmp2.c specificlly for mmp2. >>       sdhci-pxa.c is used to share among pxa serious, like pxa910, mmp2, etc. >>       The platfrom difference a

Re: MMC runtime PM patches break libertas probe

2011-05-29 Thread Daniel Drake
Hi Ohad, On 31 October 2010 19:06, Ohad Ben-Cohen wrote: > OK, as expected. > > So to summarize: > 1. Card is powered up at boot, and successfully initialized > 2. After mmc + sdio devices are added to the device tree, power is > (seemingly) taken down by runtime PM > 3. When the driver is loaded

Re: Possible bug in sdio.c?

2011-05-29 Thread Chris Ball
Hi, On Sun, May 29 2011, Prashanth Bhat wrote: > Could you please clarify the formal process for including these > changes into the build? I have made the previous changes in my private > code tree only so far. See Documentation/SubmittingPatches, and send the patch you generate to the same list

Re: Possible bug in sdio.c?

2011-05-29 Thread Prashanth Bhat
On Sunday 29 May 2011 07:42 PM, Michał Mirosław wrote: On Sun, May 29, 2011 at 07:26:00AM +0530, Prashanth Bhat wrote: Hi Michał, In mmc/core/sdio.c, routine mmc_enable_4bit_bus(): I think: if (card->type == MMC_TYPE_SDIO) return sdio_enable_wide(card); should really b

Re: SDIO single IRQ optimization breaks libertas

2011-05-29 Thread Daniel Drake
On 29 May 2011 15:26, Daniel Drake wrote: > Hi, > > The following commit in 2.6.39 causes instant death for libertas_sdio > when it receives its first interrupt during initialization: > > commit 06e8935febe687e2a561707d4c7ca4245d261dbe The crash happens on this line of code in if_sdio_interrupt:

SDIO single IRQ optimization breaks libertas

2011-05-29 Thread Daniel Drake
Hi, The following commit in 2.6.39 causes instant death for libertas_sdio when it receives its first interrupt during initialization: commit 06e8935febe687e2a561707d4c7ca4245d261dbe Author: Stefan Nilsson XK Date: Wed May 11 17:48:05 2011 +0200 mmc: sdio: optimized SDIO IRQ handling for s

Re: Possible bug in sdio.c?

2011-05-29 Thread Michał Mirosław
On Sun, May 29, 2011 at 07:26:00AM +0530, Prashanth Bhat wrote: > Hi Michał, > In mmc/core/sdio.c, routine mmc_enable_4bit_bus(): > > I think: > > if (card->type == MMC_TYPE_SDIO) > return sdio_enable_wide(card); > > should really be: > > if (card->type == MMC_TYPE_SDIO ||