Re: [PATCH 1/3] irq: If an IRQ is a GPIO, request and configure it

2011-08-04 Thread Mark Brown
On Thu, Aug 04, 2011 at 08:53:34PM -0700, Stephen Warren wrote: > Well, things break. This is essentially the problem I was describing in > the PATCH 0 email, just with a slightly different motivation. There's a bunch of existing code using that idiom. > I suppose that an alternative here would

RE: [PATCH 1/3] irq: If an IRQ is a GPIO, request and configure it

2011-08-04 Thread Stephen Warren
Rob Herring wrote at Thursday, August 04, 2011 7:55 PM: > On 08/04/2011 06:00 PM, Stephen Warren wrote: > > Many IRQs are associated with GPIO pins. When the pin is used as an IRQ, > > it can't be used as anything else; it should be requested. Enhance the > > core interrupt code to call gpio_reques

RE: [PATCH 1/3] irq: If an IRQ is a GPIO, request and configure it

2011-08-04 Thread Stephen Warren
Mark Brown wrote at Thursday, August 04, 2011 6:02 PM: > On Thu, Aug 04, 2011 at 05:00:18PM -0600, Stephen Warren wrote: > > > + } else { > > + gpio = irq_to_gpio(irq); > > + if (gpio_is_valid(gpio)) { > > + ret = gpio_request(gpio, new->name); > > +

[PATCH] mmc: dw_mmc: Fix DDR mode support.

2011-08-04 Thread Seungwon Jeon
Host driver can't get a hint of DDR mode through ios->ddr flag anymore. ios->timing is currently used to inform DDR mode as a substitute. And capability of MMC_CAP_MMC_HIGHSPEED is added for DDR support. Signed-off-by: Seungwon Jeon --- drivers/mmc/host/dw_mmc.c |4 ++-- 1 files changed, 2 i

Re: [PATCH 1/3] irq: If an IRQ is a GPIO, request and configure it

2011-08-04 Thread Rob Herring
On 08/04/2011 06:00 PM, Stephen Warren wrote: > Many IRQs are associated with GPIO pins. When the pin is used as an IRQ, > it can't be used as anything else; it should be requested. Enhance the > core interrupt code to call gpio_request() and gpio_direction_input() for > any IRQ that is also a GPIO

Re: [PATCH 1/3] irq: If an IRQ is a GPIO, request and configure it

2011-08-04 Thread Mark Brown
On Thu, Aug 04, 2011 at 05:00:18PM -0600, Stephen Warren wrote: > + } else { > + gpio = irq_to_gpio(irq); > + if (gpio_is_valid(gpio)) { > + ret = gpio_request(gpio, new->name); > + if (ret < 0) > + got

[PATCH 3/3] ASoC: jack_add_gpios: Don't gpio_request GPIOs used as IRQs.

2011-08-04 Thread Stephen Warren
request_any_context_irq now performs this internally. Remove the exra calls from the driver so that request_any_context_irq succeeds. Signed-off-by: Stephen Warren --- sound/soc/soc-jack.c | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/sound/soc/soc-jack.c

[RFC PATCH 0/3] If an IRQ is a GPIO, request and configure it

2011-08-04 Thread Stephen Warren
In http://www.spinics.net/lists/linux-tegra/msg01731.html, Mark Brown pointed out that it was a little silly forcing every board or driver to gpio_request() a GPIO that is later converted to an IRQ, and passed to request_irq. The first patch in this series instead makes the core IRQ code perform th

[PATCH 2/3] mmc: tegra: Don't gpio_request GPIOs used as IRQs.

2011-08-04 Thread Stephen Warren
request_irq now performs this internally. Remove the exra calls from the driver so that request_irq succeeds. Signed-off-by: Stephen Warren --- drivers/mmc/host/sdhci-tegra.c |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/

[PATCH 1/3] irq: If an IRQ is a GPIO, request and configure it

2011-08-04 Thread Stephen Warren
Many IRQs are associated with GPIO pins. When the pin is used as an IRQ, it can't be used as anything else; it should be requested. Enhance the core interrupt code to call gpio_request() and gpio_direction_input() for any IRQ that is also a GPIO. This prevents duplication of these calls in each dri

Re: [PATCH 1/1] Add support for JMicron chip with UHS-I function

2011-08-04 Thread Chris Ball
Hi Aries, On Thu, Aug 04 2011, Aries Lee wrote: > 1. Force to assign some property at sdhci_add_host() function. > > 2. Jmicron doesn't support CMD19, install of tuning command, Jmicron run a > procedure to tune the clock delay, command delay and data delay. Actually I > want to define a quirks su

[PATCH v1 1/1] mmc: sd: UHS-I bus speed should be set last in UHS initialization

2011-08-04 Thread Subhash Jadavani
mmc_sd_init_uhs_card function sets the driver type, current limit and bus speed mode on card as well as on host controller side. Currently bus speed mode is set by sending CMD6 to card and immediately setting the timing mode in host controller. But then before initiating tuning sequence, it also t

Re: A few queries dw_mmc driver

2011-08-04 Thread James Hogan
Hi Shashidhar On 08/02/2011 10:47 PM, James Hogan wrote: >> I was adding the support for Dual_Buffer Descriptors support in dw_mmc >> driver.Does it require a change in the above elements of mmc_host >> structure ? > > I don't know, but I'll see if I can find out. The initial IDMAC settings we

Re: [PATCH v4] ARM: davinci: AM18x: Add wl1271/wlan support

2011-08-04 Thread Ido Yariv
Hi Jaya, On Thu, Aug 04, 2011 at 04:40:01PM +0800, Jaya Kumar wrote: > Hi Ido, > > A quick question for my own understanding. What's the mechanism by > which wl12xx is bound with above. I see above wl12xx_set_platform_data > but I didn't see something like .name = "wl1271" or dev_name that > come

Re: [PATCH v4] ARM: davinci: AM18x: Add wl1271/wlan support

2011-08-04 Thread Jaya Kumar
On Thu, Aug 4, 2011 at 3:51 PM, Ido Yariv wrote: > +static __init int da850_wl12xx_init(void) > +{ > +       int ret; > + > +       ret = davinci_cfg_reg_list(da850_wl12xx_pins); > +       if (ret) { > +               pr_err("wl12xx/mmc mux setup failed: %d\n", ret); > +               goto exit; >

[PATCH v4] ARM: davinci: AM18x: Add wl1271/wlan support

2011-08-04 Thread Ido Yariv
The wl1271 daughter card for AM18x EVMs is a combo wireless connectivity add-on card, based on the LS Research TiWi module with Texas Instruments' wl1271 solution. It is a 4-wire, 1.8V, embedded SDIO WLAN device with an external IRQ line and is power-controlled by a GPIO-based fixed regulator. Add

[PATCH 1/1] Add support for JMicron chip with UHS-I function

2011-08-04 Thread Aries Lee
1. Force to assign some property at sdhci_add_host() function. 2. Jmicron doesn't support CMD19, install of tuning command, Jmicron run a procedure to tune the clock delay, command delay and data delay. Actually I want to define a quirks such like "SDHCI_QUIRK_NONSTANDARD_TUNE", but it run out th