Re: [RFC PATCH 0/3] If an IRQ is a GPIO, request and configure it

2011-08-05 Thread Russell King - ARM Linux
On Fri, Aug 05, 2011 at 12:33:31PM -0700, Stephen Warren wrote: > Russell King - ARM Linux wrote at Friday, August 05, 2011 1:15 PM: > > On Fri, Aug 05, 2011 at 08:43:20AM -0700, Stephen Warren wrote: > > > Russell King - ARM Linux wrote at Friday, August 05, 2011 3:40 AM: > > > > On Thu, Aug 04, 2

Re: [PATCH] mmc: dw_mmc: Fix DDR mode support.

2011-08-05 Thread Jae hoon Chung
Hi Seungwon This patch is looks fine to me.. Just ask to you...Don't you want to locate MMC_CAP_MMC_HIGHSPEED in platdata? Regards, Jaehoon Chung 2011/8/5 Will Newton : > On Fri, Aug 5, 2011 at 4:35 AM, Seungwon Jeon wrote: >> Host driver can't get a hint of DDR mode through ios->ddr flag any

Re: [RFC PATCH 0/3] If an IRQ is a GPIO, request and configure it

2011-08-05 Thread Linus Walleij
On Fri, Aug 5, 2011 at 12:30 PM, Ben Dooks wrote: > On Fri, Aug 05, 2011 at 10:40:17AM +0100, Russell King - ARM Linux wrote: >> Trying to go from IRQ to GPIO is not a good idea - most of the >> IRQ <-> GPIO macros we have today are just plain broken.  Many of them >> just add or subtract a consta

RE: [RFC PATCH 0/3] If an IRQ is a GPIO, request and configure it

2011-08-05 Thread Stephen Warren
Russell King - ARM Linux wrote at Friday, August 05, 2011 1:15 PM: > On Fri, Aug 05, 2011 at 08:43:20AM -0700, Stephen Warren wrote: > > Russell King - ARM Linux wrote at Friday, August 05, 2011 3:40 AM: > > > On Thu, Aug 04, 2011 at 05:00:17PM -0600, Stephen Warren wrote: > > > > In http://www.spi

Re: [RFC PATCH 0/3] If an IRQ is a GPIO, request and configure it

2011-08-05 Thread Russell King - ARM Linux
On Fri, Aug 05, 2011 at 08:43:20AM -0700, Stephen Warren wrote: > Russell King - ARM Linux wrote at Friday, August 05, 2011 3:40 AM: > > On Thu, Aug 04, 2011 at 05:00:17PM -0600, Stephen Warren wrote: > > > In http://www.spinics.net/lists/linux-tegra/msg01731.html, Mark Brown > > > pointed out that

RE: Issue with non-UHS-I SD3.0 cards

2011-08-05 Thread Nath, Arindam
> -Original Message- > From: Nath, Arindam > Sent: Saturday, August 06, 2011 12:27 AM > To: 'Subhash Jadavani'; 'linux-mmc@vger.kernel.org' > Cc: 'Chris Ball'; 'Philip Rakity'; 'zhangfei gao' > Subject: RE: Issue with non-UHS-I SD3.0 cards > > > > > -Original Message- > > From:

RE: Issue with non-UHS-I SD3.0 cards

2011-08-05 Thread Nath, Arindam
> -Original Message- > From: Nath, Arindam > Sent: Saturday, August 06, 2011 12:15 AM > To: 'Subhash Jadavani'; linux-mmc@vger.kernel.org > Cc: 'Chris Ball'; 'Philip Rakity'; 'zhangfei gao' > Subject: RE: Issue with non-UHS-I SD3.0 cards > > Hi Subhash, > > > > -Original Message---

RE: Issue with non-UHS-I SD3.0 cards

2011-08-05 Thread Nath, Arindam
Hi Subhash, > -Original Message- > From: Subhash Jadavani [mailto:subha...@codeaurora.org] > Sent: Friday, August 05, 2011 7:01 PM > To: linux-mmc@vger.kernel.org > Cc: Nath, Arindam; 'Chris Ball'; 'Philip Rakity'; 'zhangfei gao' > Subject: Issue with non-UHS-I SD3.0 cards > > Hi, > > I

RE: [PATCH v1 1/1] mmc: sd: UHS-I bus speed should be set last in UHS initialization

2011-08-05 Thread Nath, Arindam
Hi Subhash, The patch in general looks good to me, I have one comment below. > -Original Message- > From: Subhash Jadavani [mailto:subha...@codeaurora.org] > Sent: Friday, August 05, 2011 9:55 PM > To: linux-mmc@vger.kernel.org; Nath, Arindam; 'Philip Rakity' > Cc: linux-arm-...@vger.kern

RE: [PATCH v1 1/1] mmc: sd: UHS-I bus speed should be set last in UHS initialization

2011-08-05 Thread Subhash Jadavani
Chris, Arindam, Philip, Please let me know you comments on this reworked patch. Regards, Subhash > -Original Message- > From: linux-arm-msm-ow...@vger.kernel.org [mailto:linux-arm-msm- > ow...@vger.kernel.org] On Behalf Of Subhash Jadavani > Sent: Thursday, August 04, 2011 4:08 PM > To:

Re: [PATCH 1/3] irq: If an IRQ is a GPIO, request and configure it

2011-08-05 Thread Mark Brown
On Fri, Aug 05, 2011 at 08:29:38AM -0700, Stephen Warren wrote: > Mark Brown wrote at Thursday, August 04, 2011 11:35 PM: > > But it's not a bug to use a GPIO as an IRQ source, otherwise we wouldn't > > have gpio_to_irq() in the first place. > 2) Two pieces of unrelated code somehow accidentally

RE: [RFC PATCH 0/3] If an IRQ is a GPIO, request and configure it

2011-08-05 Thread Stephen Warren
Russell King - ARM Linux wrote at Friday, August 05, 2011 3:40 AM: > On Thu, Aug 04, 2011 at 05:00:17PM -0600, Stephen Warren wrote: > > In http://www.spinics.net/lists/linux-tegra/msg01731.html, Mark Brown > > pointed out that it was a little silly forcing every board or driver > > to gpio_request

RE: [PATCH 1/3] irq: If an IRQ is a GPIO, request and configure it

2011-08-05 Thread Stephen Warren
Mark Brown wrote at Thursday, August 04, 2011 11:35 PM: > On Thu, Aug 04, 2011 at 08:53:34PM -0700, Stephen Warren wrote: > > > Well, things break. This is essentially the problem I was describing in > > the PATCH 0 email, just with a slightly different motivation. > > There's a bunch of existing

Issue with non-UHS-I SD3.0 cards

2011-08-05 Thread Subhash Jadavani
Hi, I am seeing the issue where "SanDisk Extreme SDHC 8GB Class 10 card" is running in "Default Speed" mode even though it supports "High Speed" mode. After analysis, I found that this card is advertising itself as SD3.0 card (with SD_SPEC=2 and SD_SPEC3=1 in SCR). But current mmc core later initi

Re: [RFC PATCH 0/3] If an IRQ is a GPIO, request and configure it

2011-08-05 Thread Ben Dooks
On Fri, Aug 05, 2011 at 10:40:17AM +0100, Russell King - ARM Linux wrote: > On Thu, Aug 04, 2011 at 05:00:17PM -0600, Stephen Warren wrote: > > In http://www.spinics.net/lists/linux-tegra/msg01731.html, Mark Brown > > pointed out that it was a little silly forcing every board or driver > > to gpio_

Re: [PATCH] mmc: dw_mmc: Fix DDR mode support.

2011-08-05 Thread Will Newton
On Fri, Aug 5, 2011 at 4:35 AM, Seungwon Jeon wrote: > Host driver can't get a hint of DDR mode through ios->ddr flag anymore. > ios->timing is currently used to inform DDR mode as a substitute. > And capability of MMC_CAP_MMC_HIGHSPEED is added for DDR support. > > Signed-off-by: Seungwon Jeon >

Re: [RFC PATCH 0/3] If an IRQ is a GPIO, request and configure it

2011-08-05 Thread Russell King - ARM Linux
On Thu, Aug 04, 2011 at 05:00:17PM -0600, Stephen Warren wrote: > In http://www.spinics.net/lists/linux-tegra/msg01731.html, Mark Brown > pointed out that it was a little silly forcing every board or driver > to gpio_request() a GPIO that is later converted to an IRQ, and passed > to request_irq. T

Re: [PATCH 1/3] irq: If an IRQ is a GPIO, request and configure it

2011-08-05 Thread Mark Brown
On Fri, Aug 05, 2011 at 09:06:20AM +0100, Ben Dooks wrote: > I would say that setting the interrupt should deal with all the necessary > configuration to get that interrupt working. In the case of pretty much all > of the SoCs I have been involved with have always set the GPIO's function > to allo

Re: [PATCH 1/3] irq: If an IRQ is a GPIO, request and configure it

2011-08-05 Thread Ben Dooks
On Fri, Aug 05, 2011 at 06:35:11AM +0100, Mark Brown wrote: > On Thu, Aug 04, 2011 at 08:53:34PM -0700, Stephen Warren wrote: > > > Well, things break. This is essentially the problem I was describing in > > the PATCH 0 email, just with a slightly different motivation. > > There's a bunch of exi

Re: [PATCH 1/3] irq: If an IRQ is a GPIO, request and configure it

2011-08-05 Thread Ben Dooks
On Thu, Aug 04, 2011 at 05:00:18PM -0600, Stephen Warren wrote: > Many IRQs are associated with GPIO pins. When the pin is used as an IRQ, > it can't be used as anything else; it should be requested. Enhance the > core interrupt code to call gpio_request() and gpio_direction_input() for > any IRQ t

Re: [RFC PATCH 0/3] If an IRQ is a GPIO, request and configure it

2011-08-05 Thread Ben Dooks
On Thu, Aug 04, 2011 at 05:00:17PM -0600, Stephen Warren wrote: > In http://www.spinics.net/lists/linux-tegra/msg01731.html, Mark Brown > pointed out that it was a little silly forcing every board or driver > to gpio_request() a GPIO that is later converted to an IRQ, and passed > to request_irq. T