[PATCH 1/5] mmc i.MX: remove individual SoC dependency

2011-08-23 Thread Sascha Hauer
The individual SoC dependency in Kconfig hardly scales anymore. Instead of having such a fine grained dependency just depend on ARCH_MXC and risk that the uninformed user has to look in the help text to figure out which driver is the correct one. Signed-off-by: Sascha Hauer Cc: Chris Ball Cc: li

[PATCH] mmc: sdhci: add support for re-tuning mode 2

2011-08-23 Thread Aaron Lu
Hosts which support re-tuning mode 2 has the capability to indicate the re-tuning timing by issuing re-tuning request during data transfers. During non-data transfers, re-tuning timing is determined by either re-tuning timer or re-tuning request. Since there is no way to determine the host's capab

Re: RFC : mmc: mmc_blk_issue_secdiscard_rq() and mmc_blk_issue_discard_rq() effectively merged into one.

2011-08-23 Thread Kyungmin Park
Hi, On Wed, Aug 24, 2011 at 2:09 PM, NamJae Jeon wrote: > Hi. > > I am wordering why mmc_blk_issue_secdiscard_rq() and > mmc_blk_issue_discard_rq() is seperated. > So I try to make mmc_blk_issue_secdiscard_rq() and > mmc_blk_issue_discard_rq() effectively merged into one. > > I want to know your

Re: [PATCH 0/4 v7] mmc: tmio, sdhi: provide multiple irq handlers

2011-08-23 Thread Simon Horman
On Fri, Aug 19, 2011 at 04:57:18PM +0900, Simon Horman wrote: > The SDHI driver already supports making use of up to three interrupt > sources. > > This series breaks up the existing interrupt handler into three handlers, > one for card access, one for card detect interrupts, and one for SDIO > in

RFC : mmc: mmc_blk_issue_secdiscard_rq() and mmc_blk_issue_discard_rq() effectively merged into one.

2011-08-23 Thread NamJae Jeon
Hi. I am wordering why mmc_blk_issue_secdiscard_rq() and mmc_blk_issue_discard_rq() is seperated. So I try to make mmc_blk_issue_secdiscard_rq() and mmc_blk_issue_discard_rq() effectively merged into one. I want to know your opinion. Thanks. -

Re: [PATCH 2/2] mmc: fix integer assignments to pointer

2011-08-23 Thread J Freyensee
On 08/23/2011 09:56 AM, Sam Ravnborg wrote: On Tue, Aug 23, 2011 at 12:31:55PM -0400, Chris Ball wrote: Hi, [Adding linux-sparse@ to CC] On Tue, Aug 23 2011, Venkatraman S wrote: Fix the sparse warning output "warning: Using plain integer as NULL pointer" Signed-off-by: Venkatraman S --- d

Re: [PATCH 2/2] mmc: fix integer assignments to pointer

2011-08-23 Thread Ben Pfaff
Josh Triplett writes: > On Tue, Aug 23, 2011 at 11:04:08AM -0700, Ben Pfaff wrote: >> Josh Triplett writes: >> >> > On Tue, Aug 23, 2011 at 12:31:55PM -0400, Chris Ball wrote: >> >> On Tue, Aug 23 2011, Venkatraman S wrote: >> >> > - struct mmc_request mrq = {0}; >> >> > + struct mm

Re: [PATCH 2/2] mmc: fix integer assignments to pointer

2011-08-23 Thread Sam Ravnborg
> > I'm still a little confused -- the {0} or memset(0, struct ..); > formations are used often in the kernel, even with pointers involved. > Is the warning (Wnon_pointer_null) run against the kernel by default, > or did Venkatraman add it manually? If default, is it catching bugs? Did a quick "

Re: [PATCH 2/2] mmc: fix integer assignments to pointer

2011-08-23 Thread Sam Ravnborg
On Tue, Aug 23, 2011 at 02:28:42PM -0400, Chris Ball wrote: > Hi, > > On Tue, Aug 23 2011, Josh Triplett wrote: > > {} produces the same effect, as far as I know. > > Yeah. I prefer {0}, because {} is a gcc-ism (the ANSI grammar demands > initializer-lists be non-empty) and is less readable for

Re: [PATCH 2/2] mmc: fix integer assignments to pointer

2011-08-23 Thread Ben Pfaff
Josh Triplett writes: > On Tue, Aug 23, 2011 at 12:31:55PM -0400, Chris Ball wrote: >> On Tue, Aug 23 2011, Venkatraman S wrote: >> > - struct mmc_request mrq = {0}; >> > + struct mmc_request mrq = {NULL}; >> >> The sparse warning is mistaken. Or I'm mistaken. But I suspect it's >> the spars

Re: [PATCH 1/2] sdhci/tegra: Add Device Tree probing support

2011-08-23 Thread Chris Ball
Hi Stephen, On Tue, Aug 23 2011, Stephen Warren wrote: > From: Grant Likely > > Add hooks to read gpio configuration out of the device tree node. > > [grant.likely: Rewrite of original patch from John Bonesio] > Signed-off-by: Grant Likely > [swarren: Fixed tegra_sdhci_get_ro() to retrieve pdata

Re: [PATCH 2/2] mmc: fix integer assignments to pointer

2011-08-23 Thread Chris Ball
Hi, On Tue, Aug 23 2011, Josh Triplett wrote: > {} produces the same effect, as far as I know. Yeah. I prefer {0}, because {} is a gcc-ism (the ANSI grammar demands initializer-lists be non-empty) and is less readable for people who haven't seen the idiom before and are wondering what's going on

RE: [PATCH] mmc: sdhci-tegra: get_ro(): Retrieve pdata correctly

2011-08-23 Thread Stephen Warren
Stephen Warren wrote at Tuesday, August 09, 2011 12:17 PM: > The active platform data pointer is stored as pltfm_host->priv, and not > always in the platform device itself. In particular, the platform data in > the platform device is NULL when the platform data comes from Device Tree. > > Signed-o

[PATCH 1/2] sdhci/tegra: Add Device Tree probing support

2011-08-23 Thread Stephen Warren
From: Grant Likely Add hooks to read gpio configuration out of the device tree node. [grant.likely: Rewrite of original patch from John Bonesio] Signed-off-by: Grant Likely [swarren: Fixed tegra_sdhci_get_ro() to retrieve pdata correctly] [swarren: Reworked to avoid #ifdef CONFIG_OF] [swarren:

[PATCH 2/2] arm/dt: Tegra: Update SDHCI nodes to match bindings

2011-08-23 Thread Stephen Warren
The bindings were recently updated to be more in-line with other SDHCI bindings that are already merged. Signed-off-by: Stephen Warren --- arch/arm/boot/dts/tegra-harmony.dts | 12 ++-- arch/arm/boot/dts/tegra-seaboard.dts |6 +++--- 2 files changed, 9 insertions(+), 9 deletions(-

Re: [PATCH 2/2] mmc: fix integer assignments to pointer

2011-08-23 Thread Josh Triplett
On Tue, Aug 23, 2011 at 11:04:08AM -0700, Ben Pfaff wrote: > Josh Triplett writes: > > > On Tue, Aug 23, 2011 at 12:31:55PM -0400, Chris Ball wrote: > >> On Tue, Aug 23 2011, Venkatraman S wrote: > >> > -struct mmc_request mrq = {0}; > >> > +struct mmc_request mrq = {NULL}; > >>

Re: [PATCH 2/2] mmc: fix integer assignments to pointer

2011-08-23 Thread Chris Ball
Hi, On Tue, Aug 23 2011, Sam Ravnborg wrote: >> So we're not assigning 0 to a pointer, or whatever sparse thinks we're >> doing -- we're initializing every member of the struct with 0, which is >> a good and safe way to initialize it. >> >> Sparse folks, any comment? > > The struct looks like thi

Re: [PATCH 2/2] mmc: fix integer assignments to pointer

2011-08-23 Thread Josh Triplett
On Tue, Aug 23, 2011 at 12:31:55PM -0400, Chris Ball wrote: > Hi, > > [Adding linux-sparse@ to CC] > > On Tue, Aug 23 2011, Venkatraman S wrote: > > Fix the sparse warning output > > "warning: Using plain integer as NULL pointer" > > > > Signed-off-by: Venkatraman S > > --- > > drivers/mmc/card

Re: [PATCH 2/2] mmc: fix integer assignments to pointer

2011-08-23 Thread Sam Ravnborg
On Tue, Aug 23, 2011 at 12:31:55PM -0400, Chris Ball wrote: > Hi, > > [Adding linux-sparse@ to CC] > > On Tue, Aug 23 2011, Venkatraman S wrote: > > Fix the sparse warning output > > "warning: Using plain integer as NULL pointer" > > > > Signed-off-by: Venkatraman S > > --- > > drivers/mmc/card

Re: [PATCH 2/2] mmc: fix integer assignments to pointer

2011-08-23 Thread Chris Ball
Hi, [Adding linux-sparse@ to CC] On Tue, Aug 23 2011, Venkatraman S wrote: > Fix the sparse warning output > "warning: Using plain integer as NULL pointer" > > Signed-off-by: Venkatraman S > --- > drivers/mmc/card/block.c|4 ++-- > drivers/mmc/core/core.c |2 +- > drivers/mmc/co

[PATCH 2/2] mmc: fix integer assignments to pointer

2011-08-23 Thread Venkatraman S
Fix the sparse warning output "warning: Using plain integer as NULL pointer" Signed-off-by: Venkatraman S --- drivers/mmc/card/block.c|4 ++-- drivers/mmc/core/core.c |2 +- drivers/mmc/core/mmc_ops.c |4 ++-- drivers/mmc/core/sdio_ops.c |2 +- 4 files changed, 6 inserti

[PATCH 1/2] mmc: queue: declare mmc_alloc_sg as static

2011-08-23 Thread Venkatraman S
Fix the sparse warning "drivers/mmc/card/queue.c:111:20: warning: symbol 'mmc_alloc_sg' was not declared. Should it be static?" Signed-off-by: Venkatraman S --- drivers/mmc/card/queue.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/card/queue.c b/drivers/

[PATCH 0/2] mmc: trivial patches to fix sparse warnings

2011-08-23 Thread Venkatraman S
Couple of patches to cleanup warnings generated by sparse tool. Venkatraman S (2): mmc: queue: declare mmc_alloc_sg as static mmc: fix integer assignments to pointer drivers/mmc/card/block.c|4 ++-- drivers/mmc/card/queue.c|2 +- drivers/mmc/core/core.c |2 +- drivers

Re: Fixes for the MSM SDCC driver on msm7200a

2011-08-23 Thread David Brown
On Tue, Aug 23, 2011 at 04:16:37PM +0530, Sahitya Tummala wrote: > Both these patches looks good to me. > > Acked-by: Sahitya Tummala I'll pull these in, then. Thanks. David -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of th

Re: [PATCH v2 1/1] mmc: Support of SDIO irq for dw_mmc

2011-08-23 Thread James Hogan
Hi, On 23 August 2011 14:20, Shashidhar Hiremath wrote: > The Patch adds the support for SDIO interrupts for all slots. > It includes enabling of SDIO interrupts through dw_mci_enable_sdio_irq > and the handling of the slot specific interrupts in the Interrupt Service > Routine. > > Signed-off-by

[PATCH v2 1/1] mmc: Support of SDIO irq for dw_mmc

2011-08-23 Thread Shashidhar Hiremath
The Patch adds the support for SDIO interrupts for all slots. It includes enabling of SDIO interrupts through dw_mci_enable_sdio_irq and the handling of the slot specific interrupts in the Interrupt Service Routine. Signed-off-by: Shashidhar Hiremath --- v2: * As per Suggestions by James Hogan -f

RE: [PATCH v2 1/1] mmc: sd: UHS-I bus speed should be set last in UHS initialization

2011-08-23 Thread Nath, Arindam
Hi Subhash, The patch looks good to me. Reviewed-by: Arindam Nath Thanks, Arindam > -Original Message- > From: Subhash Jadavani [mailto:subha...@codeaurora.org] > Sent: Tuesday, August 23, 2011 5:14 PM > To: Nath, Arindam > Subject: RE: [PATCH v2 1/1] mmc: sd: UHS-I bus speed should be

Re: Fixes for the MSM SDCC driver on msm7200a

2011-08-23 Thread Sahitya Tummala
Hi Alexander, Both these patches looks good to me. Acked-by: Sahitya Tummala Thanks, Sahitya. -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. On 8/21/2011 5:22 PM, Alexander Tarasikov wrote: These two

Re: [PATCH 3/4] mmci: sync DATAEND irq with dma|pio transfer done

2011-08-23 Thread Ulf Hansson
Russell King - ARM Linux wrote: On Tue, Jun 28, 2011 at 09:57:40AM +0200, Linus Walleij wrote: From: Ulf Hansson The end of a dma|pio data transfer is synced with the DATAEND irq. This will prevent the mmci driver from ending the request before the dma|pio job is completely done. For dma we u

Re: [PATCH 1/1] mmc: Support of SDIO irq for dw_mmc

2011-08-23 Thread James Hogan
Hi On 23 August 2011 09:38, Shashidhar Hiremath wrote: > Resending the patch in plain  text format. > > > > The Patch adds the support for SDIO interrupts for all slots. > It includes enabling of SDIO interrupts through dw_mci_enable_sdio_irq > and the handling of the slot specific interrupts in

Re: [PATCH 1/1] mmc: Support of SDIO irq for dw_mmc

2011-08-23 Thread Will Newton
On Tue, Aug 23, 2011 at 9:20 AM, Shashidhar Hiremath wrote: > The Patch adds the support for SDIO interrupts for all slots. > It includes enabling of SDIO interrupts through dw_mci_enable_sdio_irq > and the handling of the slot specific interrupts in the Interrupt Service > Routine. > > Signed-off

[PATCH 1/1] mmc: Support of SDIO irq for dw_mmc

2011-08-23 Thread Shashidhar Hiremath
Resending the patch in plain text format. The Patch adds the support for SDIO interrupts for all slots. It includes enabling of SDIO interrupts through dw_mci_enable_sdio_irq and the handling of the slot specific interrupts in the Interrupt Service Routine. Signed-off-by: shashidhar Hiremath

[PATCH 1/1] mmc: Support of SDIO irq for dw_mmc

2011-08-23 Thread Shashidhar Hiremath
The Patch adds the support for SDIO interrupts for all slots. It includes enabling of SDIO interrupts through dw_mci_enable_sdio_irq and the handling of the slot specific interrupts in the Interrupt Service Routine. Signed-off-by: shashidhar Hiremath --- drivers/mmc/host/dw_mmc.c | 37