[PATCH v3 2/2] ARM: mmp2: support sdio with regulator vsdio

2011-08-24 Thread Zhangfei Gao
Add regulator vsdio, which controled by mmc core to handle sdio chip power Test With CONFIG_PM_RUNTIME=y 8787 power is enabled if any client module over sdio is insmod, and disbled automatically after all client modules over sdio are rmmod Also 8787 power could be controled by mmc_start/stop_host

[PATCH v3 1/2] mmc: sdio add regulator vsdio

2011-08-24 Thread Zhangfei Gao
sdio client may be required power on/off dynamically. With regulator vsdio, sdio client power on/off could be executed by mmc_power_up/down CC: Ohad Ben-Cohen Signed-off-by: Zhangfei Gao --- drivers/mmc/host/sdhci.c | 22 ++ include/linux/mmc/sdhci.h |2 ++ 2 files c

[PATCH v3 0/2] mmc add vsdio to dynamically control sdio power

2011-08-24 Thread Zhangfei Gao
v2->v3, change vmmc to vsdio In v2, vmmc is reused, however, sd may be impacted if move vmmc to set_ios. When no card inserted, CD is high, vmmc will be disabled when detect fail, CD will pull low accordingly, controller may treat as card inserted and re-detect. Zhangfei Gao (2): mmc: sdio add

RFC : mmc : Use wait_for_completion_timeout() instead of wait_for_completion in case of multiple write blocks.

2011-08-24 Thread NamJae Jeon
Hi. If card is infinitely holding pull down busy line(data 0) while writing multiple blocks, write will be blocked in mmc_wait_for_req_done(). I suggest to use wait_for_completion_timeout instread of wait_for_completion like the below code. How do you think about my suggestion ? Thanks. ---

[PATCH v8 3/4] mmc: sdhi: Allow name IRQs to use specific handlers

2011-08-24 Thread Simon Horman
Allow named IRQs to use corresponding specific handlers. Allow one or more such IRQ source; Or allow one or more multiplexed (un-named) IRQ source. Cc: Guennadi Liakhovetski Acked-by: Magnus Damm Signed-off-by: Simon Horman --- v8 * As pointed out by Guennadi Liakhovetski via Magnus Damm -

[PATCH v8 4/4] ARM: shmobile: ag5evm, ap4: Named SDHI IRQ sources

2011-08-24 Thread Simon Horman
This allows specific (non-multiplexed) IRQ handlers to be used. Cc: Guennadi Liakhovetski Cc: Paul Mundt Acked-by: Magnus Damm Signed-off-by: Simon Horman --- Requires "mmc: sdhi: Allow specific IRQ sources to use corresponding handlers." v7 * Rework to use named IRQs v4 * Update for corre

[PATCH v8 2/4] mmc: tmio: Provide separate interrupt handlers

2011-08-24 Thread Simon Horman
Provide separate interrupt handlers which may be used by platforms where SDHI has three interrupt sources. This patch also removes the commented-out handling of CRC and other errors. Cc: Guennadi Liakhovetski Acked-by: Magnus Damm Signed-off-by: Simon Horman --- * SDCARD portion tested on AP

[PATCH v8 1/4] mmc: tmio: Cache interrupt masks

2011-08-24 Thread Simon Horman
This avoids the need to look up the masks each time an interrupt is handled. As suggested by Guennadi. Cc: Guennadi Liakhovetski Acked-by: Magnus Damm Signed-off-by: Simon Horman --- * SDCARD portion tested on AP4/Mackerel * SDIO portion untested v3 * As suggested by Guennadi Liakhovetski

[PATCH 0/4 v8] mmc: tmio, sdhi: provide multiple irq handlers

2011-08-24 Thread Simon Horman
The SDHI driver already supports making use of up to three interrupt sources. This series breaks up the existing interrupt handler into three handlers, one for sdcard access, one for card detect and one for SDIO interrupts. A cover-all handler, which makes use of these new broken-out handlers is p

Re: [PATCH 1/1] Add support for JMicron chip with UHS-I function

2011-08-24 Thread Chris Ball
Hi Arindam, Subhash, Wolfram, Any suggestions on the abstraction for Aries' patch below, and how we should organize large additions to the JMicron-specific code in sdhci.c? I'm not sure what to recommend to Aries. Thanks! - Chris. On Mon, Aug 08 2011, arieslee wrote: > 1. Force to assign some p

[PATCHv2 2/2] mmc: fix integer assignments to pointer

2011-08-24 Thread Venkatraman S
Fix the sparse warning output "warning: Using plain integer as NULL pointer" Signed-off-by: Venkatraman S --- Update since v1: Rebased on top of today's mmc-next and fixed more instances of the same warning drivers/mmc/card/block.c|4 ++-- drivers/mmc/core/core.c |2 +-

Re: [PATCH 2/2] mmc: fix integer assignments to pointer

2011-08-24 Thread S, Venkatraman
On Wed, Aug 24, 2011 at 2:08 AM, Sam Ravnborg wrote: >> >> I'm still a little confused -- the {0} or memset(0, struct ..); >> formations are used often in the kernel, even with pointers involved. >> Is the warning (Wnon_pointer_null) run against the kernel by default, >> or did Venkatraman add it

Re: RFC : mmc: mmc_blk_issue_secdiscard_rq() and mmc_blk_issue_discard_rq() effectively merged into one.

2011-08-24 Thread NamJae Jeon
Hi. Park. I understand. Thanks for your reply. 2011/8/24 Kyungmin Park : > Hi, > > On Wed, Aug 24, 2011 at 2:09 PM, NamJae Jeon wrote: >> Hi. >> >> I am wordering why mmc_blk_issue_secdiscard_rq() and >> mmc_blk_issue_discard_rq() is seperated. >> So I try to make mmc_blk_issue_secdiscard_rq() a

Re: [PATCH 1/2] mmc: sdhci move vmmc to set_ios

2011-08-24 Thread zhangfei gao
On Tue, Jul 26, 2011 at 3:06 PM, Zhangfei Gao wrote: > Move vmmc to set_ios, as a result mmc_power_up/down handles > regulator_enable/disable vmmc > Move regulator outof spin_lock, since usually i2c operation is called > Remove vmmc from suspend/resume function, instead vmmc is handled properly i

Re: [PATCH 2/2] mmc: fix integer assignments to pointer

2011-08-24 Thread S, Venkatraman
On Wed, Aug 24, 2011 at 4:10 AM, J Freyensee wrote: > On 08/23/2011 09:56 AM, Sam Ravnborg wrote: >> >> On Tue, Aug 23, 2011 at 12:31:55PM -0400, Chris Ball wrote: >>> >>> Hi, >>> >>> [Adding linux-sparse@ to CC] >>> >>> On Tue, Aug 23 2011, Venkatraman S wrote: Fix the sparse warning ou

Re: [RFC 0/4] sdhci: few patches for ENE 712 support

2011-08-24 Thread Kalle Valo
Hi Wolfram, going back to an old thread from March: https://lkml.org/lkml/2011/3/18/433 Background: Luis had problems with ath6kl (driver for ar6003 wifi chip using sdio) and PCI ENE 712 SDIO extender and he had to use few ugly patches to get it working. Later this year I inherited all this. I

Re: [PATCH 0/4 v7] mmc: tmio, sdhi: provide multiple irq handlers

2011-08-24 Thread Magnus Damm
On Wed, Aug 24, 2011 at 2:37 PM, Simon Horman wrote: > On Fri, Aug 19, 2011 at 04:57:18PM +0900, Simon Horman wrote: >> The SDHI driver already supports making use of up to three interrupt >> sources. >> >> This series breaks up the existing interrupt handler into three handlers, >> one for card a

Re: [PATCH v2 1/1] mmc: Support of SDIO irq for dw_mmc

2011-08-24 Thread James Hogan
On 24 August 2011 09:18, Shashidhar Hiremath wrote: > Hi James, >    If I understand your concern correctly, for level triggered > interrupts,the interrupt action needs to taken first,than the > interrupt source needs to be cleared,only then I can clear Raw > Interrupt Status register right ? > >

Re: [PATCH v2 1/1] mmc: Support of SDIO irq for dw_mmc

2011-08-24 Thread Shashidhar Hiremath
Hi James, If I understand your concern correctly, for level triggered interrupts,the interrupt action needs to taken first,than the interrupt source needs to be cleared,only then I can clear Raw Interrupt Status register right ? So ,accordingly ,will the below code be in appropriate order ?