Re: [PATCH] mmc: add a short delay in mmc_power_off

2011-09-16 Thread Daniel Drake
On Fri, Sep 16, 2011 at 5:47 PM, Ohad Ben-Cohen wrote: > Maybe. I was wondering why nobody cared so far about putting delays at > the power down path then, but I guess no one was really powering down > their controllers ? I know Marvell did, using some out-of-tree code, > but IIUC Marvell utilizes

Re: [PATCH] mmc: add a short delay in mmc_power_off

2011-09-16 Thread Ohad Ben-Cohen
On Fri, Sep 16, 2011 at 6:33 PM, Daniel Drake wrote: > Do you know the source of that info? No, not more than what the comments say. It also seems that the first delay was originally 1ms and at some point it was increased to 2ms (commit f9996aee36921e8f1d499de1b2ea380855cf6d97 "mmc: increase pow

Re: [PATCH v3 1/2] mmc: sdio add regulator vsdio

2011-09-16 Thread Daniel Drake
On Thu, Sep 1, 2011 at 2:37 AM, zhangfei gao wrote: > Daniel once suggested reusing vmmc, however we found CD pin requires > vmmc to be alwayes on. > If vmmc is dynamically power off, CD pin will be low, which indicating > card is inserted by mistake. > For example when no card inserted, CD pin wi

Re: [PATCH] mmc: add a short delay in mmc_power_off

2011-09-16 Thread Daniel Drake
On Wed, Sep 7, 2011 at 8:12 PM, Ohad Ben-Cohen wrote: > I wouldn't call them random - they're pretty much explained. Do you know the source of that info? It probably also justifies what we need here. If short delays are needed when messing with power in the powerup path (i.e. "we just touched po

[PATCH] mmc: core: HS200 mode support for eMMC 4.5

2011-09-16 Thread Girish K S
This patch adds the support of the HS200 bus speed for eMMC 4.5 devices. The eMMC 4.5 devices have support for 200MHz bus speed. The mmc core and host modules have been touched to add support for this module. It is necessary to know the card type in the sdhci.c file to add support for eMMC tuning f

[PATCH V2 RESEND] mmc: core: eMMC 4.5 Power Class Selection Feature

2011-09-16 Thread Girish K S
This patch adds the power class selection feature available for mmc versions 4.0 and above. During the enumeration stage before switching to the lower data bus, check if the power class is supported for the current bus width. If the power class is available then switch to the power class and use th

[PATCH V2 RESEND] Power Class Selection Feature

2011-09-16 Thread Girish K S
This patch version removes some checkpatch error. Earlier versions were checked with the older checkpatch.pl which didnt give any checkpatch errors. This patch uses the checkpatch.pl in the latest script folder. Girish K S (1): mmc: core: eMMC 4.5 Power Class Selection Feature drivers/mmc/core

[PATCH V6 RESEND 1/2] mmc: core: Add power off notify feature(eMMC 4.5)

2011-09-16 Thread Girish K S
This patch adds the support for power off notify feature available in eMMC 4.5 devices. If the the host has support for this feature, then the mmc core will notify it to the device by setting the POWER_OFF_NOTIFICATION byte in the extended csd register with a value 1(POWER_ON). This

[PATCH V6 RESEND 2/2] mmc: core: Add Poweroff Notify handling eMMC 4.5

2011-09-16 Thread Girish K S
This patch adds the power off notification handling during suspend and system poweroff. For suspend mode short timeout is used, whereas for the normal poweroff long timeout is used. Signed-off-by: Girish K S --- drivers/mmc/core/core.c | 34 ++ drivers/mmc/core

[PATCH V6 RESEND 0/2] Poweroff Notify eMMC 4.5

2011-09-16 Thread Girish K S
This patch version removes some checkpatch error. Earlier versions were checked with the older checkpatch.pl which didnt give any checkpatch errors. This patch uses the checkpatch.pl in the latest script folder. Girish K S (2): mmc: core: Add power off notify feature(eMMC 4.5) mmc: core: Add P

[PATCH V1] mmc: core: eMMC 4.5 Power Class Selection Feature

2011-09-16 Thread Girish K S
This patch adds the power class selection feature available for mmc versions 4.0 and above. During the enumeration stage before switching to the lower data bus, check if the power class is supported for the current bus width. If the power class is available then switch to the power class and use th

[PATCH V1] mmc: core: eMMC 4.5 Power Class Selection Feature

2011-09-16 Thread Girish K S
This patch adds the power class selection feature available for mmc versions 4.0 and above. During the enumeration stage before switching to the lower data bus, check if the power class is supported for the current bus width. If the power class is available then switch to the power class and use th

[PATCH V2] Power Class Selection Feature

2011-09-16 Thread Girish K S
This patch version removes some checkpatch error. Earlier versions were checked with the older checkpatch.pl which didnt give any checkpatch errors. This patch uses the checkpatch.pl in the latest script folder. Girish K S (1): mmc: core: eMMC 4.5 Power Class Selection Feature drivers/mmc/core

[PATCH V5 2/2] mmc: core: Add Poweroff Notify handling eMMC 4.5

2011-09-16 Thread Girish K S
This patch adds the power off notification handling during suspend and system poweroff. For suspend mode short timeout is used, whereas for the normal poweroff long timeout is used. Signed-off-by: Girish K S --- drivers/mmc/core/core.c | 34 ++ drivers/mmc/core

[PATCH V5 1/2] mmc: core: Add power off notify feature(eMMC 4.5)

2011-09-16 Thread Girish K S
This patch adds the support for power off notify feature available in eMMC 4.5 devices. If the the host has support for this feature, then the mmc core will notify it to the device by setting the POWER_OFF_NOTIFICATION byte in the extended csd register with a value 1(POWER_ON). This

[PATCH V6 0/2] Poweroff Notify eMMC 4.5

2011-09-16 Thread Girish K S
This patch version removes some checkpatch error. Earlier versions were checked with the older checkpatch.pl which didnt give any checkpatch errors. This patch uses the checkpatch.pl in the latest script folder. Girish K S (2): mmc: core: Add power off notify feature(eMMC 4.5) mmc: core: Add P

Re: [PATCH] mmc: core: Set correct bus mode before card init

2011-09-16 Thread Stefan Nilsson XK
Hi Aaron, On 09/16/2011 04:05 AM, Aaron Lu wrote: Hi Ulf, I'm not familiar with mmc, but I've some questions on sd below. On Thu, Sep 15, 2011 at 05:50:38PM +0200, Ulf Hansson wrote: Earlier all cards where initiated with bus mode set as OPENDRAIN, and then later switched to PUSHPULL. Accordi