Re: [PATCH 1/6] ESDHC: add PIO mode support

2011-12-13 Thread Wolfram Sang
On Wed, Dec 14, 2011 at 10:19:37AM +0800, r66...@freescale.com wrote: > From: Jerry Huang > > For some FSL ESDHC controller(e.g. P2020E, Rev1.0), the SDHC can not work on > DMA mode because of the hardware bug, so we set a broken dma flag and use > PIO mode. > > Signed-off-by: Gao Guanhua > Sig

[RESEND PATCH] mmc: core: Add host capability check for power class

2011-12-13 Thread Girish K S
This patch adds a check whether the host supports maximum current value obtained from the device's extended csd register for a selected interface voltage and frequency. cc: Chris Ball Signed-off-by: Girish K S --- drivers/mmc/core/mmc.c | 27 +++ include/linux/mmc/ca

[PATCH] mmc: core: Add host capability check for power class

2011-12-13 Thread Girish K S
This patch adds a check whether the host supports maximum current value obtained from the device's extended csd register for a selected interface voltage and frequency. Signed-off-by: Girish K S --- drivers/mmc/core/mmc.c | 27 +++ include/linux/mmc/card.h |4

Re: [PATCH V6] mmc: core: Add host capability check for power class

2011-12-13 Thread Girish K S
Ignore this patch On 14 December 2011 11:44, Girish K S wrote: > This patch adds a check whether the host supports maximum current value > obtained from the device's extended csd register for a selected interface > voltage and frequency. > > cc: Chris Ball > Signed-off-by: Girish K S > --- > Ch

Re: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the card

2011-12-13 Thread Philip Rakity
On Dec 13, 2011, at 6:18 PM, wrote: > From: Jerry Huang > > Add callback function sdhci_get_cd to detect the card. > And one new callback added to implement the card detect in sdhci struncture. > If special platform has the card detect callback, it will return the card > state, the value zero

RE: [PATCH] mmc: sdhci-s3c: use dev_pm_ops

2011-12-13 Thread Jingoo Han
I have just checked mmc-next branch. Please, don't submit this patch. Thank you. > -Original Message- > Subject: [PATCH] mmc: sdhci-s3c: use dev_pm_ops > > Instead of using legacy suspend/resume methods, using newer dev_pm_ops > structure allows better control over power management. > >

RE: Cache Control during mmc_suspend_host

2011-12-13 Thread Seungwon Jeon
Saugata Das wrote: > On 13 December 2011 11:57, Seungwon Jeon wrote: > > Hi Saugata, > > > > Saugata Das wrote: > >> Hi Seungwon Jeon > >> > >> I see a small issue with the implementation mmc_suspend_host, > >> > >> int mmc_suspend_host(struct mmc_host *host) > >> { > >> . > >>       err = mmc

[PATCH] mmc: sdhci-s3c: use dev_pm_ops

2011-12-13 Thread Jingoo Han
Instead of using legacy suspend/resume methods, using newer dev_pm_ops structure allows better control over power management. Signed-off-by: Jingoo Han --- drivers/mmc/host/sdhci-s3c.c | 19 +-- 1 files changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/mmc/host/sd

[PATCH] mmc: sdhci-s3c: use S3C_SDHCI_CONTROL2 instead of hardcoded offeset value

2011-12-13 Thread Jingoo Han
Signed-off-by: Jingoo Han --- drivers/mmc/host/sdhci-s3c.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c index cb60c41..62ff6b4 100644 --- a/drivers/mmc/host/sdhci-s3c.c +++ b/drivers/mmc/host/sdhci-s3c.c @@ -

[PATCH] mmc: sdhci-s3c: fix checkpatch error and warning

2011-12-13 Thread Jingoo Han
This patch fixes the checkpatch error and warning listed below: ERROR: return is not a function, parentheses are not required WARNING: line over 80 characters Signed-off-by: Jingoo Han --- drivers/mmc/host/sdhci-s3c.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/

RE: [PATCH] mmc: sdhci-pltfm: Added sdhci-adjust-timeout quirk

2011-12-13 Thread Xie Xiaobo-R63061
Hi Changming, OK, you can merge my patch into your patches. Hi all, Please ignore this patch. Changming will send the similar patch. BRs Xie Xiaobo -Original Message- From: Huang Changming-R66093 Sent: 2011年12月13日 16:00 To: Xie Xiaobo-R63061; linuxppc-...@lists.ozlabs.org Cc: avoront..

[PATCH 4/6] ESDHC: Power management for ESDHC

2011-12-13 Thread r66093
From: Jerry Huang For FSL ESDHC controllor, when enter the sleep, the controller will power off, therefore the register will lost its valuse, and driver should save value of register during suspend and used during resume. Signed-off-by: Jerry Huang Signed-off-by: Jiang Yutang --- drivers/mmc/

[PATCH 2/6] SDHCI: AHB2MAG IRQ bypass hardware workaround

2011-12-13 Thread r66093
From: Jerry Huang For Fsl eSDHC controller, the bit DCR[DMA__AHB2MAG_IRQ_BYPASS] cannot be set automatically, when SoC reset, therefore, we need to set this bit manually. Signed-off-by: Gao Guanhua Signed-off-by: Jerry Huang --- drivers/mmc/host/sdhci-esdhc.h|1 + drivers/mmc/host/sdh

[PATCH 6/6] ESDHC: Fix DMA errors in kernel booting on P1010

2011-12-13 Thread r66093
From: Jerry Huang When linux is booted with DMA mode enabled in esdhc module on P1010, there were following errors: mmc0: ADMA error mmc0: error -5 whilst initialising SD card It is because FSL ESDHC controller has different bit setting for PROCTL register, when kernel sets Power Control Regist

[PATCH 5/6] ESDHC: Workaround for data crc error on p1010rdb

2011-12-13 Thread r66093
From: Jerry Huang SD card read was failing (data crc error)on some cards at maximum possible frequency on P1010(CCB frequency set to 400MHz). Some clock deviations are also observed at this frequency. Hence reduced the mmc clock freq. Signed-off-by: Priyanka Jain Singed-off-by: Jerry Huang ---

[PATCH 3/6] ESDHC: set the timeout to the max value

2011-12-13 Thread r66093
From: Jerry Huang When access the card on some FSL platform board (e.g p2020, p1010, mpc8536), the following error is reported with the timeout value calculated: mmc0: Got data interrupt 0x0020 even though no data operation was in progress. mmc0: Got data interrupt 0x0020 even though no

[PATCH 1/6] ESDHC: add PIO mode support

2011-12-13 Thread r66093
From: Jerry Huang For some FSL ESDHC controller(e.g. P2020E, Rev1.0), the SDHC can not work on DMA mode because of the hardware bug, so we set a broken dma flag and use PIO mode. Signed-off-by: Gao Guanhua Signed-off-by: Jerry Huang --- drivers/mmc/host/sdhci-pltfm.c |5 - 1 files cha

[PATCH 0/6] workaround for FSL's eSDHC controller

2011-12-13 Thread r66093
From: Jerry Huang The below patches are the workaround for FSL's eSDHC controller. Signed-off-by: Jerry Huang -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-i

[PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the card

2011-12-13 Thread r66093
From: Jerry Huang Add callback function sdhci_get_cd to detect the card. And one new callback added to implement the card detect in sdhci struncture. If special platform has the card detect callback, it will return the card state, the value zero is for absent cardi and one is for present card. If

RE: [PATCH 1/4] SDHCI: add sdhci_get_cd callback to detect the card

2011-12-13 Thread Huang Changming-R66093
> -Original Message- > From: Chris Ball [mailto:c...@laptop.org] > Sent: Wednesday, December 14, 2011 2:06 AM > To: Philip Rakity > Cc: Huang Changming-R66093; linux-mmc@vger.kernel.org; Huang Changming- > R66093 > Subject: Re: [PATCH 1/4] SDHCI: add sdhci_get_cd callback to detect the >

RE: [PATCH 2/4] MMC/SD: Add callback function to detect card

2011-12-13 Thread Huang Changming-R66093
> > You patch uses (SDHCI_CARD_PRESENT | SDHCI_CARD_CDPL) Does that > mean SDHCI_CARD_CDPL does work in that case? > >>> No. > >>> The SDHCI_CARD_CDPL[bit13] reflect the pin level: > >>> CDPL: Card detect pin level. This bit reflects the inverse value of > >>> the > >> SDHC_CD pin fo

Re: [PATCH 3/4] mtd: fix compile error for gpmi-nand

2011-12-13 Thread Huang Shijie
于 2011年12月13日 23:48, Shawn Guo 写道: > From: Huang Shijie > > The driver gpmi-nand should compile at least. This patch adds the > missing gpmi-nand.h to fix the compile error below. > > CC drivers/mtd/nand/gpmi-nand/gpmi-nand.o > CC drivers/mtd/nand/gpmi-nand/gpmi-lib.o > drivers/mtd/

Re: [PATCH 4/4] mtd: gpmi-nand: move to dma_transfer_direction

2011-12-13 Thread Huang Shijie
于 2011年12月13日 23:48, Shawn Guo 写道: > This patch fixes usage of dma direction to adopt dma_transfer_direction. > > Signed-off-by: Shawn Guo > --- > drivers/mtd/nand/gpmi-nand/gpmi-lib.c | 22 -- > 1 files changed, 12 insertions(+), 10 deletions(-) > > diff --git a/drivers/mtd

Re: [PATCH/RFC] mmc: add a device PM QoS constraint when a host is first claimed

2011-12-13 Thread Rafael J. Wysocki
On Tuesday, December 13, 2011, Guennadi Liakhovetski wrote: > Hi Ulf > > On Tue, 13 Dec 2011, Ulf Hansson wrote: > > > Guennadi Liakhovetski wrote: > > > Some MMC hosts implement a fine-grained runtime PM, whereby they > > > runtime-suspend and -resume the host interface on each transfer. This ca

Re: [PATCH 1/4] SDHCI: add sdhci_get_cd callback to detect the card

2011-12-13 Thread Chris Ball
Hi, On Mon, Dec 05 2011, Philip Rakity wrote: >> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c >> index 6d8eea3..66afd82 100644 >> --- a/drivers/mmc/host/sdhci.c >> +++ b/drivers/mmc/host/sdhci.c >> @@ -2,6 +2,7 @@ >> * linux/drivers/mmc/host/sdhci.c - Secure Digital Host Contr

Re: [PATCH 1/1] mmc: sdhci-esdhc: Change delay after setting clock from 100ms to 1ms

2011-12-13 Thread Chris Ball
Hi, On Fri, Dec 02 2011, Huang Changming-R66093 wrote: > I don't think it make sense to change the delay time. > Which will affect all PowerPC eSDHC controller, could you confirm > which can work on all PowerPC platform? No, of course not, but that's why I said we can put the patch in mmc-next an

Re: [PATCH] mmc: mmci: Fixup handling of MCI_STARTBITERR

2011-12-13 Thread Chris Ball
Hi, On Fri, Nov 11 2011, Linus Walleij wrote: >> The interrupt was previously enabled and then correctly cleared. >> Now we also handle it correctly. >> >> Signed-off-by: Ulf Hansson > > Acked-by: Linus Walleij > > This should also go to -stable I think? Just to check: should I be leaving MMCI

Re: [PATCH] mmc: debugfs: parse all ext_csd via debug_fs

2011-12-13 Thread Chris Ball
Hi Peppe, On Tue, Dec 06 2011, Giuseppe CAVALLARO wrote: >> I'm all for this patch so it gets visible in debugfs atleast, >> since people seem to need to know these things, so take that as an >> Acked-by: Linus Walleij >> >> Those who want to writ userspace tools can proceed to >> implement the

Re: [PATCH 0/5] mmc: mmci: Improvements and bugfixes for SDIO

2011-12-13 Thread Ulf Hansson
Hi Russell, I would just like to inform you that I just uploaded these patches into your patchtracker tool. I will ask Linus to help out testing this on RealView PB1176 board as well, since I unfortunately don't own such a board myself. These patches is also based on Linux 3.2-rc4 and on top

Re: [PATCH 00/14] mmc: mmci: Improved PM support, cleanup and bugfixes

2011-12-13 Thread Ulf Hansson
Linus Walleij wrote: I applied all 14 patches on top of current v3.2-rc4 and regression-tested the whole shebang on RealView PB1176 and U300. - Mounted /dev/mmcblk0p1 - Copy a kernel-sized uImage file from the card to ramdisk - Copy the file back to the card from ramdisk - Unmount - Mount - Com

Re: [PATCH/RFC] mmc: add a device PM QoS constraint when a host is first claimed

2011-12-13 Thread Guennadi Liakhovetski
Hi Ulf On Tue, 13 Dec 2011, Ulf Hansson wrote: > Guennadi Liakhovetski wrote: > > Some MMC hosts implement a fine-grained runtime PM, whereby they > > runtime-suspend and -resume the host interface on each transfer. This can > > negatively affect performance, if the user was trying to transfer da

[PATCH 4/4] mtd: gpmi-nand: move to dma_transfer_direction

2011-12-13 Thread Shawn Guo
This patch fixes usage of dma direction to adopt dma_transfer_direction. Signed-off-by: Shawn Guo --- drivers/mtd/nand/gpmi-nand/gpmi-lib.c | 22 -- 1 files changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-lib.c b/drivers/mtd/nand/gp

[PATCH 2/4] mmc: mxs-mmc: fix the dma_transfer_direction migration

2011-12-13 Thread Shawn Guo
The commit 05f5799 (mmc-host: move to dma_transfer_direction) left out the DMA_NONE, in turn breaks the driver as below. [0.65] mxs-mmc mxs-mmc.0: initialized [0.65] mxs-mmc mxs-mmc.1: initialized [0.69] mxs-dma mxs-dma-apbh: maximum bytes for sg entry exceeded: -55906 7475

[PATCH 3/4] mtd: fix compile error for gpmi-nand

2011-12-13 Thread Shawn Guo
From: Huang Shijie The driver gpmi-nand should compile at least. This patch adds the missing gpmi-nand.h to fix the compile error below. CC drivers/mtd/nand/gpmi-nand/gpmi-nand.o CC drivers/mtd/nand/gpmi-nand/gpmi-lib.o drivers/mtd/nand/gpmi-nand/gpmi-nand.c:25:33: fatal error: l

[PATCH 1/4] dmaengine: add DMA_TRANS_NONE to dma_transfer_direction

2011-12-13 Thread Shawn Guo
Before dma_transfer_direction was introduced to replace dma_data_direction, some dmaengine device uses DMA_NONE of dma_data_direction for some talk with its client drivers. The mxs-dma and its clients mxs-mmc and gpmi-nand are such case. This patch adds DMA_TRANS_NONE to dma_transfer_direction and

[PATCH 0/4] Fix the left DMA_NONE from dma_transfer_direction migration

2011-12-13 Thread Shawn Guo
I have been working on -rc recently, and have not noticed the failure until I ran next tree today. The mxs-mmc driver is broken on next tree because the DMA_NONE was left over from the dma_transfer_direction migration for mxs-dma and its client drivers. This seires is trying to fix it up. Huang

Re: [PATCH/RFC] mmc: add a device PM QoS constraint when a host is first claimed

2011-12-13 Thread Ulf Hansson
Guennadi Liakhovetski wrote: Some MMC hosts implement a fine-grained runtime PM, whereby they runtime-suspend and -resume the host interface on each transfer. This can negatively affect performance, if the user was trying to transfer data blocks back-to-back. This patch adds a PM QoS constraint t

Re: Cache Control during mmc_suspend_host

2011-12-13 Thread Saugata Das
On 13 December 2011 11:57, Seungwon Jeon wrote: > Hi Saugata, > > Saugata Das wrote: >> Hi Seungwon Jeon >> >> I see a small issue with the implementation mmc_suspend_host, >> >> int mmc_suspend_host(struct mmc_host *host) >> { >> . >>       err = mmc_cache_ctrl(host, 0); >> } >> >> So, within

Re: [PATCH 2/4] MMC/SD: Add callback function to detect card

2011-12-13 Thread Adrian Hunter
On 13/12/11 11:55, Huang Changming-R66093 wrote: > > >> -Original Message- >> From: Adrian Hunter [mailto:adrian.hun...@intel.com] >> Sent: Tuesday, December 13, 2011 4:54 PM >> To: Huang Changming-R66093 >> Cc: linux-mmc@vger.kernel.org >> Subject: Re: [PATCH 2/4] MMC/SD: Add callback fu

RE: [PATCH 2/4] MMC/SD: Add callback function to detect card

2011-12-13 Thread Huang Changming-R66093
> -Original Message- > From: Adrian Hunter [mailto:adrian.hun...@intel.com] > Sent: Tuesday, December 13, 2011 4:54 PM > To: Huang Changming-R66093 > Cc: linux-mmc@vger.kernel.org > Subject: Re: [PATCH 2/4] MMC/SD: Add callback function to detect card > > On 13/12/11 10:26, Huang Changmi

Re: [PATCH 2/4] MMC/SD: Add callback function to detect card

2011-12-13 Thread Adrian Hunter
On 13/12/11 10:26, Huang Changming-R66093 wrote: > > >> -Original Message- >> From: Adrian Hunter [mailto:adrian.hun...@intel.com] >> Sent: Tuesday, December 13, 2011 4:01 PM >> To: Huang Changming-R66093 >> Cc: linux-mmc@vger.kernel.org >> Subject: Re: [PATCH 2/4] MMC/SD: Add callback fu

RE: [PATCH 2/4] MMC/SD: Add callback function to detect card

2011-12-13 Thread Huang Changming-R66093
> -Original Message- > From: Adrian Hunter [mailto:adrian.hun...@intel.com] > Sent: Tuesday, December 13, 2011 4:01 PM > To: Huang Changming-R66093 > Cc: linux-mmc@vger.kernel.org > Subject: Re: [PATCH 2/4] MMC/SD: Add callback function to detect card > > On 13/12/11 09:25, Huang Changmi

Re: [PATCH 2/4] MMC/SD: Add callback function to detect card

2011-12-13 Thread Adrian Hunter
On 13/12/11 09:25, Huang Changming-R66093 wrote: > > >> -Original Message- >> From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- >> ow...@vger.kernel.org] On Behalf Of Adrian Hunter >> Sent: Friday, December 09, 2011 6:03 PM >> To: Huang Changming-R66093 >> Cc: linux-mmc@vger.kernel

RE: [PATCH] mmc: sdhci-pltfm: Added sdhci-adjust-timeout quirk

2011-12-13 Thread Huang Changming-R66093
Xiaobo, I have one other similar patch, but the property is 'sdhci,adjust-timeout'. Maybe I can repost it with add your signed-off-by? > -Original Message- > From: linuxppc-dev-bounces+r66093=freescale@lists.ozlabs.org > [mailto:linuxppc-dev-bounces+r66093=freescale@lists.ozlabs.o