Re: [PATCH V6 2/2] mmc: host: Adds support for eMMC 4.5 HS200 mode

2011-12-19 Thread Girish K S
On 19 December 2011 22:24, Philip Rakity wrote: > > HI, > > minor comments below. > > Philip > > On Dec 18, 2011, at 10:36 PM, Girish K S wrote: > >> This patch adds support for the HS200 mode on the host side. >> Also enables the tuning feature required when the HS200 mode >> is selected. >> >> c

Re: [PATCH V3 10/14] ARM: mxs: add clk_prepare/clk_unprepare

2011-12-19 Thread Shawn Guo
Hi Sascha, Can you drop this patch from your tree? This patch is not complete even for mxs platform/arch code, and will conflict with my mxs clk-prepare series. -- Regards, Shawn On Fri, Nov 11, 2011 at 06:50:33PM +0800, Richard Zhao wrote: > Signed-off-by: Richard Zhao > --- > arch/arm/mach

Re: [PATCH V3 10/14] ARM: mxs: add clk_prepare/clk_unprepare

2011-12-19 Thread Richard Zhao
On Mon, Dec 19, 2011 at 11:21:41PM +0100, Marek Vasut wrote: > > Signed-off-by: Richard Zhao > > --- > > arch/arm/mach-mxs/system.c |2 +- > > arch/arm/mach-mxs/timer.c |2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm/mach-mxs/system.c b/arch/arm

Re: [PATCH 4/15] vub300: fix module parameter.

2011-12-19 Thread Chris Ball
Hi Rusty, On Sun, Dec 18 2011, Rusty Russell wrote: > On Fri, 16 Dec 2011 19:02:02 +, Tony Olech > wrote: >> You are right. >> I don't know how that slipped through >> Tony Olech > > I'm assuming that means you're taking this? Otherwise, please give me > an acked-by. Thanks, I'll send this

Re: PCI suspend warnings in 3.2-rc6

2011-12-19 Thread Chris Ball
Hi, On Sun, Dec 18 2011, Rafael J. Wysocki wrote: > On Sunday, December 18, 2011, Udo Steinberg wrote: >> When suspending to RAM, I'm getting a bunch of warnings from the PCI layer >> in Linux-3.2-rc6, which I didn't get with Linux-3.1. Please let me know if >> I should provide more information ab

[PATCH] mmc: Set suspend/resume bus operations if CONFIG_PM_RUNTIME is used

2011-12-19 Thread Dmitry Shmidt
Signed-off-by: Dmitry Shmidt --- drivers/mmc/core/bus.c | 24 +++- 1 files changed, 7 insertions(+), 17 deletions(-) diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c index 393d817..e07d6c9 100644 --- a/drivers/mmc/core/bus.c +++ b/drivers/mmc/core/bus.c @@ -120,

Re: [PATCH V3 10/14] ARM: mxs: add clk_prepare/clk_unprepare

2011-12-19 Thread Marek Vasut
> Signed-off-by: Richard Zhao > --- > arch/arm/mach-mxs/system.c |2 +- > arch/arm/mach-mxs/timer.c |2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-mxs/system.c b/arch/arm/mach-mxs/system.c > index 20ec3bd..9760a12 100644 > --- a/arch/arm/mach-mx

Re: [GIT PULL] ARM: amba: Enable module alias autogeneration for AMBA drivers

2011-12-19 Thread Russell King - ARM Linux
On Mon, Dec 19, 2011 at 01:24:09PM +, Dave Martin wrote: > Hi Russell, > > This one isn't urgent, but I'm not seeing the amba modalias patches > anywhere yet. Did you have any outstanding concerns which need to be > resolved? > > If you can suggest when/if these are likely to merge that woul

Re: [PATCH] mmc: core: Fix voltage select in DDR mode

2011-12-19 Thread Philip Rakity
On Dec 15, 2011, at 9:06 AM, Subhash Jadavani wrote: > > >> -Original Message- >> From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- >> ow...@vger.kernel.org] On Behalf Of Girish K S >> Sent: Thursday, December 15, 2011 5:28 PM >> To: linux-mmc@vger.kernel.org >> Cc: patc...@linar

Re: [PATCH V6 1/2] mmc: core: HS200 mode support for eMMC 4.5

2011-12-19 Thread Philip Rakity
On Dec 18, 2011, at 10:36 PM, Girish K S wrote: > This patch adds the support of the HS200 bus speed for eMMC 4.5 devices. > The eMMC 4.5 devices have support for 200MHz bus speed. The function > prototype of the tuning function is modified to handle the tuning command > number which is different

Re: [PATCH V6 2/2] mmc: host: Adds support for eMMC 4.5 HS200 mode

2011-12-19 Thread Philip Rakity
HI, minor comments below. Philip On Dec 18, 2011, at 10:36 PM, Girish K S wrote: > This patch adds support for the HS200 mode on the host side. > Also enables the tuning feature required when the HS200 mode > is selected. > > cc: Chris Ball > Signed-off-by: Girish K S > --- > drivers/mmc/ho

[PATCH V3] mmc: core: Add option to prevent eMMC sleep command

2011-12-19 Thread Ulf Hansson
Host may now use MMC_CAP2_NO_SLEEP_CMD to disable the use of eMMC sleep/awake command. This option can be used when you platform have a buggy kernel crash dump software, which is supposed to store the dump on the eMMC, but is not able to wake up the eMMC from sleep state. Signed-off-by: Ulf Hanss

RE: [PATCH V2] mmc: core: Add option to prevent eMMC sleep command

2011-12-19 Thread Subhash Jadavani
> -Original Message- > From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- > ow...@vger.kernel.org] On Behalf Of Ulf Hansson > Sent: Monday, December 19, 2011 5:28 PM > To: Subhash Jadavani > Cc: linux-mmc@vger.kernel.org; 'Chris Ball'; Per FORLIN; Johan RUDHOLM; > 'Lee Jones' > Subj

Re: [GIT PULL] ARM: amba: Enable module alias autogeneration for AMBA drivers

2011-12-19 Thread Dave Martin
Hi Russell, This one isn't urgent, but I'm not seeing the amba modalias patches anywhere yet. Did you have any outstanding concerns which need to be resolved? If you can suggest when/if these are likely to merge that would be great. Since Alessandro is now expecting to have to rebase on top of

Re: [PATCH 4/15] vub300: fix module parameter.

2011-12-19 Thread Tony Olech
On Thu, 2011-12-15 at 13:34 +1030, Rusty Russell wrote: > You didn't mean this to be a bool. > > Cc: Tony Olech > Cc: Chris Ball > Cc: linux-mmc@vger.kernel.org > Cc: linux-...@vger.kernel.org > Signed-off-by: Rusty Russell > --- > drivers/mmc/host/vub300.c |2 +- > 1 file changed, 1 inser

Re: [PATCH V2 2/2] mmc: Minimize resume-time by deferring resume

2011-12-19 Thread Ulf Hansson
If you got this half written reply, please ignore it. BR Ulf Hansson Ulf Hansson wrote: Vitaly Wool wrote: Hi, I did some measurement, having two eMMC connected (one of them with a root file system mounted) and one rather good SD-card with VFAT. The resume time for the kernel before these p

Re: [PATCH/RFC] mmc: add a device PM QoS constraint when a host is first claimed

2011-12-19 Thread Ulf Hansson
Guennadi Liakhovetski wrote: On Wed, 14 Dec 2011, Rafael J. Wysocki wrote: On Wednesday, December 14, 2011, Ulf Hansson wrote: [snip] 2. When executing mmc/sd commands/requests the host must always be claimed (and thus the host is always enabled). Why? Why cannot we save some power betwe

Re: [PATCH V2] mmc: core: Add option to prevent eMMC sleep command

2011-12-19 Thread Ulf Hansson
Subhash Jadavani wrote: On 12/19/2011 4:42 PM, Ulf Hansson wrote: Subhash Jadavani wrote: -Original Message- From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- ow...@vger.kernel.org] On Behalf Of Ulf Hansson Sent: Thursday, December 15, 2011 3:06 PM To: linux-mmc@vger.kernel.org

Re: [PATCH V2] mmc: core: Add option to prevent eMMC sleep command

2011-12-19 Thread Subhash Jadavani
On 12/19/2011 4:42 PM, Ulf Hansson wrote: Subhash Jadavani wrote: -Original Message- From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- ow...@vger.kernel.org] On Behalf Of Ulf Hansson Sent: Thursday, December 15, 2011 3:06 PM To: linux-mmc@vger.kernel.org; Chris Ball Cc: Per For

Re: [PATCH V2] mmc: core: Add option to prevent eMMC sleep command

2011-12-19 Thread Ulf Hansson
Subhash Jadavani wrote: -Original Message- From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- ow...@vger.kernel.org] On Behalf Of Ulf Hansson Sent: Thursday, December 15, 2011 3:06 PM To: linux-mmc@vger.kernel.org; Chris Ball Cc: Per Forlin; Ulf Hansson; Johan Rudholm; Lee Jones S

Re: [PATCH V2 2/2] mmc: Minimize resume-time by deferring resume

2011-12-19 Thread Ulf Hansson
Vitaly Wool wrote: Hi, I did some measurement, having two eMMC connected (one of them with a root file system mounted) and one rather good SD-card with VFAT. The resume time for the kernel before these patches were around 600 ms. After my patches I had around 20 ms. What do you call "resume

RE: [PATCH V6 1/2] mmc: core: HS200 mode support for eMMC 4.5

2011-12-19 Thread Subhash Jadavani
> -Original Message- > From: Girish K S [mailto:girish.shivananja...@linaro.org] > Sent: Monday, December 19, 2011 4:20 PM > To: Subhash Jadavani > Cc: linux-mmc@vger.kernel.org; patc...@linaro.org; linux-samsung- > s...@vger.kernel.org; Chris Ball > Subject: Re: [PATCH V6 1/2] mmc: core:

Re: [PATCH V6 1/2] mmc: core: HS200 mode support for eMMC 4.5

2011-12-19 Thread Girish K S
On 19 December 2011 15:40, Subhash Jadavani wrote: > Hi Girish, > > Overall this patch looks good. I have only 2 minor comments inline below. > > Regards, > Subhash > > >> -Original Message- >> From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- >> ow...@vger.kernel.org] On Behalf Of

Re: [PATCH] mmc: sdhci-s3c: Remove old and misprototyped suspend operations

2011-12-19 Thread Tushar Behera
Hi, Chris Ball laptop.org> writes: > > Hi, > > On Tue, Nov 29 2011, Jaehoon Chung wrote: > > Acked-by: Jaehoon Chung samsung.com> > > > > On 11/22/2011 03:00 AM, Mark Brown wrote: > > > >> Now that the driver is using dev_pm_ops the suspend operations in the > >> platform_driver structure won

RE: [PATCH V6 1/2] mmc: core: HS200 mode support for eMMC 4.5

2011-12-19 Thread Subhash Jadavani
Hi Girish, Overall this patch looks good. I have only 2 minor comments inline below. Regards, Subhash > -Original Message- > From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- > ow...@vger.kernel.org] On Behalf Of Girish K S > Sent: Monday, December 19, 2011 12:07 PM > To: linux-m

Re: mmc: sdio: runtime PM and 8686 problems

2011-12-19 Thread Ohad Ben-Cohen
On Mon, Dec 19, 2011 at 11:10 AM, Ohad Ben-Cohen wrote: > (it seems there are a few different hw revisions of it, some > of which do require toggling the reset pin before sending another init > sequence) (it might just be different setups and not really different hw revisions of the 8686) -- To u

Re: [PATCH] mmc/sdio: don't allow interface to runtime-suspend until probe is finished.

2011-12-19 Thread Ohad Ben-Cohen
Hello Bing, On Thu, Dec 15, 2011 at 9:35 AM, Bing Zhao wrote: >> I wonder why the sdio reset command isn't helpful for you - it did >> seem to resolve some issues for Daniel. Maybe you have two different >> hardware revisions of the 8686 which behave differently in this >> respect ? > > CMD52 Car

Re: mmc: sdio: runtime PM and 8686 problems

2011-12-19 Thread Ohad Ben-Cohen
Hi Chris, On Wed, Nov 30, 2011 at 4:29 PM, Ohad Ben-Cohen wrote: > On Wed, Nov 30, 2011 at 4:12 PM, Daniel Drake wrote: >> My patch simply sets a flag to enable a whole load of code written by >> you - code which I understand little about. I am now available to >> help, but given that my underst

Re: [PATCH 08/14] mmc: mmci: Fixup error handling for dma

2011-12-19 Thread Ulf Hansson
Russell King - ARM Linux wrote: On Mon, Dec 05, 2011 at 06:35:54PM +0100, Ulf Hansson wrote: When getting a cmd irq during an ongoing data transfer with dma, the dma job were never terminated. This is now corrected. Signed-off-by: Ulf Hansson Signed-off-by: Per Forlin I've queued this up in

Re: [PATCH 02/14] mmc: mmci: Fixup handling of MCI_STARTBITERR

2011-12-19 Thread Ulf Hansson
Russell King - ARM Linux wrote: On Mon, Dec 05, 2011 at 06:35:48PM +0100, Ulf Hansson wrote: The interrupt was previously enabled and then correctly cleared. Now we also handle it correctly. Signed-off-by: Ulf Hansson Acked-by: Linus Walleij I've queued this in my 'fixes' branch with a Cc t