RE: [PATCH v4 2/2] mmc: core: Support packed command for eMMC4.5 device

2012-02-20 Thread Seungwon Jeon
Maya Erez wrote: > > @@ -1262,21 +1608,32 @@ static int mmc_blk_issue_rw_rq(struct mmc_queue > > *mq, struct request *rqc) > > int ret = 1, disable_multi = 0, retry = 0, type; > > enum mmc_blk_status status; > > struct mmc_queue_req *mq_rq; > > - struct request *req; > > + struct r

Re: [PATCH] mmc-utils: improve the parsing of the EXT_CSD registers

2012-02-20 Thread Jaehoon Chung
On 02/21/2012 01:46 PM, Chris Ball wrote: > Hi, > > On Mon, Feb 20 2012, Jaehoon Chung wrote: >> Write protect is only supported the "power-on". >> If there is no problem to support "permanent", i will send the patch. >> Is any problem to support "permanent"? > > I think I'd rather not -- we cou

Re: [PATCH] mmc-utils: improve the parsing of the EXT_CSD registers

2012-02-20 Thread Chris Ball
Hi, On Mon, Feb 20 2012, Jaehoon Chung wrote: > Write protect is only supported the "power-on". > If there is no problem to support "permanent", i will send the patch. > Is any problem to support "permanent"? I think I'd rather not -- we could add a comment to the code that explains that setting

Re: [PATCH] mmc-utils: improve the parsing of the EXT_CSD registers

2012-02-20 Thread Jaehoon Chung
On 02/21/2012 02:43 AM, Chris Ball wrote: > Hi Giuseppe, > > On Mon, Feb 20 2012, Giuseppe CAVALLARO wrote: >> This patch enhances the debug information reported >> for the mmc card by parsing the extended CSD registers >> obviously according to all the current specifications. > > Thanks, this i

[PATCH] mmc: core: fix wrong bit operation for SD card's au_size

2012-02-20 Thread Jaehoon Chung
In SD spec, AU_SIZE and the value can be selected from 16KB. But this code should be selected from 32KB. I think right that shift (au + 3) instead of (au + 4). Signed-off-by: Jaehoon Chung Signed-off-by: Kyungmin Park CC: Hyeonsu Kim --- drivers/mmc/core/sd.c |2 +- 1 files changed, 1 inse

Re: [PATCH] mmc sdhci i.MX5: make mmc cards work

2012-02-20 Thread Shawn Guo
On 21 February 2012 02:41, Sascha Hauer wrote: > On Mon, Feb 20, 2012 at 02:31:36PM +0800, Shawn Guo wrote: >> I do not have a mmc card to test the patch, but I tested it and >> confirmed it does not break anything about SD support. >> >> On Fri, Feb 17, 2012 at 11:51:49AM +0100, Sascha Hauer wrot

Re: [PATCH v4 2/2] mmc: core: Support packed command for eMMC4.5 device

2012-02-20 Thread Namjae Jeon
2012/2/21 : >> >> @@ -1262,21 +1608,32 @@ static int mmc_blk_issue_rw_rq(struct mmc_queue >> *mq, struct request *rqc) >>       int ret = 1, disable_multi = 0, retry = 0, type; >>       enum mmc_blk_status status; >>       struct mmc_queue_req *mq_rq; >> -     struct request *req; >> +     struct

Re: [PATCH v4 2/2] mmc: core: Support packed command for eMMC4.5 device

2012-02-20 Thread merez
> > @@ -1262,21 +1608,32 @@ static int mmc_blk_issue_rw_rq(struct mmc_queue > *mq, struct request *rqc) > int ret = 1, disable_multi = 0, retry = 0, type; > enum mmc_blk_status status; > struct mmc_queue_req *mq_rq; > - struct request *req; > + struct request *req, *prq; >

Re: [PATCH] mmc sdhci i.MX5: make mmc cards work

2012-02-20 Thread Sascha Hauer
On Mon, Feb 20, 2012 at 02:31:36PM +0800, Shawn Guo wrote: > I do not have a mmc card to test the patch, but I tested it and > confirmed it does not break anything about SD support. > > On Fri, Feb 17, 2012 at 11:51:49AM +0100, Sascha Hauer wrote: > > On i.MX53 we have to write a special SDHCI_CMD

Re: [PATCH] mmc-utils: improve the parsing of the EXT_CSD registers

2012-02-20 Thread Chris Ball
Hi Giuseppe, On Mon, Feb 20 2012, Giuseppe CAVALLARO wrote: > This patch enhances the debug information reported > for the mmc card by parsing the extended CSD registers > obviously according to all the current specifications. Thanks, this is great! I've pushed your patch. I also moved Johan's

Re: [PATCH] mmc: dw_mmc: Fix disableing DMA in Non-IDMAC

2012-02-20 Thread Chris Ball
Hi, On Mon, Feb 20 2012, James Hogan wrote: > Hi, > > On 20/02/12 12:03, Seungwon Jeon wrote: >> dw_mci_pre_dma_transfer() is valid only if internal DMA. In case of >> using other DMA it returns -ENOSYS. It prevents the DMA operations. >> This patch makes dw_mci_pre_dma_transfer() effective in all

Re: mmc: dw_mmc: fixed compile error when disable CONFIG_MMC_DW_IDMAC

2012-02-20 Thread Chris Ball
Hi, On Mon, Feb 20 2012, James Hogan wrote: > On 16/02/12 02:19, Jaehoon Chung wrote: >> When disable CONFIG_MMC_DW_IDMAC, can see the compiler error. >> Because in dw_mci_post_req(), called the dw_mci_get_dma_dir(). >> But that function is in #ifdef CONFIG_MMC_DW_IDMAC. >> >> I think that functi

Re: ANNOUNCE: new "mmc-utils" repository

2012-02-20 Thread Giuseppe CAVALLARO
On 2/15/2012 2:43 PM, Giuseppe CAVALLARO wrote: > On 2/15/2012 2:35 PM, Chris Ball wrote: >> Hi, >> >> On Wed, Feb 15 2012, Giuseppe CAVALLARO wrote: >>> Hi Chris >>> >>> On 2/12/2012 6:03 PM, Chris Ball wrote: Hi, I've created a repository for userspace mmc tools now: git:

Re: [PATCH] mmc: dw_mmc: Fix disableing DMA in Non-IDMAC

2012-02-20 Thread James Hogan
Hi, On 20/02/12 12:03, Seungwon Jeon wrote: > dw_mci_pre_dma_transfer() is valid only if internal DMA. In case of > using other DMA it returns -ENOSYS. It prevents the DMA operations. > This patch makes dw_mci_pre_dma_transfer() effective in all DMA case. > > Reported-by: James Hogan > Signed-of

Re: mmc: dw_mmc: fixed compile error when disable CONFIG_MMC_DW_IDMAC

2012-02-20 Thread James Hogan
On 16/02/12 02:19, Jaehoon Chung wrote: > When disable CONFIG_MMC_DW_IDMAC, can see the compiler error. > Because in dw_mci_post_req(), called the dw_mci_get_dma_dir(). > But that function is in #ifdef CONFIG_MMC_DW_IDMAC. > > I think that function is generic function. > Not need the CONFIG_MMC_DW

[PATCH] mmc-utils: improve the parsing of the EXT_CSD registers

2012-02-20 Thread Giuseppe CAVALLARO
This patch enhances the debug information reported for the mmc card by parsing the extended CSD registers obviously according to all the current specifications. I have no HW to test eMMC 4.5 at this moment. In any case, the patch supports JEDEC Standard No. 84-B45. No issues on JESD84-A441 and old