Re: Occasional crashes in suspend-resume with MMC transactions

2012-03-25 Thread S, Venkatraman
On Thu, Mar 22, 2012 at 9:43 PM, Bedia, Vaibhav wrote: > On Thu, Mar 22, 2012 at 21:36:36, S, Venkatraman wrote: >> On Thu, Mar 22, 2012 at 8:13 PM, Bedia, Vaibhav wrote: >> > On Thu, Mar 22, 2012 at 19:57:16, S, Venkatraman wrote: >> > [...] >> >> >> >> I see (in 3.3) that the host controller dr

RE: [PATCH v1 1/1] mmc: bus: print bus speed mode of UHS-I card

2012-03-25 Thread Subhash Jadavani
> Also note that mmc_ios_show() function is currently not updated to print the > UHS-I bus speed modes in user readable format. We need to fix this as well > probably as separate patch. Aaron, Sorry, I just realized that I was looking at 3.0 kernel code. In mmc-next, I can see your patch which had

Re: [PATCH v1 1/1] mmc: bus: print bus speed mode of UHS-I card

2012-03-25 Thread Stephen Boyd
On 3/22/2012 10:56 PM, Subhash Jadavani wrote: > @@ -296,6 +297,28 @@ int mmc_add_card(struct mmc_card *card) > break; > } > > + if (mmc_sd_card_uhs(card)) { > + switch (card->sd_bus_speed) { > + case UHS_SDR104_BUS_SPEED: > + uh

Re: [PATCH 2/2] mmc: sh_mmcif: mmc->f_max should be half of the bus clock

2012-03-25 Thread Magnus Damm
On Mon, Mar 26, 2012 at 2:52 PM, Simon Horman wrote: > On Mon, Mar 26, 2012 at 02:45:30PM +0900, Yusuke Goda wrote: >> Hi Simon-san, Guennadi-san >> >> (2012/03/26 7:30), Simon Horman wrote: >> > On Sat, Mar 24, 2012 at 07:06:31PM +0100, Guennadi Liakhovetski wrote: >> >> On Wed, 21 Mar 2012, Simo

RE: [PATCH v1 1/1] mmc: bus: print bus speed mode of UHS-I card

2012-03-25 Thread Subhash Jadavani
> -Original Message- > From: linux-arm-msm-ow...@vger.kernel.org [mailto:linux-arm-msm- > ow...@vger.kernel.org] On Behalf Of Aaron Lu > Sent: Monday, March 26, 2012 8:47 AM > To: Subhash Jadavani > Cc: linux-mmc@vger.kernel.org; linux-arm-...@vger.kernel.org; > arindam.n...@amd.com > Sub

Re: [PATCH 2/2] mmc: sh_mmcif: mmc->f_max should be half of the bus clock

2012-03-25 Thread Yusuke Goda
Hi Simon-san (2012/03/26 14:52), Simon Horman wrote: > On Mon, Mar 26, 2012 at 02:45:30PM +0900, Yusuke Goda wrote: >> Hi Simon-san, Guennadi-san >> >> (2012/03/26 7:30), Simon Horman wrote: >>> On Sat, Mar 24, 2012 at 07:06:31PM +0100, Guennadi Liakhovetski wrote: On Wed, 21 Mar 2012, Simon

Re: [PATCH 2/2] mmc: sh_mmcif: mmc->f_max should be half of the bus clock

2012-03-25 Thread Simon Horman
On Mon, Mar 26, 2012 at 02:45:30PM +0900, Yusuke Goda wrote: > Hi Simon-san, Guennadi-san > > (2012/03/26 7:30), Simon Horman wrote: > > On Sat, Mar 24, 2012 at 07:06:31PM +0100, Guennadi Liakhovetski wrote: > >> On Wed, 21 Mar 2012, Simon Horman wrote: > >> > >>> mmc->f_max should be half of the

Re: [PATCH 2/2] mmc: sh_mmcif: mmc->f_max should be half of the bus clock

2012-03-25 Thread Yusuke Goda
Hi Simon-san, Guennadi-san (2012/03/26 7:30), Simon Horman wrote: > On Sat, Mar 24, 2012 at 07:06:31PM +0100, Guennadi Liakhovetski wrote: >> On Wed, 21 Mar 2012, Simon Horman wrote: >> >>> mmc->f_max should be half of the bus clock. >>> And now that mmc->f_max is not equal to the bus clock the >>

Re: [PATCH v1 1/1] mmc: bus: print bus speed mode of UHS-I card

2012-03-25 Thread Aaron Lu
Hi Subhash, On Fri, Mar 23, 2012 at 11:26:36AM +0530, Subhash Jadavani wrote: > When UHS-I card is detected also print the bus speed mode > in which UHS-I card will be running. The patch looks correct to me, except that I' m not sure if this is needed. /sys/kernel/debug/mmc/ios also has such info

Re: [PATCH 1/2] mmc: sh_mmcif: double clock speed

2012-03-25 Thread Simon Horman
On Sat, Mar 24, 2012 at 06:56:16PM +0100, Guennadi Liakhovetski wrote: > Hi Simon > > On Wed, 21 Mar 2012, Simon Horman wrote: > > > This corrects an off-by one error when calculating the clock divisor. > > The code previously assumed that for example a divisor of 2 is > > set using a value of 00

[PATCH] PM / SDIO: Use empty system suspend/resume callbacks at the bus level (was: Re: Recent ...)

2012-03-25 Thread Rafael J. Wysocki
On Sunday, March 25, 2012, NeilBrown wrote: > On Sun, 25 Mar 2012 23:25:37 +0200 "Rafael J. Wysocki" wrote: > > > On Sunday, March 25, 2012, Rafael J. Wysocki wrote: > > > Hi, > > > > > > On Sunday, March 25, 2012, NeilBrown wrote: > > > > > > > > Hi Rafael, > > > > > > > > Your recent patch:

Re: Recent "Run the driver callback directly" patch breaks libertas suspend

2012-03-25 Thread NeilBrown
On Sun, 25 Mar 2012 23:25:37 +0200 "Rafael J. Wysocki" wrote: > On Sunday, March 25, 2012, Rafael J. Wysocki wrote: > > Hi, > > > > On Sunday, March 25, 2012, NeilBrown wrote: > > > > > > Hi Rafael, > > > > > > Your recent patch: > > >commit 35cd133c > > >PM: Run the driver callback d

Re: Recent "Run the driver callback directly" patch breaks libertas suspend

2012-03-25 Thread Rafael J. Wysocki
On Sunday, March 25, 2012, Rafael J. Wysocki wrote: > Hi, > > On Sunday, March 25, 2012, NeilBrown wrote: > > > > Hi Rafael, > > > > Your recent patch: > >commit 35cd133c > >PM: Run the driver callback directly if the subsystem one is not there > > > > breaks suspend for my libertas w

Re: [linux-pm] Recent "Run the driver callback directly" patch breaks libertas suspend

2012-03-25 Thread Rafael J. Wysocki
On Sunday, March 25, 2012, Alan Stern wrote: > On Sun, 25 Mar 2012, NeilBrown wrote: > > > Hi Rafael, > > > > Your recent patch: > >commit 35cd133c > >PM: Run the driver callback directly if the subsystem one is not there > > > > breaks suspend for my libertas wifi and probably other S

Re: Recent "Run the driver callback directly" patch breaks libertas suspend

2012-03-25 Thread Rafael J. Wysocki
Hi, On Sunday, March 25, 2012, NeilBrown wrote: > > Hi Rafael, > > Your recent patch: >commit 35cd133c >PM: Run the driver callback directly if the subsystem one is not there > > breaks suspend for my libertas wifi and probably other SDIO devices. Well, the patch is not recent. The

Re: [linux-pm] Recent "Run the driver callback directly" patch breaks libertas suspend

2012-03-25 Thread Alan Stern
On Sun, 25 Mar 2012, NeilBrown wrote: > Hi Rafael, > > Your recent patch: >commit 35cd133c >PM: Run the driver callback directly if the subsystem one is not there > > breaks suspend for my libertas wifi and probably other SDIO devices. > > SDIO (and possible MMC in general) has a pro

Recent "Run the driver callback directly" patch breaks libertas suspend

2012-03-25 Thread NeilBrown
Hi Rafael, Your recent patch: commit 35cd133c PM: Run the driver callback directly if the subsystem one is not there breaks suspend for my libertas wifi and probably other SDIO devices. SDIO (and possible MMC in general) has a protocol where the suspend method can return -ENOSYS and t