2012/4/14 S, Venkatraman :
> On Fri, Apr 13, 2012 at 8:09 PM, Namjae Jeon wrote:
>> Hi. Venkatraman.
>>
>> You fixed 10 times. why is it 10 times ?
> There's no right number - I haven't seen it fail much in my tests but
> should allow a few retries.
Is there the reason should send HPI a few retrie
Commit 06e8935feb "optimized SDIO IRQ handling for single irq"
introduced some spurious calls to SDIO function interrupt handlers,
such as when the SDIO IRQ thread is started, or the safety check
performed upon a system resume. Let's add a flag to perform the
optimization only when a real inter
Hi,
I'm running linux-next on a tegra-sdhci host which has a Toshiba
THGBM2G6D2FBAI9 eMMC connected. During boot I get a "mmc1: power class
selection to bus width 8 failed" warning.
/sys/kernel/debug/mmc1# cat ios
clock: 4800 Hz
actual clock: 4800 Hz
vdd:20 (3.2
On Fri, Apr 13, 2012 at 8:09 PM, Namjae Jeon wrote:
> Hi. Venkatraman.
>
> You fixed 10 times. why is it 10 times ?
There's no right number - I haven't seen it fail much in my tests but
should allow a few retries.
> and checking err from mmc_send_status is not needed ? is it also
> infinite case
2012/4/12 Subhash Jadavani :
> With current implementation of power class selection,
> mmc_select_powerclass() should never fail. So treat any error
> returned by this function as serious enough to skip the card
> initialization.
>
> Signed-off-by: Subhash Jadavani
Looks good to me.
Reviewed-by: N
Hi. Venkatraman.
You fixed 10 times. why is it 10 times ?
and checking err from mmc_send_status is not needed ? is it also
infinite case ?
Thanks.
2012/4/13 Venkatraman S :
> Try to send HPI only a fixed number of times till it is
> successful. One successful transfer is enough - but wait
> til
Hi
Just confirming, that the 3 outstanding ARM patches, that I mentioned in
recent emails:
http://article.gmane.org/gmane.linux.kernel.mmc/12748
http://article.gmane.org/gmane.linux.ports.sh.devel/13535
http://article.gmane.org/gmane.linux.ports.sh.devel/13975
still apply to the current Linus'
Try to send HPI only a fixed number of times till it is
successful. One successful transfer is enough - but wait
till the card comes out of transfer state.
Return an error if the card was not in programming state to
begin with - so that the caller knows that HPI was not sent.
Reported-by: Alex Lem
Not needed to memset, as they are pointers and are assigned
to proper values in the next line anyway.
Signed-off-by: Venkatraman S
---
drivers/mmc/card/queue.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/mmc/card/queue.c b/drivers/mmc/card/queue.c
index 49af43c..e360a97 10064
Include the corresponding header file in cd-gpio.c
for prototype consistency. This gets rid of some
sparse warnings.
Signed-off-by: Venkatraman S
---
drivers/mmc/core/cd-gpio.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/core/cd-gpio.c b/drivers/mmc/core/cd-gpio.c
index 2
The name mmc_request is used for both the issue function
and a data structure, which creates conflicts in symbol lookups
in editors. Rename the function to mmc_request_fn
Signed-off-by: Venkatraman S
---
drivers/mmc/card/queue.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
The first 3 are straight forward / trivial fixes.
The last one is a functional change on how HPI should be invoked
on the card. This is required for my future foreground HPI series
that'll follow.
Also available at git://github.com/svenkatr/linux.git my/mmc/cleanups-v2
Venkatraman S (4):
12 matches
Mail list logo
