[PATCH 1/2] mmc: omap_hsmmc: Add fclk frequency to debufs

2012-04-18 Thread Venkatraman S
From: Viswanath Puttagunta Add mmc functional clock frequency to list of internal state variables to display for debug. Signed-off-by: Viswanath Puttagunta Signed-off-by: Venkatraman S --- v1 -> v2: Restored indentation to be consistent as the rest of the file. drive

[PATCH v2] mmc: core: Fix the HPI execution sequence

2012-04-18 Thread Venkatraman S
mmc_execute_hpi should send the HPI command only once, only if the card is in PRG state. According to eMMC spec, the command's completion time is not dependent on OUT_OF_INTERRUPT_TIME. Only the transition out of PRG STATE is guarded by OUT_OF_INTERRUPT_TIME - which is defined to begin at the end

Re: [PATCH 2/3] mmc: omap_hsmmc: Add fclk frequency to debufs

2012-04-18 Thread Chris Ball
Hi, On Thu, Apr 19 2012, S, Venkatraman wrote: >>> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c >>> index d15b149..d046ba2 100644 >>> --- a/drivers/mmc/host/omap_hsmmc.c >>> +++ b/drivers/mmc/host/omap_hsmmc.c >>> @@ -1683,8 +1683,9 @@ static int omap_hsmmc_regs_show(

Re: [PATCH 4/4] mmc: core: Send HPI only till it is successful

2012-04-18 Thread S, Venkatraman
On Thu, Apr 19, 2012 at 9:59 AM, Chris Ball wrote: > Hi, > > On Fri, Apr 13 2012, Venkatraman S wrote: >> Try to send HPI only a fixed number of times till it is >> successful. One successful transfer is enough - but wait >> till the card comes out of transfer state. >> Return an error if the card

Re: [PATCH 4/4] mmc: core: Send HPI only till it is successful

2012-04-18 Thread Chris Ball
Hi, On Fri, Apr 13 2012, Venkatraman S wrote: > Try to send HPI only a fixed number of times till it is > successful. One successful transfer is enough - but wait > till the card comes out of transfer state. > Return an error if the card was not in programming state to > begin with - so that the c

Re: [PATCH 2/3] mmc: omap_hsmmc: Add fclk frequency to debufs

2012-04-18 Thread S, Venkatraman
On Thu, Apr 19, 2012 at 5:34 AM, Chris Ball wrote: > Hi, > > On Wed, Apr 18 2012, Venkatraman S wrote: >> From: Viswanath Puttagunta >> >> Add mmc functional clock frequency to list of >> internal state variables to display for debug. >> >> Signed-off-by: Viswanath Puttagunta >> Signed-off-by: V

Re: [PATCH] mmc: core: Fix the HPI execution sequence

2012-04-18 Thread Chris Ball
Hi, On Wed, Apr 18 2012, Venkatraman S wrote: > mmc_execute_hpi should send the HPI command only > once, only if the card is in PRG state. > > According to eMMC spec, the command's completion time is > not dependent on OUT_OF_INTERRUPT_TIME. Only the transition > out of PRG STATE is guarded by OUT

Re: [PATCH] mmc: core: Fix the HPI execution sequence

2012-04-18 Thread S, Venkatraman
On Thu, Apr 19, 2012 at 7:22 AM, Jaehoon Chung wrote: > Acked-by: Jaehoon Chung > Thanks Jaehoon Chung. BTW, would you consider looking into the foreground HPI series ? Chris, Can you please take this too for 3.5 ? > On 04/18/2012 11:45 PM, Venkatraman S wrote: > >> mmc_execute_hpi should se

Re: [PATCH] mmc: core: Fix the HPI execution sequence

2012-04-18 Thread Jaehoon Chung
Acked-by: Jaehoon Chung On 04/18/2012 11:45 PM, Venkatraman S wrote: > mmc_execute_hpi should send the HPI command only > once, only if the card is in PRG state. > > According to eMMC spec, the command's completion time is > not dependent on OUT_OF_INTERRUPT_TIME. Only the transition > out of P

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread Tony Lindgren
* Russell King - ARM Linux [120418 14:40]: > On Wed, Apr 18, 2012 at 10:16:06PM +0100, Russell King - ARM Linux wrote: > > I don't think it has to in this case, though I am thinking that we > > may have to adjust the frame size for other peripherals. > > > > In the case of the OMAP1 MMC driver, l

Re: [PATCH] mmc: unbreak sdhci-esdhc-imx on i.MX25

2012-04-18 Thread Chris Ball
Hi, On Wed, Apr 18 2012, Wolfram Sang wrote: > On Wed, Apr 18, 2012 at 08:00:42PM -0400, Chris Ball wrote: > >> Thanks, pushed to mmc-next for 3.4. > > If not done already, I think a stable-tag would make sense. Thanks for noticing -- agreed and added. - Chris. -- Chris Ball

Re: [PATCH V1] mmc: tegra: support SDHCI SPEC 300

2012-04-18 Thread Chris Ball
Hi, On Wed, Apr 18 2012, Stephen Warren wrote: > On 04/18/2012 07:18 AM, Pavan Kunapuli wrote: >> Tegra3 SDHOST controller doesn't advertise >> v3.00 support by default. This support has to >> be enabled by configuring a vendor register in >> the tegra3 sd host address space. >> >> Signed-off-by:

Re: [PATCH] mmc: unbreak sdhci-esdhc-imx on i.MX25

2012-04-18 Thread Wolfram Sang
On Wed, Apr 18, 2012 at 08:00:42PM -0400, Chris Ball wrote: > Thanks, pushed to mmc-next for 3.4. If not done already, I think a stable-tag would make sense. -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pen

Re: [PATCH 2/3] mmc: omap_hsmmc: Add fclk frequency to debufs

2012-04-18 Thread Chris Ball
Hi, On Wed, Apr 18 2012, Venkatraman S wrote: > From: Viswanath Puttagunta > > Add mmc functional clock frequency to list of > internal state variables to display for debug. > > Signed-off-by: Viswanath Puttagunta > Signed-off-by: Venkatraman S > --- > drivers/mmc/host/omap_hsmmc.c |5 +++-

Re: [PATCH] dw-mmc: prevent the Null pointer dereference for dma_ops

2012-04-18 Thread Chris Ball
Hi, On Wed, Apr 18 2012, Will Newton wrote: > On Wed, Apr 18, 2012 at 7:42 AM, Jaehoon Chung wrote: >> Now, dma_ops is assumed that use the IDMAC. >> But if dma_ops is assigned the pdata->dma_ops, >> We didn't ensure that callback function is defined. >> >> If anything of callback didn't define,

Re: [PATCH] mmc: unbreak sdhci-esdhc-imx on i.MX25

2012-04-18 Thread Chris Ball
Hi, On Tue, Apr 17 2012, Eric BĂ©nard wrote: > this was broken by me in 37865fe91582582a6f6c00652f6a2b1ff71f8a78 > "mmc: sdhci-esdhc-imx: fix timeout on i.MX's sdhc" where more > extensive tests would have shown that read or write of data > to the card were failing (even if the partition table was

Re: [PATCH v2] mmc: cd-gpio.c: Include header to pickup exported symbol prototypes

2012-04-18 Thread Chris Ball
Hi, On Tue, Apr 17 2012, Guennadi Liakhovetski wrote: > On Tue, 17 Apr 2012, H Hartley Sweeten wrote: > >> Include the linux/mmc/cd-gpio.h header to pickup the prototypes >> for the two exported symbols. >> >> This quiets the sparse warnings: >> >> warning: symbol 'mmc_cd_gpio_request' was not d

Re: [PATCH] mmc: sdhci: refine non-removable card checking for card detection

2012-04-18 Thread Chris Ball
Hi Dan, On Mon, Apr 09 2012, Daniel Drake wrote: > Commit c79396c191bc19703df6eb6bbd0f673ed0df6c9d disables card detection > where the cards are marked as non-removable. > > This makes sense, but the implementation detail of calling > mmc_card_is_removable() causes some problems, because > mmc_car

Re: [PATCH v2] mmc: sdio: avoid spurious calls to interrupt handlers

2012-04-18 Thread Chris Ball
Hi, On Mon, Apr 16 2012, Nicolas Pitre wrote: > Commit 06e8935feb "optimized SDIO IRQ handling for single irq" > introduced some spurious calls to SDIO function interrupt handlers, > such as when the SDIO IRQ thread is started, or the safety check > performed upon a system resume. Let's add a fla

Re: [PATCH 2/4] mmc: include cd-gpio.h in the source file

2012-04-18 Thread Namjae Jeon
2012/4/13 Venkatraman S : > Include the corresponding header file in cd-gpio.c > for prototype consistency. This gets rid of some > sparse warnings. > > Signed-off-by: Venkatraman S This patch is same with H Hartley Sweeten's patch ([PATCH v2] mmc: cd-gpio.c: Include header to pickup exported symb

Re: [PATCH 1/4] mmc: queue: rename mmc_request function

2012-04-18 Thread Namjae Jeon
2012/4/13 Venkatraman S : > The name mmc_request is used for both the issue function > and a data structure, which creates conflicts in symbol lookups > in editors. Rename the function to mmc_request_fn > > Signed-off-by: Venkatraman S Looks reasonable to me~ Reviewed-by: Namjae Jeon Thanks. > -

Re: [PATCH] mmc: core: Fix the HPI execution sequence

2012-04-18 Thread Namjae Jeon
2012/4/18 Venkatraman S : > mmc_execute_hpi should send the HPI command only > once, only if the card is in PRG state. > > According to eMMC spec, the command's completion time is > not dependent on OUT_OF_INTERRUPT_TIME. Only the transition > out of PRG STATE is guarded by OUT_OF_INTERRUPT_TIME -

Re: [PATCH 3/4] mmc: queue: remove redundant memsets

2012-04-18 Thread Namjae Jeon
2012/4/13 Venkatraman S : > Not needed to memset, as they are pointers and are assigned > to proper values in the next line anyway. > > Signed-off-by: Venkatraman S Looks good!! Reviewed-by: Namjae Jeon Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread Russell King - ARM Linux
On Wed, Apr 18, 2012 at 10:16:06PM +0100, Russell King - ARM Linux wrote: > I don't think it has to in this case, though I am thinking that we > may have to adjust the frame size for other peripherals. > > In the case of the OMAP1 MMC driver, let me pull out that chunk of code > again: > >

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread Tony Lindgren
* Russell King - ARM Linux [120418 14:19]: > On Wed, Apr 18, 2012 at 02:01:44PM -0700, Tony Lindgren wrote: > > * Russell King - ARM Linux [120418 13:28]: > > > I'd like to have the same thing happen on OMAP1 as well (it's actually > > > quite simple to do) and it means that this DMA engine imple

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread Russell King - ARM Linux
On Wed, Apr 18, 2012 at 02:01:44PM -0700, Tony Lindgren wrote: > * Russell King - ARM Linux [120418 13:28]: > > I'd like to have the same thing happen on OMAP1 as well (it's actually > > quite simple to do) and it means that this DMA engine implementation > > detail is (correctly) hidden from the

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread Tony Lindgren
* Russell King - ARM Linux [120418 13:28]: > On Wed, Apr 18, 2012 at 01:02:15PM -0700, Tony Lindgren wrote: > > The scatterlist entries are separate DMA requests on omap1, there's no > > chaining support in the DMA hardware on omap1. So yes, it's for every > > scatterlist entry on omap1. > > Ther

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread Russell King - ARM Linux
On Wed, Apr 18, 2012 at 01:02:15PM -0700, Tony Lindgren wrote: > The scatterlist entries are separate DMA requests on omap1, there's no > chaining support in the DMA hardware on omap1. So yes, it's for every > scatterlist entry on omap1. There's no direct scatterlist support on OMAP2 either (omap_

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread Tony Lindgren
* Russell King - ARM Linux [120418 12:46]: > On Wed, Apr 18, 2012 at 09:05:56PM +0530, T Krishnamoorthy, Balaji wrote: > > On Wed, Apr 18, 2012 at 8:59 PM, Russell King - ARM Linux > > wrote: > > > On Wed, Apr 18, 2012 at 08:53:32PM +0530, T Krishnamoorthy, Balaji wrote: > > >> Hi, > > >> > > >>

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread Tony Lindgren
* Russell King - ARM Linux [120418 12:14]: > On Wed, Apr 18, 2012 at 11:19:18AM -0700, Tony Lindgren wrote: > > * T Krishnamoorthy, Balaji [120418 08:39]: > > > On Wed, Apr 18, 2012 at 8:59 PM, Russell King - ARM Linux > > > wrote: > > > > On Wed, Apr 18, 2012 at 08:53:32PM +0530, T Krishnamoort

Re: [PATCH 6/8] mmc: omap_hsmmc: add DMA engine support

2012-04-18 Thread Tony Lindgren
* Russell King - ARM Linux [120418 12:12]: > On Wed, Apr 18, 2012 at 11:11:12AM -0700, Tony Lindgren wrote: > > * Russell King [120418 03:15]: > > > Add DMA engine support to the OMAP HSMMC driver. This supplements the > > > private DMA API implementation contained within this driver, and the >

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread Russell King - ARM Linux
On Wed, Apr 18, 2012 at 09:05:56PM +0530, T Krishnamoorthy, Balaji wrote: > On Wed, Apr 18, 2012 at 8:59 PM, Russell King - ARM Linux > wrote: > > On Wed, Apr 18, 2012 at 08:53:32PM +0530, T Krishnamoorthy, Balaji wrote: > >> Hi, > >> > >> drivers/mmc/host/omap.c is also using dma_mask should that

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread Russell King - ARM Linux
On Wed, Apr 18, 2012 at 11:19:18AM -0700, Tony Lindgren wrote: > * T Krishnamoorthy, Balaji [120418 08:39]: > > On Wed, Apr 18, 2012 at 8:59 PM, Russell King - ARM Linux > > wrote: > > > On Wed, Apr 18, 2012 at 08:53:32PM +0530, T Krishnamoorthy, Balaji wrote: > > >> Hi, > > >> > > >> drivers/mmc

Re: [PATCH 6/8] mmc: omap_hsmmc: add DMA engine support

2012-04-18 Thread Russell King - ARM Linux
On Wed, Apr 18, 2012 at 11:11:12AM -0700, Tony Lindgren wrote: > * Russell King [120418 03:15]: > > Add DMA engine support to the OMAP HSMMC driver. This supplements the > > private DMA API implementation contained within this driver, and the > > driver can be switched at build time between using

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread Tony Lindgren
* T Krishnamoorthy, Balaji [120418 08:39]: > On Wed, Apr 18, 2012 at 8:59 PM, Russell King - ARM Linux > wrote: > > On Wed, Apr 18, 2012 at 08:53:32PM +0530, T Krishnamoorthy, Balaji wrote: > >> Hi, > >> > >> drivers/mmc/host/omap.c is also using dma_mask should that also be removed > > > > Does

Re: [PATCH 6/8] mmc: omap_hsmmc: add DMA engine support

2012-04-18 Thread Tony Lindgren
* Russell King [120418 03:15]: > Add DMA engine support to the OMAP HSMMC driver. This supplements the > private DMA API implementation contained within this driver, and the > driver can be switched at build time between using DMA engine and the > private DMA API. Glad to see this happening! No

Re: [PATCH V1] mmc: tegra: support SDHCI SPEC 300

2012-04-18 Thread Stephen Warren
On 04/18/2012 07:18 AM, Pavan Kunapuli wrote: > Tegra3 SDHOST controller doesn't advertise > v3.00 support by default. This support has to > be enabled by configuring a vendor register in > the tegra3 sd host address space. > > Signed-off-by: Pavan Kunapuli FWIW, Acked-by: Stephen Warren -- To

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread T Krishnamoorthy, Balaji
On Wed, Apr 18, 2012 at 8:59 PM, Russell King - ARM Linux wrote: > On Wed, Apr 18, 2012 at 08:53:32PM +0530, T Krishnamoorthy, Balaji wrote: >> Hi, >> >> drivers/mmc/host/omap.c is also using dma_mask should that also be removed > > Does this driver make use of this platform data? > > If so, it ne

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread Russell King - ARM Linux
On Wed, Apr 18, 2012 at 08:53:32PM +0530, T Krishnamoorthy, Balaji wrote: > Hi, > > drivers/mmc/host/omap.c is also using dma_mask should that also be removed Does this driver make use of this platform data? If so, it needs converting to DMA engine _before_ this patch (which is one reason why it

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread T Krishnamoorthy, Balaji
On Wed, Apr 18, 2012 at 3:42 PM, Russell King wrote: > DMAengine uses the DMA engine device structure when mapping/unmapping > memory for DMA, so the MMC devices do not need their DMA masks > initialized (this reflects hardware: the MMC device is not the device > doing DMA.) > > Signed-off-by: Rus

Re: "Prevent too long response times for suspend" breaks libertas_sdio

2012-04-18 Thread Chris Ball
Hi Ulf, On Mon, Apr 16 2012, Daniel Drake wrote: > This commit breaks libertas_sdio suspend: > > commit b6ad726e3fe69e1ff3c3b2ad272ba3e4c376cd6a > Author: Ulf Hansson > Date: Thu Oct 13 16:03:58 2011 +0200 > > mmc: core: Prevent too long response times for suspend > > While trying to su

Re: [PATCH v2] mmc: core: Fix the HPI execution sequence

2012-04-18 Thread S, Venkatraman
On Wed, Apr 18, 2012 at 6:24 PM, Jaehoon Chung wrote: > On 04/18/2012 05:42 PM, S, Venkatraman wrote: > >> On Wed, Apr 18, 2012 at 1:53 PM, Namjae Jeon wrote: >>> 2012/4/18 S, Venkatraman : On Wed, Apr 18, 2012 at 10:15 AM, Namjae Jeon wrote: > 2012/4/18 Jaehoon Chung : >> On 04/18/

[PATCH] mmc: core: Fix the HPI execution sequence

2012-04-18 Thread Venkatraman S
mmc_execute_hpi should send the HPI command only once, only if the card is in PRG state. According to eMMC spec, the command's completion time is not dependent on OUT_OF_INTERRUPT_TIME. Only the transition out of PRG STATE is guarded by OUT_OF_INTERRUPT_TIME - which is defined to begin at the end

Re: [PATCH 4/8] mmc: mmci: Use ios_handler to save power

2012-04-18 Thread Russell King - ARM Linux
On Wed, Apr 18, 2012 at 01:57:27PM +0200, Vitaly Wool wrote: > Hi Ulf, > > On Tue, Jan 17, 2012 at 3:34 PM, Ulf Hansson > wrote: > > To disable a levelshifter when we are in an idle state will > > decrease current consumption. We make use of the ios_handler > > at runtime suspend and at regular

[PATCH V1] mmc: tegra: support SDHCI SPEC 300

2012-04-18 Thread Pavan Kunapuli
Tegra3 SDHOST controller doesn't advertise v3.00 support by default. This support has to be enabled by configuring a vendor register in the tegra3 sd host address space. Signed-off-by: Pavan Kunapuli --- drivers/mmc/host/sdhci-tegra.c | 26 ++ 1 files changed, 26 insert

Re: [PATCH v2] mmc: core: Fix the HPI execution sequence

2012-04-18 Thread Jaehoon Chung
On 04/18/2012 05:42 PM, S, Venkatraman wrote: > On Wed, Apr 18, 2012 at 1:53 PM, Namjae Jeon wrote: >> 2012/4/18 S, Venkatraman : >>> On Wed, Apr 18, 2012 at 10:15 AM, Namjae Jeon wrote: 2012/4/18 Jaehoon Chung : > On 04/18/2012 09:20 AM, Namjae Jeon wrote: > >> 2012/4/17 Venkat

Re: [PATCH 4/8] mmc: mmci: Use ios_handler to save power

2012-04-18 Thread Vitaly Wool
Hi Ulf, On Tue, Jan 17, 2012 at 3:34 PM, Ulf Hansson wrote: > To disable a levelshifter when we are in an idle state will > decrease current consumption. We make use of the ios_handler > at runtime suspend and at regular suspend to accomplish this. > > Of course depending on the used levelshifter

[PATCH] mmc: omap_hsmmc: release correct resource

2012-04-18 Thread Venkatraman S
From: Russell King res can be one of several resources, as this variable is re-used several times during probe. This can cause the wrong resource parameters to be passed to release_mem_region(). Get the original memory resource before calling release_mem_region(). Signed-off-by: Russell King

Re: [PATCH 1/8] ARM: OMAP: fix DMA vs memory ordering

2012-04-18 Thread Russell King - ARM Linux
On Wed, Apr 18, 2012 at 01:18:55PM +0300, Felipe Balbi wrote: > On Wed, Apr 18, 2012 at 11:17:33AM +0100, Russell King - ARM Linux wrote: > > Has anyone seen a problem (other than me when trying to get DMA engine > > working with omap-serial transmit paths) ? > > probably not since omap-serial isn

Re: [PATCH 1/3] mmc: omap_hsmmc: release correct resource

2012-04-18 Thread S, Venkatraman
On Wed, Apr 18, 2012 at 3:28 PM, Russell King - ARM Linux wrote: > On Wed, Apr 18, 2012 at 03:19:11PM +0530, Venkatraman S wrote: >> From: Russell King - ARM Linux > > Please correct this to "Russell King " > Ok. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body

Re: [PATCH 1/8] ARM: OMAP: fix DMA vs memory ordering

2012-04-18 Thread Felipe Balbi
On Wed, Apr 18, 2012 at 11:17:33AM +0100, Russell King - ARM Linux wrote: > On Wed, Apr 18, 2012 at 01:15:20PM +0300, Felipe Balbi wrote: > > On Wed, Apr 18, 2012 at 11:10:35AM +0100, Russell King wrote: > > > Using coherent DMA memory with the OMAP DMA engine results in > > > unpredictable behavio

Re: [PATCH 2/8] dmaengine: amba-pl08x: ensure physical channels are properly held

2012-04-18 Thread Russell King - ARM Linux
Oops, this patch wasn't supposed to be part of this set... On Wed, Apr 18, 2012 at 11:10:55AM +0100, Russell King wrote: > Ensure that physical channels are held while there are descriptors for > them to process. This is needed when we split the pending queue into > separate pending and issued qu

Re: [PATCH 1/8] ARM: OMAP: fix DMA vs memory ordering

2012-04-18 Thread Russell King - ARM Linux
On Wed, Apr 18, 2012 at 01:15:20PM +0300, Felipe Balbi wrote: > On Wed, Apr 18, 2012 at 11:10:35AM +0100, Russell King wrote: > > Using coherent DMA memory with the OMAP DMA engine results in > > unpredictable behaviour due to memory ordering issues; as things stand, > > there is no guarantee that

Re: [PATCH 1/8] ARM: OMAP: fix DMA vs memory ordering

2012-04-18 Thread Felipe Balbi
On Wed, Apr 18, 2012 at 11:10:35AM +0100, Russell King wrote: > Using coherent DMA memory with the OMAP DMA engine results in > unpredictable behaviour due to memory ordering issues; as things stand, > there is no guarantee that data written to coherent DMA memory will be > visible to the DMA hardw

[PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread Russell King
DMAengine uses the DMA engine device structure when mapping/unmapping memory for DMA, so the MMC devices do not need their DMA masks initialized (this reflects hardware: the MMC device is not the device doing DMA.) Signed-off-by: Russell King --- arch/arm/mach-omap1/board-h2-mmc.c|1 - a

[PATCH 7/8] mmc: omap_hsmmc: remove private DMA API implementation

2012-04-18 Thread Russell King
Remove the private DMA API implementation from omap_hsmmc, making it use entirely the DMA engine API. Signed-off-by: Russell King --- drivers/mmc/host/omap_hsmmc.c | 264 ++--- 1 files changed, 64 insertions(+), 200 deletions(-) diff --git a/drivers/mmc/host

[PATCH 6/8] mmc: omap_hsmmc: add DMA engine support

2012-04-18 Thread Russell King
Add DMA engine support to the OMAP HSMMC driver. This supplements the private DMA API implementation contained within this driver, and the driver can be switched at build time between using DMA engine and the private DMA API. Signed-off-by: Russell King --- drivers/mmc/host/omap_hsmmc.c | 192

[PATCH 5/8] mmc: omap_hsmmc: release correct resource

2012-04-18 Thread Russell King
res can be one of several resources, as this variable is re-used several times during probe. This can cause the wrong resource parameters to be passed to release_mem_region(). Get the original memory resource before calling release_mem_region(). Signed-off-by: Russell King --- drivers/mmc/host

[PATCH 4/8] dmaengine: add OMAP DMA engine driver

2012-04-18 Thread Russell King
Signed-off-by: Russell King --- drivers/dma/Kconfig|6 + drivers/dma/Makefile |1 + drivers/dma/omap-dma.c | 519 3 files changed, 526 insertions(+), 0 deletions(-) create mode 100644 drivers/dma/omap-dma.c diff --git a/drivers/dma

[PATCH 3/8] dmaengine: split out virtual channel DMA support from sa11x0 driver

2012-04-18 Thread Russell King
Split the virtual slave channel DMA support from the sa11x0 driver so this code can be shared with other slave DMA engine drivers. Signed-off-by: Russell King --- drivers/dma/Kconfig |4 + drivers/dma/Makefile |1 + drivers/dma/sa11x0-dma.c | 249 ++-

[PATCH 2/8] dmaengine: amba-pl08x: ensure physical channels are properly held

2012-04-18 Thread Russell King
Ensure that physical channels are held while there are descriptors for them to process. This is needed when we split the pending queue into separate pending and issued queues. Signed-off-by: Russell King --- drivers/dma/amba-pl08x.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletio

[PATCH 1/8] ARM: OMAP: fix DMA vs memory ordering

2012-04-18 Thread Russell King
Using coherent DMA memory with the OMAP DMA engine results in unpredictable behaviour due to memory ordering issues; as things stand, there is no guarantee that data written to coherent DMA memory will be visible to the DMA hardware. This is because the OMAP dma_write() accessor contains no barrie

[RFC 0/8] DMA engine conversion for omap_hsmmc

2012-04-18 Thread Russell King - ARM Linux
This series is the preliminary conversion of OMAPs private DMA API to DMAengine. It focuses on the OMAP HSMMC driver, as I believe that is the only DMA-capable driver which is used on the platforms I have available (3430LDP and 4430SDP). For the OMAP DMAengine driver, there's a few short-comings:

Re: [PATCH] dw-mmc: prevent the Null pointer dereference for dma_ops

2012-04-18 Thread Will Newton
On Wed, Apr 18, 2012 at 7:42 AM, Jaehoon Chung wrote: > Now, dma_ops is assumed that use the IDMAC. > But if dma_ops is assigned the pdata->dma_ops, > We didn't ensure that callback function is defined. > > If anything of callback didn't define, then should be run the PIO mode. > > Signed-off-by:

Re: [PATCH 1/3] mmc: omap_hsmmc: release correct resource

2012-04-18 Thread Russell King - ARM Linux
On Wed, Apr 18, 2012 at 03:19:11PM +0530, Venkatraman S wrote: > From: Russell King - ARM Linux Please correct this to "Russell King " > > res can be one of several resources, as this variable is re-used several > times during probe. This can cause the wrong resource parameters to be > passed

[PATCH 3/3] mmc: omap_hsmmc: If probe fails, give out error messages

2012-04-18 Thread Venkatraman S
From: Rajendra Nayak Giving out debug messages even in case of probe failure seems not very useful. Make them error messages instead. Signed-off-by: Rajendra Nayak Signed-off-by: Venkatraman S Cc: Chris Ball Cc: --- drivers/mmc/host/omap_hsmmc.c |6 +++--- 1 file changed, 3 insertions(+

[PATCH 2/3] mmc: omap_hsmmc: Add fclk frequency to debufs

2012-04-18 Thread Venkatraman S
From: Viswanath Puttagunta Add mmc functional clock frequency to list of internal state variables to display for debug. Signed-off-by: Viswanath Puttagunta Signed-off-by: Venkatraman S --- drivers/mmc/host/omap_hsmmc.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH 1/3] mmc: omap_hsmmc: release correct resource

2012-04-18 Thread Venkatraman S
From: Russell King - ARM Linux res can be one of several resources, as this variable is re-used several times during probe. This can cause the wrong resource parameters to be passed to release_mem_region(). Get the original memory resource before calling release_mem_region(). Signed-off-by: Ru

Re: [PATCH v2] mmc: core: Fix the HPI execution sequence

2012-04-18 Thread S, Venkatraman
On Wed, Apr 18, 2012 at 1:53 PM, Namjae Jeon wrote: > 2012/4/18 S, Venkatraman : >> On Wed, Apr 18, 2012 at 10:15 AM, Namjae Jeon wrote: >>> 2012/4/18 Jaehoon Chung : On 04/18/2012 09:20 AM, Namjae Jeon wrote: > 2012/4/17 Venkatraman S : >> mmc_execute_hpi should send the HPI co

Re: [PATCH v2] mmc: core: Fix the HPI execution sequence

2012-04-18 Thread Namjae Jeon
2012/4/18 S, Venkatraman : > On Wed, Apr 18, 2012 at 10:15 AM, Namjae Jeon wrote: >> 2012/4/18 Jaehoon Chung : >>> On 04/18/2012 09:20 AM, Namjae Jeon wrote: >>> 2012/4/17 Venkatraman S : > mmc_execute_hpi should send the HPI command only > once, only if the card is in PRG state.

RE: [PATCH v1 1/1] mmc: block: replace __blk_end_request() with blk_end_request()

2012-04-18 Thread Subhash Jadavani
Hi Namjae, > -Original Message- > From: Namjae Jeon [mailto:linkinj...@gmail.com] > Sent: Wednesday, April 18, 2012 11:12 AM > To: Subhash Jadavani > Cc: Chris Ball; linux-mmc@vger.kernel.org; linux-arm-...@vger.kernel.org > Subject: Re: [PATCH v1 1/1] mmc: block: replace __blk_end_request