RE: [PATCH v6 2/3] mmc: core: Support packed write command for eMMC4.5 device

2012-05-31 Thread Seungwon Jeon
Maya Erez wrote: > > @@ -1313,10 +1609,17 @@ static int mmc_blk_issue_rw_rq(struct mmc_queue > *mq, struct request *rqc) > > * A block was successfully transferred. > > */ > > mmc_blk_reset_success(md, type); > > - spi

RE: [PATCH v6 2/3] mmc: core: Support packed write command for eMMC4.5 device

2012-05-31 Thread Seungwon Jeon
S, Venkatraman wrote: > On Thu, May 17, 2012 at 5:41 PM, Seungwon Jeon wrote: > > This patch supports packed write command of eMMC4.5 device. > > Several writes can be grouped in packed command and all data > > of the individual commands can be sent in a single transfer > > on the bus. > > > > Si

Re: [PATCH] mmc: core: fix wrong return value when suspend

2012-05-31 Thread Ulf Hansson
Hi Jaehoon, This make sense to me! Acked-by: Ulf Hansson Kind regards Ulf Hansson On 31 May 2012 19:31, Jaehoon Chung wrote: > When mmc_host is not spi mode, mmc/sd is doing mmc_deselect_cards(). > mmc_deselect_cards could be returned error. > If returned error, we can know something wrong wh

RE: [PATCH v6 1/3] mmc: core: Add packed command feature of eMMC4.5

2012-05-31 Thread merez
> > >> -Original Message- >> From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- >> ow...@vger.kernel.org] On Behalf Of me...@codeaurora.org >> Sent: Tuesday, May 29, 2012 5:08 PM >> To: Seungwon Jeon >> Cc: linux-mmc@vger.kernel.org; 'Chris Ball'; me...@codeaurora.org; >> linux- >> k

Re: [PATCH v6 2/3] mmc: core: Support packed write command for eMMC4.5 device

2012-05-31 Thread merez
> @@ -1313,10 +1609,17 @@ static int mmc_blk_issue_rw_rq(struct mmc_queue *mq, struct request *rqc) >* A block was successfully transferred. >*/ > mmc_blk_reset_success(md, type); > - spin_lock_irq(&md->lock);

Re: [PATCH 1/3] mmc: omap_hsmmc: Errata i705: SD hot unplug

2012-05-31 Thread Puttagunta, Viswanath
On Fri, May 25, 2012 at 1:37 AM, S, Venkatraman wrote: > > On Fri, May 25, 2012 at 1:44 AM, Viswanath Puttagunta > wrote: > > Turn off IO & PBIAS cells and then SD card VMMC as soon > > as we get disconnect interrupt. Failure to do so might > > cause current spikes (latch-up issue) which can pote

Re: [PATCH] MMC: core: cap MMC card timeouts at 2 seconds.

2012-05-31 Thread Ulf Hansson
Hi Richard, On 31 May 2012 18:15, Torne (Richard Coles) wrote: > On 31 May 2012 11:00, Ulf Hansson wrote: >> Hi Richard, >> >> On 29 May 2012 17:02, Torne (Richard Coles) wrote: >>> From: "Torne (Richard Coles)" >>> >>> MMC CSD info can specify very large, ridiculous timeouts, big enough to >>

[PATCH] mmc: core: fix wrong return value when suspend

2012-05-31 Thread Jaehoon Chung
When mmc_host is not spi mode, mmc/sd is doing mmc_deselect_cards(). mmc_deselect_cards could be returned error. If returned error, we can know something wrong when enter suspend. Signed-off-by: Jaehoon Chung Signed-off-by: Kyungmin Park --- drivers/mmc/core/mmc.c |2 +- drivers/mmc/core/sd

Re: [PATCH] MMC: core: cap MMC card timeouts at 2 seconds.

2012-05-31 Thread Torne (Richard Coles)
On 31 May 2012 11:00, Ulf Hansson wrote: > Hi Richard, > > On 29 May 2012 17:02, Torne (Richard Coles) wrote: >> From: "Torne (Richard Coles)" >> >> MMC CSD info can specify very large, ridiculous timeouts, big enough to >> overflow timeout_ns on 32-bit machines. This can result in the card >> t

Re: [PATCH] MMC: core: cap MMC card timeouts at 2 seconds.

2012-05-31 Thread Ulf Hansson
Hi Richard, On 29 May 2012 17:02, Torne (Richard Coles) wrote: > From: "Torne (Richard Coles)" > > MMC CSD info can specify very large, ridiculous timeouts, big enough to > overflow timeout_ns on 32-bit machines. This can result in the card > timing out on every operation because the wrapped tim

Re: [PATCH v6 2/3] mmc: core: Support packed write command for eMMC4.5 device

2012-05-31 Thread S, Venkatraman
On Thu, May 17, 2012 at 5:41 PM, Seungwon Jeon wrote: > This patch supports packed write command of eMMC4.5 device. > Several writes can be grouped in packed command and all data > of the individual commands can be sent in a single transfer > on the bus. > > Signed-off-by: Seungwon Jeon > --- >