Re: [PATCH 02/11] mmc: omap: add clk_prepare and clk_unprepare

2012-06-22 Thread Paul Walmsley
On Fri, 22 Jun 2012, S, Venkatraman wrote: > On Fri, Jun 22, 2012 at 7:18 PM, Rajendra Nayak wrote: > > In preparation of OMAP moving to Common Clk Framework(CCF) add clk_prepare() > > and clk_unprepare() for the mmc and hsmmc clocks as part of the drivers > > probe() and remove() routines. > > >

Re: [PATCH 02/11] mmc: omap: add clk_prepare and clk_unprepare

2012-06-22 Thread S, Venkatraman
On Fri, Jun 22, 2012 at 7:18 PM, Rajendra Nayak wrote: > In preparation of OMAP moving to Common Clk Framework(CCF) add clk_prepare() > and clk_unprepare() for the mmc and hsmmc clocks as part of the drivers > probe() and remove() routines. > > Signed-off-by: Rajendra Nayak > Cc: Chris Ball > Cc

Re: [RFC PATCH] Revert "mmc: omap_hsmmc: Enable Auto CMD12"

2012-06-22 Thread Chris Ball
Hi, On Fri, Jun 22 2012, T Krishnamoorthy, Balaji wrote: After bisecting, this commit dba3c29 is found to ruin micro-SD card data (writing incorrect file, or fs is corrupt after several times mount) on the beagle-xm revB, and reverting the commit will fix the problem. >>> >>> Hi Min

Re: [RFC PATCH] Revert "mmc: omap_hsmmc: Enable Auto CMD12"

2012-06-22 Thread Ming Lei
On Fri, Jun 22, 2012 at 11:13 PM, T Krishnamoorthy, Balaji wrote: > > I tested autocmd12 to be working on OMAP2,3,4 SDP. With beagle board > data corruption is observed with some cards, so it is going to be selectively > enabling/disabling for some SoCs via board data or DT until data corruption

Re: MMC: commit dba3c29 ruins mmc card data on beagle-xm revB

2012-06-22 Thread T Krishnamoorthy, Balaji
On Fri, Jun 22, 2012 at 5:21 PM, Paolo Pisati wrote: > On 06/20/2012 09:23 AM, T Krishnamoorthy, Balaji wrote: >>> >>> i just want to say that i'm affected by this too, and i can reproduce it >>> 100%. >>> >> >> Is it with SD or MMC card >> Can you provide Beagle board rev info? > > kingston 4g cl

Re: [RFC PATCH] Revert "mmc: omap_hsmmc: Enable Auto CMD12"

2012-06-22 Thread T Krishnamoorthy, Balaji
On Fri, Jun 22, 2012 at 6:25 PM, Chris Ball wrote: > Hi, > > On Fri, Jun 22 2012, T Krishnamoorthy, Balaji wrote: >> On Fri, Jun 22, 2012 at 4:19 PM, Ming Lei wrote: >>> This patch reverts the commit dba3c29ea4a1d5d544. >>> >>> After bisecting, this commit dba3c29 is found to ruin micro-SD card d

RE: [PATCH 2/3] ext4: Context support

2012-06-22 Thread Luca Porzio (lporzio)
Hallo, > -Original Message- > From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc-ow...@vger.kernel.org] > On Behalf Of Artem Bityutskiy > Sent: Friday, June 22, 2012 3:29 PM > To: Arnd Bergmann > Cc: Ted Ts'o; Alex Lemberg; HYOJIN JEONG; Saugata Das; Saugata Das; linux- > e...@vger.ke

[PATCH 02/11] mmc: omap: add clk_prepare and clk_unprepare

2012-06-22 Thread Rajendra Nayak
In preparation of OMAP moving to Common Clk Framework(CCF) add clk_prepare() and clk_unprepare() for the mmc and hsmmc clocks as part of the drivers probe() and remove() routines. Signed-off-by: Rajendra Nayak Cc: Chris Ball Cc: Balaji T K Cc: --- drivers/mmc/host/omap.c |9 ++--

RE: [PATCH v5] mmc: core: Fix the HPI execution sequence

2012-06-22 Thread Subhash Jadavani
Thanks Venkatraman. Looks good to me. Reviewed-by: Subhash Jadavani Regards, Subhash > -Original Message- > From: Venkatraman S [mailto:svenk...@ti.com] > Sent: Friday, June 22, 2012 11:43 AM > To: c...@laptop.org > Cc: linux-mmc@vger.kernel.org; linkinj...@gmail.com; > jh80.ch...@samsun

Re: [PATCH 2/3] ext4: Context support

2012-06-22 Thread Artem Bityutskiy
On Wed, 2012-06-13 at 19:44 +, Arnd Bergmann wrote: > I think using the inode number is a reasonable fit. Using the > inode number of the parent directory might be more appropriate > but it breaks with hard links and cross-directory renames (we > must not use the same LBA with conflicting conte

[PATCH 1/9 v4] mmc: extend and rename cd-gpio helpers to handle more slot GPIO functions

2012-06-22 Thread Guennadi Liakhovetski
GPIOs can be used in MMC/SD-card slots not only for hotplug detection, but also to implement the write-protection pin. Rename cd-gpio helpers to slot-gpio to make addition of further slot GPIO functions possible. Signed-off-by: Guennadi Liakhovetski --- drivers/mmc/core/Makefile

[PATCH 9/9 v4] mmc: tmio: use generic GPIO CD and WP handlers

2012-06-22 Thread Guennadi Liakhovetski
The tmio-mmc driver is already using the generic GPIO CD handler in IRQ mode. This patch adds support for CD polling mode and also checks for availability of a WP GPIO. Signed-off-by: Guennadi Liakhovetski --- drivers/mmc/host/tmio_mmc_pio.c |6 ++ 1 files changed, 6 insertions(+), 0 del

[PATCH 0/9 v4] mmc: cd-gpio: extend to handle more slot functions

2012-06-22 Thread Guennadi Liakhovetski
This patch series extends the cd-gpio helper module to handle further common slot functions, often implemented using GPIOs: CD polling and WP. It supersedes patches 1-8 and 10/10 from http://thread.gmane.org/gmane.linux.kernel.mmc/14624/focus=14644 Patch 9/10 from it is not needed any more, bec

[PATCH 2/9 v4] mmc: use a more generic name for slot function types and fields

2012-06-22 Thread Guennadi Liakhovetski
struct mmc_host::hotplug is becoming a generic hook for slot functions. Rename it accordingly. Signed-off-by: Guennadi Liakhovetski --- drivers/mmc/core/host.c |2 ++ drivers/mmc/core/slot-gpio.c |8 include/linux/mmc/host.h | 17 ++--- 3 files changed, 20

[PATCH 6/9 v4] mmc: add WP pin handler to slot functions

2012-06-22 Thread Guennadi Liakhovetski
Card Write-Protect pin is often implemented, using a GPIO, which makes it simple to provide a generic handler for it. Signed-off-by: Guennadi Liakhovetski --- v4: 1. gpio variables are now signed 2. take care to mark gpio variables as invalid in hotplug context 3. MMC_CAP2_*_ACTIVE_HIGH inverte

[PATCH 4/9 v4] mmc: add CD GPIO polling support to slot functions

2012-06-22 Thread Guennadi Liakhovetski
A simple extension of mmc slot functions add support for CD GPIO polling for cases, where the GPIO cannot produce interrupts or this is for some reason not desired. Signed-off-by: Guennadi Liakhovetski --- v4: 1. gpio variables are now signed 2. take care to mark gpio variables as invalid in ho

[PATCH 7/9 v4] mmc: tmio: support caps2 flags

2012-06-22 Thread Guennadi Liakhovetski
Allow tmio mmc glue drivers pass mmc_host::caps2 flags down to the mmc layer. Signed-off-by: Guennadi Liakhovetski --- drivers/mmc/host/tmio_mmc_pio.c |1 + include/linux/mfd/tmio.h|1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/mmc/host/tmio_mmc_pio.

[PATCH 8/9 v4] mmc: sh_mobile_sdhi: support caps2 flags

2012-06-22 Thread Guennadi Liakhovetski
Let SDHI platforms specify mmc_host::caps2 flags in their platform data. Signed-off-by: Guennadi Liakhovetski --- drivers/mmc/host/sh_mobile_sdhi.c |1 + include/linux/mmc/sh_mobile_sdhi.h |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/mmc/host/sh_mobile_sd

[PATCH 3/9 v4] mmc: add two capability flags for CD and WP signal polarity

2012-06-22 Thread Guennadi Liakhovetski
To handle CD and WP SD/MMC slot pins we need generic flags to specify their polarity. Signed-off-by: Guennadi Liakhovetski --- v4: 1. MMC_CAP2_*_ACTIVE_HIGH inverted compared to v3 include/linux/mmc/host.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/linux

[PATCH 5/9 v4] mmc: convert slot functions to managed allocation

2012-06-22 Thread Guennadi Liakhovetski
This prepares for the addition of further slot functions. Signed-off-by: Guennadi Liakhovetski --- v4: 1. gpio variables are now signed 2. take care to mark gpio variables as invalid in hotplug context 3. MMC_CAP2_*_ACTIVE_HIGH inverted compared to v3 drivers/mmc/core/host.c |2 + dr

Re: [RFC PATCH] Revert "mmc: omap_hsmmc: Enable Auto CMD12"

2012-06-22 Thread Ming Lei
On Fri, Jun 22, 2012 at 8:29 PM, T Krishnamoorthy, Balaji wrote: > Hi Ming, > Rather than reverting the entire commit, > Can you try with the below change alone, so that AutoCMD12 can be easily > enabled back when needed. I don't think it is a good practice to just revert it partially. I'd like

Re: [RFC PATCH] Revert "mmc: omap_hsmmc: Enable Auto CMD12"

2012-06-22 Thread Chris Ball
Hi, On Fri, Jun 22 2012, T Krishnamoorthy, Balaji wrote: > On Fri, Jun 22, 2012 at 4:19 PM, Ming Lei wrote: >> This patch reverts the commit dba3c29ea4a1d5d544. >> >> After bisecting, this commit dba3c29 is found to ruin micro-SD card data >> (writing incorrect file, or fs is corrupt after severa

Re: [RFC PATCH] Revert "mmc: omap_hsmmc: Enable Auto CMD12"

2012-06-22 Thread T Krishnamoorthy, Balaji
On Fri, Jun 22, 2012 at 4:19 PM, Ming Lei wrote: > This patch reverts the commit dba3c29ea4a1d5d544. > > After bisecting, this commit dba3c29 is found to ruin micro-SD card data > (writing incorrect file, or fs is corrupt after several times mount) > on the beagle-xm revB, and reverting the commit

Re: MMC: commit dba3c29 ruins mmc card data on beagle-xm revB

2012-06-22 Thread Paolo Pisati
On 06/20/2012 09:23 AM, T Krishnamoorthy, Balaji wrote: >> >> i just want to say that i'm affected by this too, and i can reproduce it >> 100%. >> > > Is it with SD or MMC card > Can you provide Beagle board rev info? kingston 4g class 4 sdhc c04g taiwan tested on a beagle xm rev a and rev c, bo

Re: [RFC PATCH] Revert "mmc: omap_hsmmc: Enable Auto CMD12"

2012-06-22 Thread S, Venkatraman
On Fri, Jun 22, 2012 at 4:19 PM, Ming Lei wrote: > This patch reverts the commit dba3c29ea4a1d5d544. > > After bisecting, this commit dba3c29 is found to ruin micro-SD card data > (writing incorrect file, or fs is corrupt after several times mount) > on the beagle-xm revB, and reverting the commit

[RFC PATCH] Revert "mmc: omap_hsmmc: Enable Auto CMD12"

2012-06-22 Thread Ming Lei
This patch reverts the commit dba3c29ea4a1d5d544. After bisecting, this commit dba3c29 is found to ruin micro-SD card data (writing incorrect file, or fs is corrupt after several times mount) on the beagle-xm revB, and reverting the commit will fix the problem. Also from TRM of OMAP3/OMAP4/DM37x,