[PATCH 2/2] mmc: sd: Fix sd current limit setting

2012-07-02 Thread Aaron Lu
Host has different current capabilities at different voltages, we need to record these settings seperately. Before set current limit for the sd card, find out the current voltage first and then find out the current capabilities of the host to set the limit. Signed-off-by: Aaron Lu --- drivers/mm

[PATCH 1/2] mmc: core: Simplify and fix for SD switch processing

2012-07-02 Thread Aaron Lu
In mmc_read_switch, just do a one time mode 0 switch command to get the support bits information, no need to do multiple times as the support bits do not change with different arguments. And no need to check current limit support bits, as these bits is fixed according to the signal voltage. If the

[PATCH 0/2] SD current limit setting fix

2012-07-02 Thread Aaron Lu
The following 2 patches fix setting of SD current limit Aaron Lu (2): mmc: core: Simplify and fix for SD switch processing mmc: sd: Fix sd current limit setting drivers/mmc/core/sd.c| 144 +++ drivers/mmc/host/sdhci.c | 28 +++-- include/l

Re: [PATCH 2/2] mmc: only support voltage (vdd) that regulator agree's with

2012-07-02 Thread Chris Ball
Hi Aaron, On Tue, Jul 03 2012, Aaron Lu wrote: > On Fri, Jun 29, 2012 at 07:19:19PM -0400, Chris Ball wrote: >> Hi, >> >> On Fri, Jun 08 2012, philipspatc...@gmail.com wrote: >> > From: Philip Rakity >> > >> > If we are using a regulator the SD Host Controller and the >> > regulator should agree

Re: [PATCH 2/2] mmc: only support voltage (vdd) that regulator agree's with

2012-07-02 Thread Aaron Lu
Hi Chris, On Fri, Jun 29, 2012 at 07:19:19PM -0400, Chris Ball wrote: > Hi, > > On Fri, Jun 08 2012, philipspatc...@gmail.com wrote: > > From: Philip Rakity > > > > If we are using a regulator the SD Host Controller and the > > regulator should agree about the voltages supported. Use > > the co

Re: Re: [PATCH] mmc: core: Revert "skip card initialization if powerclass selection fails"

2012-07-02 Thread Girish K S
On 2 July 2012 16:50, Marc Dietrich wrote: > Am Montag, 2. Juli 2012, 14:28:37 schrieb Girish K S: >> On 2 July 2012 14:23, Girish K S wrote: >> > On 2 July 2012 14:13, Saugata Das wrote: >> >> On 2 July 2012 12:26, Venkatraman S wrote: >> >>> This reverts commit 3d93576e(skip card initializati

Re: [PATCH] mmc: correct invalid error checking

2012-07-02 Thread Chris Ball
Hi, On Mon, Jul 02 2012, Alan Cox wrote: > From: Alan Cox > > The effect of the existing code is that we continue blindly when we should > warn about an invalid allocation unit > > Reported-by: dcb...@hotmail.com > Resolves-bug: https://bugzilla.kernel.org/show_bug.cgi?id=44061 > Signed-off-by: A

Re: mmci.c regression

2012-07-02 Thread Roland Stigge
On 07/02/2012 03:07 PM, Russell King - ARM Linux wrote: > On Mon, Jul 02, 2012 at 02:14:26PM +0200, Roland Stigge wrote: >> Hi, >> >> I'm getting a strange regression with mmci.c at v3.5-rc4 -> v3.5-rc5: Bootup: >>[...] > > Nothing changed with the mmci driver between these two, but there is this

Re: [PATCH] mmc: core: Revert "skip card initialization if powerclass selection fails"

2012-07-02 Thread Saugata Das
On 2 July 2012 16:47, Marc Dietrich wrote: > Am Montag, 2. Juli 2012, 14:13:31 schrieb Saugata Das: >> On 2 July 2012 12:26, Venkatraman S wrote: >> > This reverts commit 3d93576e(skip card initialization if >> > power class selection fails). >> > Problem has been reported when this is used with

[PATCH] mmc: Report failure reasons for all cases in sdhci_add_host()

2012-07-02 Thread Mark Brown
For most error conditions sdhci_add_host() will print a diagnostic message indicating why it failed but there are a few cases where this does not happen. Add error messages in these cases to aid diagnosis. Signed-off-by: Mark Brown --- drivers/mmc/host/sdhci.c | 10 -- 1 file changed,

Re: mmci.c regression

2012-07-02 Thread Russell King - ARM Linux
On Mon, Jul 02, 2012 at 02:14:26PM +0200, Roland Stigge wrote: > Hi, > > I'm getting a strange regression with mmci.c at v3.5-rc4 -> v3.5-rc5: Bootup: > > v3.5-rc4: > > mmci-pl18x 20098000.sd: mmc0: PL180 manf 41 rev0 at 0x20098000 irq 15,13 (pio) > mmci-pl18x 20098000.sd: no DMA platform data >

[PATCH v4 2/2] mmc: block: Add write packing control

2012-07-02 Thread Maya Erez
The write packing control will ensure that read requests latency is not increased due to long write packed commands. The trigger for enabling the write packing is managing to pack several write requests. The number of potential packed requests that will trigger the packing can be configured via sy

[PATCH v4 1/2] mmc: card: Move MMC specific attributes to mmc sub-directory

2012-07-02 Thread Maya Erez
Separate MMC specific attributes from general block device attributes and move them from the /sys/block/ directory to /sys/block//mmc directory Signed-off-by: Maya Erez diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c index c965f2b..c23034d 100644 --- a/drivers/mmc/card/block.c +

[PATCH v4 0/1] mmc: block: Add write packing control

2012-07-02 Thread Maya Erez
Our experiments showed that the write packing causes degradation of the read throughput, in parallel read and write operations. Since the read latency is critical for user experience we added a write packing control mechanism that disables the write packing in case of read requests. This will ensu

mmci.c regression

2012-07-02 Thread Roland Stigge
Hi, I'm getting a strange regression with mmci.c at v3.5-rc4 -> v3.5-rc5: Bootup: v3.5-rc4: mmci-pl18x 20098000.sd: mmc0: PL180 manf 41 rev0 at 0x20098000 irq 15,13 (pio) mmci-pl18x 20098000.sd: no DMA platform data mmc0: new SD card at address bd34 mmcblk0: mmc0:bd34 SD02G 1.83 GiB mmcblk0: er

Re: Re: [PATCH] mmc: core: Revert "skip card initialization if powerclass selection fails"

2012-07-02 Thread Marc Dietrich
Am Montag, 2. Juli 2012, 14:28:37 schrieb Girish K S: > On 2 July 2012 14:23, Girish K S wrote: > > On 2 July 2012 14:13, Saugata Das wrote: > >> On 2 July 2012 12:26, Venkatraman S wrote: > >>> This reverts commit 3d93576e(skip card initialization if > >>> power class selection fails). > >>> Pr

Re: [PATCH] mmc: core: Revert "skip card initialization if powerclass selection fails"

2012-07-02 Thread Marc Dietrich
Am Montag, 2. Juli 2012, 14:13:31 schrieb Saugata Das: > On 2 July 2012 12:26, Venkatraman S wrote: > > This reverts commit 3d93576e(skip card initialization if > > power class selection fails). > > Problem has been reported when this is used with eMMC4.41 > > card with Tegra Platform. Till the is

Re: [PATCH] mmc: core: Revert "skip card initialization if power class selection fails"

2012-07-02 Thread Girish K S
On 2 July 2012 14:23, Girish K S wrote: > On 2 July 2012 14:13, Saugata Das wrote: >> On 2 July 2012 12:26, Venkatraman S wrote: >>> This reverts commit 3d93576e(skip card initialization if >>> power class selection fails). >>> Problem has been reported when this is used with eMMC4.41 >>> card w

Re: [PATCH] mmc: core: Revert "skip card initialization if power class selection fails"

2012-07-02 Thread Girish K S
On 2 July 2012 14:13, Saugata Das wrote: > On 2 July 2012 12:26, Venkatraman S wrote: >> This reverts commit 3d93576e(skip card initialization if >> power class selection fails). >> Problem has been reported when this is used with eMMC4.41 >> card with Tegra Platform. Till the issue is root cause

Re: [PATCH] mmc: core: Revert "skip card initialization if power class selection fails"

2012-07-02 Thread Saugata Das
On 2 July 2012 12:26, Venkatraman S wrote: > This reverts commit 3d93576e(skip card initialization if > power class selection fails). > Problem has been reported when this is used with eMMC4.41 > card with Tegra Platform. Till the issue is root caused, > bus width selection failure should not be t

Re: [PATCH] mmc: always save error codes in mmc_regulator_get_supply()

2012-07-02 Thread Guennadi Liakhovetski
Hi On Mon, 2 Jul 2012, Pankaj Jangra wrote: > Hi, > > On Wed, Jun 27, 2012 at 8:48 PM, Guennadi Liakhovetski > wrote: > > If mmc_regulator_get_supply() fails to obtain any of the regulators, store > > the error codes in struct mmc_host to unify error reporting to the host > > driver. > > > > Si