[PATCH 2/2] drivers/mmc: Add realtek pcie sdmmc host driver

2012-08-13 Thread wei_wang
From: Wei WANG Realtek PCI-E SD/MMC card host driver is used to access SD/MMC card, with the help of Realtek PCI-E card reader MFD driver. Signed-off-by: Wei WANG --- drivers/mmc/host/Kconfig |7 + drivers/mmc/host/Makefile |2 + drivers/mmc/host/rtsx_pci_sdmmc.c | 134

Re: [PATCH v2] mmc: card: Skip secure option for MoviNAND.

2012-08-13 Thread Kyungmin Park
and also you should update "MMC_QUIRK_MOVINAND_SECURE" also. On 8/14/12, Kyungmin Park wrote: > Hi Ian, > > "MMC_QUIRK_SKIP_SECURE"? It seems it support secure discard but want > to skip. but it's wrong. it's broken feature at listed MoviNAND. > As linus suggested, SECURE_BROKEN is better. > > Th

Re: [PATCH v2] mmc: card: Skip secure option for MoviNAND.

2012-08-13 Thread Kyungmin Park
Hi Ian, "MMC_QUIRK_SKIP_SECURE"? It seems it support secure discard but want to skip. but it's wrong. it's broken feature at listed MoviNAND. As linus suggested, SECURE_BROKEN is better. Thank you, Kyungmin Park On 8/14/12, IAN CHEN wrote: > For several MoviNAND, there are some known issue with

[PATCH v2] mmc: card: Skip secure option for MoviNAND.

2012-08-13 Thread IAN CHEN
For several MoviNAND, there are some known issue with secure option. For these specific MoviNAND device, we skip secure option. Signed-off-by: Ian Chen --- drivers/mmc/card/block.c | 24 +++- include/linux/mmc/card.h |1 + 2 files changed, 24 insertions(+), 1 deletions(

Re: [PATCH] mmc: card: Skip secure option for MoviNAND.

2012-08-13 Thread Namjae Jeon
Hi. Ian. Okay, I see. plz add this address in changelog. I also agree about Linus's suggestion. So Would you change flag name to be neutral ? We can distinguish samsung movinand by CID_MANFID_SAMSUNG. And will reuse quirk flag when same issue occurred from other vendor's mmc deivce. Thanks. 201

RE: [PATCH] mmc: card: Skip secure option for MoviNAND.

2012-08-13 Thread IAN CHEN
Dear Mr. Jeon, This is workaround for some Samsung eMMC, MoviNAND. There are known issue about secure erase & secure trim with these eMMC device which I listed by product_name. Therefore, for these eMMC devices, we just skip mmc_blk_issue_secdiscard_rq() and use mmc_blk_issue_discard_rq() instea

RE: [PATCH] mmc: card: Skip secure option for MoviNAND.

2012-08-13 Thread IAN CHEN
Dear Mr. Jeon, This is workaround for some Samsung eMMC, MoviNAND. There are known issue about secure erase & secure trim with these eMMC device which I listed by product_name. Therefore, for these eMMC devices, we just skip mmc_blk_issue_secdiscard_rq() and use mmc_blk_issue_discard_rq() instea

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-08-13 Thread Maxim Levitsky
On Wed, 2012-08-01 at 14:31 +, Arnd Bergmann wrote: > On Wednesday 01 August 2012, wwang wrote: > > 于 2012年07月31日 19:23, Arnd Bergmann 写道: > > > > > > You posted the sdmmc host driver and the pci card reader driver. > > > I assume that the USB card reader and the memstick host > > > will also

[PATCH] mmc: Adjust timings for power ramping up

2012-08-13 Thread Dmitry Rozhkov
According to p6.4.1.1 of the Physical Layer Simplified Specification Ver3.01 the "host needs to keep power line level less than 0.5V and more than 1ms before power ramp up". This patch adds an explicit delay of 10ms just before power rump up. Without this patch some microSD cards (e.g. Kingston 8G

Re: [PATCH] mmc: card: Skip secure option for MoviNAND.

2012-08-13 Thread Linus Walleij
On Mon, Aug 13, 2012 at 11:50 AM, IAN CHEN wrote: > For several MoviNAND, there are some known issue with secure option. > For these specific MoviNAND device, we skip secure option. OK.. > diff --git a/include/linux/mmc/card.h b/include/linux/mmc/card.h > index 111aca5..4505a30 100644 > --- a/i

Re: [PATCH 2/2] drivers/mmc: Add realtek pcie sdmmc host driver

2012-08-13 Thread Arnd Bergmann
On Monday 13 August 2012, wei_w...@realsil.com.cn wrote: > From: Wei WANG > > Realtek PCI-E SD/MMC card host driver is used to access SD/MMC card, > with the help of Realtek PCI-E card reader MFD driver. > > Signed-off-by: Wei WANG Acked-by: Arnd Bergmann -- To unsubscribe from this list: sen

Re: [PATCH 1/2] drivers/mfd: Add realtek pcie card reader driver

2012-08-13 Thread Arnd Bergmann
On Monday 13 August 2012, wei_w...@realsil.com.cn wrote: > From: Wei WANG > > Realtek PCI-E card reader driver adapts requests from upper-level > sdmmc/memstick layer to the real physical card reader. > > Signed-off-by: Wei WANG Hi, This looks pretty good overall, I'm generally happy with how

Re: [PATCH] mmc: card: Skip secure option for MoviNAND.

2012-08-13 Thread Namjae Jeon
Hi. Ian. known issue ? Would you explain more ? Thanks. 2012/8/13 IAN CHEN : > From 5c60eb8be04c7440d6e33b8f72ea2046a3657ac4 Mon Sep 17 00:00:00 2001 > From: ian.cy.chen > Date: Mon, 13 Aug 2012 10:53:55 +0900 > Subject: [PATCH] mmc: card: Skip secure option for MoviNAND. > > For several MoviNA

[PATCH] mmc: card: Skip secure option for MoviNAND.

2012-08-13 Thread IAN CHEN
>From 5c60eb8be04c7440d6e33b8f72ea2046a3657ac4 Mon Sep 17 00:00:00 2001 From: ian.cy.chen Date: Mon, 13 Aug 2012 10:53:55 +0900 Subject: [PATCH] mmc: card: Skip secure option for MoviNAND. For several MoviNAND, there are some known issue with secure option. For these specific MoviNAND device, we

Re: [PATCH 1/2] drivers/mfd: Add realtek pcie card reader driver

2012-08-13 Thread Dan Carpenter
On Mon, Aug 13, 2012 at 03:10:50PM +0800, wwang wrote: > 于 2012年08月13日 14:40, Dan Carpenter 写道: > > Looks like bitwise OR was intended here. > Hi Dan: > > Thank you. I will resend the patches. > It's always best to hold off a day on resending, in case there are other comments. regards, dan carp

Re: [PATCH 1/2] drivers/mfd: Add realtek pcie card reader driver

2012-08-13 Thread wwang
于 2012年08月13日 14:40, Dan Carpenter 写道: > Looks like bitwise OR was intended here. Hi Dan: Thank you. I will resend the patches. BR, wwang -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vg