Re: [PATCH] Add MSI support for SDHCI PCI hosts

2012-08-17 Thread Daniel J Blueman
Hi Philip, The interrupt could be from another source, though Message Signalled Interrupts are a PCI (and variants) only feature at present. I'm happy to split the patch and/or make the module param specific to sdhci-pci. Let's see what the maintainers prefer...Chris? Dan On 18 August 2012 00:3

Re: [PATCH] mmc: tegra: convert to device tree support only

2012-08-17 Thread Stephen Warren
On 08/17/2012 01:04 AM, Joseph Lo wrote: > When compiling a kernel that supports only Tegra30 and not Tegra20, > the SDHCI driver will fail to compile since the of_match_device() failure > fallback code unconditinally references soc_data_tegra20, which is only > compiled in when Tegra20 support is

[PATCH 09/10] mmc: omap_hsmmc: convert from IP timer to hrtimer

2012-08-17 Thread Venkatraman S
omap hsmmc controller IP has an inbuilt timer that can be programmed to guard against unresponsive operations. But it's range is very narrow, and it's maximum countable time is a few seconds. Card maintenance operations like BKOPS and SECURE DISCARD and long stream writes like packed command requi

[PATCH 10/10] mmc: omap_hsmmc: Move to Maintained state in MAINTAINERS

2012-08-17 Thread Venkatraman S
I can continue to look after this driver. Signed-off-by: Venkatraman S --- MAINTAINERS | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 72c2681..75e3c3e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4933,8 +4933,10 @@ S: Maintained F:

[PATCH 08/10] mmc: omap_hsmmc: consolidate error report handling of HSMMC IRQ

2012-08-17 Thread Venkatraman S
Consolidate the duplicated code around the handling of CMD_TIMEOUT, CMD_CRC, DATA_TIMEOUT, DATA_CRC and CARD_ERR handling into a single function. This generally shrinks code bloat, but is also required for implementing software based guard timers. Signed-off-by: Venkatraman S --- drivers/mmc/hos

[PATCH 07/10] mmc: omap_hsmmc: consolidate flush posted writes for HSMMC IRQs

2012-08-17 Thread Venkatraman S
Flushing spurious IRQs from HSMMC IP is done twice in omap_hsmmc_irq and omap_hsmmc_do_irq. Consolidate them to one location. Signed-off-by: Venkatraman S --- drivers/mmc/host/omap_hsmmc.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/drivers/mmc/host/oma

[PATCH 06/10] mmc: omap_hsmmc: remove access to SYSCONFIG register

2012-08-17 Thread Venkatraman S
SYSCONFIG register of HSMMC IP is managed by the omap hwmod abstraction layer. Resetting the IP and configuring the correct SYSCONFIG mode is centrally managed by hwmod. Remove code which manipulates IP reset and SYSCONFIG directly in the driver. Signed-off-by: Venkatraman S --- drivers/mmc/hos

[PATCH 05/10] mmc: omap_hsmmc: remove unused vars and includes

2012-08-17 Thread Venkatraman S
Some straight forward cleanup of unnecessary #include's and host variables. Some of the verbose and redundant debug messages are converted to use dev_vdbg. Signed-off-by: Venkatraman S --- drivers/mmc/host/omap_hsmmc.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff -

[PATCH 04/10] mmc: omap: fix mmc_omap_report_irq to use dev_dbg macros

2012-08-17 Thread Venkatraman S
The function mmc_omap_report_irq uses raw printks and the actual output was disabled by a static variable. Make the function use dev_vdbg macro and use it under the standard CONFIG_MMC_DEBUG flag. Signed-off-by: Venkatraman S --- drivers/mmc/host/omap.c | 29 + 1 file

[PATCH 03/10] mmc: omap: remove unused variables and includes

2012-08-17 Thread Venkatraman S
Get rid of some unnecessary includes in the driver and a few unused variables. Signed-off-by: Venkatraman S --- drivers/mmc/host/omap.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c index 50e08f0..0ec4e55 100644 --- a/drivers/mmc

[PATCH 02/10] mmc: debugfs: Print ext_csd in ascending order

2012-08-17 Thread Venkatraman S
ext_csd exported through debugfs is printed in reverse order (from byte 511 to 0), which causes confusion. Fix the for loop to print ext_csd in natural order. Signed-off-by: Venkatraman S --- drivers/mmc/core/debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/m

[PATCH 01/10] mmc: core: Add TRANsfer state to non-HPI state

2012-08-17 Thread Venkatraman S
HPI can be issued only in programming state to bring the card to transfer state. If the card is already in transfer state, doing a HPI is redundant. Fix this by adding transfer state to the list of exceptions to doing HPI and return without error. Signed-off-by: Venkatraman S --- drivers/mmc/cor

[PATCH 00/10] Assorted MMC / OMAP HSMMC patches

2012-08-17 Thread Venkatraman S
Essentially, a lot of cleanups leading up to adding a new feature for OMAP HSMMC. The idea is to convert to the use of software timer instead of IP timer for timekeeping, due to the limitations of the counting range of the IP timer. Also added myself as OMAP HSMMC maintainer. Patch 9/10 is in dra

Re: [PATCH] omap-hsmmc: Implementation of i761 errata

2012-08-17 Thread Puttagunta, Viswanath
On Fri, Aug 17, 2012 at 12:28 PM, S, Venkatraman wrote: > On Fri, Aug 17, 2012 at 9:35 PM, Semen Protsenko > wrote: >> Errata description: >> Due to a bad behavior of an internal signal, the Card Error interrupt bit >> MMCHS_STAT[28] CERR may not be set sometimes when an error occurred in the >>

Re: [PATCH] omap-hsmmc: Implementation of i761 errata

2012-08-17 Thread S, Venkatraman
On Fri, Aug 17, 2012 at 9:35 PM, Semen Protsenko wrote: > Errata description: > Due to a bad behavior of an internal signal, the Card Error interrupt bit > MMCHS_STAT[28] CERR may not be set sometimes when an error occurred in the > card response. > > Workaround: > After responses of type R1/R1b f

Re: [PATCH] Add MSI support for SDHCI PCI hosts

2012-08-17 Thread Philip Rakity
The interrupt source could be from a non-pci device. Say a gpio or whatever. Does it make sense to break this patch into two patches ? On Aug 17, 2012, at 2:14 AM, Daniel J Blueman wrote: > Allow module parameter 'enable_msi' to request an MSI interrupt for > hosts where available (presently

[PATCH] Add MSI support for SDHCI PCI hosts

2012-08-17 Thread Daniel J Blueman
Allow module parameter 'enable_msi' to request an MSI interrupt for hosts where available (presently PCI). Useful as a workaround on platforms where the legacy interrupt is broken. Signed-off-by: Daniel J Blueman --- drivers/mmc/host/sdhci-pci.c | 30 ++ drivers/mmc

Re: [PATCH] mmc: sdhci-s3c: Add device tree support

2012-08-17 Thread Heiko Stübner
Hi Thomas, Am Donnerstag, 16. August 2012, 17:49:29 schrieb Thomas Abraham: > Add device tree based discovery support for Samsung's sdhci controller > > Cc: Ben Dooks > Cc: Kukjin Kim > Cc: Chris Ball > Signed-off-by: Thomas Abraham > --- > drivers/mmc/host/sdhci-s3c.c | 146 > +

[PATCH v5] mmc: card: Skip secure option for MoviNAND.

2012-08-17 Thread IAN CHEN
For several MoviNAND, there are some known issue with secure option. For these specific MoviNAND device, we skip secure option. You could refer this discussion in XDA developers. http://forum.xda-developers.com/showthread.php?t=1644364 https://plus.google.com/111398485184813224730/posts/21pTYfTsCk

[PATCH] mmc: tegra: convert to device tree support only

2012-08-17 Thread Joseph Lo
When compiling a kernel that supports only Tegra30 and not Tegra20, the SDHCI driver will fail to compile since the of_match_device() failure fallback code unconditinally references soc_data_tegra20, which is only compiled in when Tegra20 support is enabled. In Kernel 3.7, both Tegra20 and Tegra30