[PATCH] sdhci: put regulator if probe fails

2012-10-12 Thread Thadeu Lima de Souza Cascardo
When using the dummy regulator, SDHCI may fail its probing because the regulator does not support any voltages. When reloading the driver, you will get a warning about a duplicate sysfs link. [72211.963386] :03:00.0 supply vmmc not found, using dummy regulator [72211.963409] [ cut

Re: [PATCH 1/4] MMC: omap_hsmmc: set platform data after probe from DT node

2012-10-12 Thread Grant Likely
Balaji T K wrote: >On Friday 12 October 2012 08:44 PM, Daniel Mack wrote: >> On 12.10.2012 16:56, Balaji T K wrote: >>> On Friday 12 October 2012 07:59 PM, Daniel Mack wrote: On 12.10.2012 12:58, Daniel Mack wrote: > diff --git a/drivers/mmc/host/omap_hsmmc.c >b/drivers/mmc/host/omap_h

Re: [PATCH] mmc: mmci: Fixup and cleanup code for DMA handling

2012-10-12 Thread Linus Walleij
On Fri, Oct 12, 2012 at 5:33 PM, Ulf Hansson wrote: > From: Ulf Hansson > > The cookie is now used to indicate if dma_unmap_sg shall be > done in post_request. At DMA errors, the DMA job is immediately > not only terminated but also unmapped. To indicate that this > has been done the cookie is r

Re: [PATCH] mmc: mmci: Support non-power-of-two block sizes for ux500v2 variant

2012-10-12 Thread Linus Walleij
On Fri, Oct 12, 2012 at 4:02 PM, Ulf Hansson wrote: > From: Ulf Hansson > > For the ux500v2 variant non power of two block sizes are supported. > This will make it possible to decrease data overhead for SDIO > transfers. Although we need to put some constraints to the alignment > of the buffers

[PATCH] mmc: mmci: Fixup and cleanup code for DMA handling

2012-10-12 Thread Ulf Hansson
From: Ulf Hansson The cookie is now used to indicate if dma_unmap_sg shall be done in post_request. At DMA errors, the DMA job is immediately not only terminated but also unmapped. To indicate that this has been done the cookie is reset to zero. post_request will thus only do dma_umap_sg for requ

Re: [PATCH 4/4] MMC: omap_hsmmc: add DT property for max bus frequency

2012-10-12 Thread Daniel Mack
On 12.10.2012 17:25, Rob Herring wrote: > On 10/12/2012 05:58 AM, Daniel Mack wrote: >> Maximum bus frequency can be limited by external circuitry like level >> shifters etc. Allow passing this value from DT. >> >> Signed-off-by: Daniel Mack >> Cc: Venkatraman S >> Cc: Chris Ball >> Cc: Grant Li

Re: [PATCH 4/4] MMC: omap_hsmmc: add DT property for max bus frequency

2012-10-12 Thread Rob Herring
On 10/12/2012 05:58 AM, Daniel Mack wrote: > Maximum bus frequency can be limited by external circuitry like level > shifters etc. Allow passing this value from DT. > > Signed-off-by: Daniel Mack > Cc: Venkatraman S > Cc: Chris Ball > Cc: Grant Likely > Cc: Rob Herring > Cc: linux-o...@vger.k

Re: [PATCH 1/4] MMC: omap_hsmmc: set platform data after probe from DT node

2012-10-12 Thread Balaji T K
On Friday 12 October 2012 08:44 PM, Daniel Mack wrote: On 12.10.2012 16:56, Balaji T K wrote: On Friday 12 October 2012 07:59 PM, Daniel Mack wrote: On 12.10.2012 12:58, Daniel Mack wrote: diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 19ccb59..4b70823 100644

Re: [PATCH 1/4] MMC: omap_hsmmc: set platform data after probe from DT node

2012-10-12 Thread Daniel Mack
On 12.10.2012 16:56, Balaji T K wrote: > On Friday 12 October 2012 07:59 PM, Daniel Mack wrote: >> On 12.10.2012 12:58, Daniel Mack wrote: >>> When probed from DT, the self-allocated platform data has to be attached >>> to the actual device. Otherwise a NULL pointer will be dereferenced from >>> om

Re: [PATCH 1/4] MMC: omap_hsmmc: set platform data after probe from DT node

2012-10-12 Thread Balaji T K
On Friday 12 October 2012 07:59 PM, Daniel Mack wrote: On 12.10.2012 12:58, Daniel Mack wrote: When probed from DT, the self-allocated platform data has to be attached to the actual device. Otherwise a NULL pointer will be dereferenced from omap_hsmmc_card_detect if a gpio handle for card-detect

Re: [PATCH 1/4] MMC: omap_hsmmc: set platform data after probe from DT node

2012-10-12 Thread Daniel Mack
On 12.10.2012 12:58, Daniel Mack wrote: > When probed from DT, the self-allocated platform data has to be attached > to the actual device. Otherwise a NULL pointer will be dereferenced from > omap_hsmmc_card_detect if a gpio handle for card-detect has been passed. > > Signed-off-by: Daniel Mack >

Re: [PATCH 2/4] MMC: omap_hsmmc: fix DMA config block

2012-10-12 Thread Daniel Mack
On 12.10.2012 13:12, Russell King - ARM Linux wrote: > On Fri, Oct 12, 2012 at 12:58:13PM +0200, Daniel Mack wrote: >> The .direction field of the config passed to dmaengine_slave_config() >> must be set in order to make the generic code store the configured bus >> width. > > NAK. The direction f

[PATCH] mmc: mmci: Support non-power-of-two block sizes for ux500v2 variant

2012-10-12 Thread Ulf Hansson
From: Ulf Hansson For the ux500v2 variant non power of two block sizes are supported. This will make it possible to decrease data overhead for SDIO transfers. Although we need to put some constraints to the alignment of the buffers when enabling this feature. Buffers must be 4 bytes aligned due

Re: [GIT PULL] Disintegrate UAPI for mmc

2012-10-12 Thread Chris Ball
Hi David, On Tue, Oct 09 2012, David Howells wrote: > Can you merge the following branch into the mmc tree please. > > This is to complete part of the Userspace API (UAPI) disintegration for which > the preparatory patches were pulled recently. After these patches, userspace > headers will be seg

Re: [RESEND PATCH 1/2] mmc: mmci: Fix incorrect handling of HW flow control for SDIO

2012-10-12 Thread Ulf Hansson
On 12 October 2012 14:35, Russell King - ARM Linux wrote: > On Fri, Oct 12, 2012 at 02:24:16PM +0200, Ulf Hansson wrote: >> Hi Russell, >> >> Our IT department is slow, too slow. :-) >> >> As an option, would it be possible for you to "manually" send me a new >> password? Another option would be t

Re: [RESEND PATCH 1/2] mmc: mmci: Fix incorrect handling of HW flow control for SDIO

2012-10-12 Thread Russell King - ARM Linux
On Fri, Oct 12, 2012 at 02:24:16PM +0200, Ulf Hansson wrote: > Hi Russell, > > Our IT department is slow, too slow. :-) > > As an option, would it be possible for you to "manually" send me a new > password? Another option would be to change the mail for my account to > ulf.hans...@linaro.org U

Re: [RESEND PATCH 1/2] mmc: mmci: Fix incorrect handling of HW flow control for SDIO

2012-10-12 Thread Ulf Hansson
On 10/12/2012 01:54 PM, Russell King - ARM Linux wrote: On Fri, Oct 12, 2012 at 10:13:22AM +0100, Russell King - ARM Linux wrote: On Wed, Oct 10, 2012 at 06:03:19PM +0200, Ulf Hansson wrote: From: Ulf Hansson For data writes<= 8 bytes, HW flow control was disabled but never re-enabled when the

[GIT PULL] MMC merge for 3.7-rc1, part 2

2012-10-12 Thread Chris Ball
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git tags/mmc-merge-for-3.7-rc1-part2 to receive two more changes for 3.7. There are no conflicts. Thanks. The following changes since commit 12250d843e8489ee00b5b7726da855e51694e792: Merge branch 'i2c-emb

Re: [RESEND PATCH 1/2] mmc: mmci: Fix incorrect handling of HW flow control for SDIO

2012-10-12 Thread Russell King - ARM Linux
On Fri, Oct 12, 2012 at 10:13:22AM +0100, Russell King - ARM Linux wrote: > On Wed, Oct 10, 2012 at 06:03:19PM +0200, Ulf Hansson wrote: > > From: Ulf Hansson > > > > For data writes <= 8 bytes, HW flow control was disabled but > > never re-enabled when the transfer was completed. This meant > >

Re: [RFC PATCH v2 08/16] ARM: omap: add hsmmc am33xx specific init

2012-10-12 Thread Matt Porter
On Fri, Oct 12, 2012 at 09:17:53AM +, Hebbar, Gururaja wrote: > Matt > > On Fri, Oct 12, 2012 at 00:34:33, Porter, Matt wrote: > > AM33xx requires special handling in hsmmc initialization > > platform glue. > > Since AM335x boots mainly through DT, do we still need this patch. > This function

Re: [PATCH 2/4] MMC: omap_hsmmc: fix DMA config block

2012-10-12 Thread Russell King - ARM Linux
On Fri, Oct 12, 2012 at 12:58:13PM +0200, Daniel Mack wrote: > The .direction field of the config passed to dmaengine_slave_config() > must be set in order to make the generic code store the configured bus > width. NAK. The direction field is deprecated, and should not be used anymore. -- To unsu

Re: [PATCH 3/4] MMC: omap_hsmmc: claim pinctrl at probe time

2012-10-12 Thread Linus Walleij
On Fri, Oct 12, 2012 at 12:58 PM, Daniel Mack wrote: > This allows DT-driven board to set up the pin mux only when the driver > is in use. > > Signed-off-by: Daniel Mack > Cc: Venkatraman S > Cc: Chris Ball > Cc: Grant Likely > Cc: Rob Herring > Cc: Linus Walleij > Cc: linux-o...@vger.kerne

Re: [PATCH 2/4] MMC: omap_hsmmc: fix DMA config block

2012-10-12 Thread Porter, Matt
On Oct 12, 2012, at 6:58 AM, Daniel Mack wrote: > The .direction field of the config passed to dmaengine_slave_config() > must be set in order to make the generic code store the configured bus > width. > > Without this patch, I keep getting the following error on a AM33xx > board: > > [1.963

[PATCH 3/4] MMC: omap_hsmmc: claim pinctrl at probe time

2012-10-12 Thread Daniel Mack
This allows DT-driven board to set up the pin mux only when the driver is in use. Signed-off-by: Daniel Mack Cc: Venkatraman S Cc: Chris Ball Cc: Grant Likely Cc: Rob Herring Cc: Linus Walleij Cc: linux-o...@vger.kernel.org --- drivers/mmc/host/omap_hsmmc.c | 7 +++ 1 file changed, 7 in

[PATCH 4/4] MMC: omap_hsmmc: add DT property for max bus frequency

2012-10-12 Thread Daniel Mack
Maximum bus frequency can be limited by external circuitry like level shifters etc. Allow passing this value from DT. Signed-off-by: Daniel Mack Cc: Venkatraman S Cc: Chris Ball Cc: Grant Likely Cc: Rob Herring Cc: linux-o...@vger.kernel.org --- drivers/mmc/host/omap_hsmmc.c | 5 - 1 fil

[PATCH 2/4] MMC: omap_hsmmc: fix DMA config block

2012-10-12 Thread Daniel Mack
The .direction field of the config passed to dmaengine_slave_config() must be set in order to make the generic code store the configured bus width. Without this patch, I keep getting the following error on a AM33xx board: [1.963144] edma-dma-engine edma-dma-engine.0: Undefined slave buswidth

[PATCH 1/4] MMC: omap_hsmmc: set platform data after probe from DT node

2012-10-12 Thread Daniel Mack
When probed from DT, the self-allocated platform data has to be attached to the actual device. Otherwise a NULL pointer will be dereferenced from omap_hsmmc_card_detect if a gpio handle for card-detect has been passed. Signed-off-by: Daniel Mack Cc: Venkatraman S Cc: Chris Ball Cc: Grant Likely

[PATCH 0/4] MMC: some omap_hsmmc fixes

2012-10-12 Thread Daniel Mack
Here are some assorted patches for the omap_hsmmc driver that I need on top Linus' current development branch to make it work on a AM33xx board. 1/4 and 2/4 qualify as bug fixes and I'm puzzled that these didn't hit anyone else yet. Daniel Mack (4): MMC: omap_hsmmc: set platform data after pro

RE: [RFC PATCH v2 08/16] ARM: omap: add hsmmc am33xx specific init

2012-10-12 Thread Hebbar, Gururaja
Matt On Fri, Oct 12, 2012 at 00:34:33, Porter, Matt wrote: > AM33xx requires special handling in hsmmc initialization > platform glue. Since AM335x boots mainly through DT, do we still need this patch. This function will be called in case of initializing hsmmc with Platform data. > > Signed-of

Re: [RESEND PATCH 1/2] mmc: mmci: Fix incorrect handling of HW flow control for SDIO

2012-10-12 Thread Russell King - ARM Linux
On Wed, Oct 10, 2012 at 06:03:19PM +0200, Ulf Hansson wrote: > From: Ulf Hansson > > For data writes <= 8 bytes, HW flow control was disabled but > never re-enabled when the transfer was completed. This meant > that a following read request would give buffer overrun errors. > > Signed-off-by: Ul