RE: [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): undefined reference to `__aeabi_uldivmod'

Regards Haijun. > -Original Message- > From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- > ow...@vger.kernel.org] On Behalf Of Fengguang Wu > Sent: Monday, November 26, 2012 2:22 PM > To: Zhang Haijun-B42677 > Cc: Huang Changming-R66093; linux-mmc@vger.kernel.org; Chris Ball > S

[PATCH] mmc: sdhci-imx-esdhc: use more devm_* functions

Use devm_kzalloc, devm_gpio_request_one and devm_request_irq to make cleanup path simpler. Signed-off-by: Shawn Guo --- drivers/mmc/host/sdhci-esdhc-imx.c | 56 1 file changed, 18 insertions(+), 38 deletions(-) diff --git a/drivers/mmc/host/sdhci-esdhc-imx

Re: [PATCH 3/3] MMC: sdhci-dove: allow GPIOs to be used for card detection on Dove

On Thu, Nov 22, 2012 at 11:55:51PM +, Russell King wrote: > This commit taken from Rabeeh's Cubox kernel and re-worked for DT; > Sebastian Hasselbrath is believed to be the original author. > > Some Cuboxes require a GPIO for card detection; this implements the > optional GPIO support for card

Re: [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): undefined reference to `__aeabi_uldivmod'

I don't understand your question... The question is, did Chris use the same environment detailed in the original report? Did he check out the right commit (d29254e21ee37b3c8525817398d96d6403f3) and used the right config (omap2plus_defconfig)? On Mon, Nov 26, 2012 at 06:12:24AM +, Zhang Hai

RE: [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): undefined reference to `__aeabi_uldivmod'

Thanks, Fengguang, did you use the same environment as Chris? If so that's just the reason caused the err. Regards Haijun. > -Original Message- > From: Fengguang Wu [mailto:fengguang...@intel.com] > Sent: Monday, November 26, 2012 2:03 PM > To: Huang Changming-R66093 > Cc: Zhang Haijun-B

Re: [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): undefined reference to `__aeabi_uldivmod'

On Mon, Nov 26, 2012 at 05:54:33AM +, Huang Changming-R66093 wrote: > Hi, Robot > I don't find the `__aeabi_uldivmod' in branch 'mmc-next' of linux-mmc tree. > Could you point out which file use it? > > This patch just use the 'div_u64' to calculate the timeout in order to avoid > overflow.

RE: [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): undefined reference to `__aeabi_uldivmod'

Hi, Robot I don't find the `__aeabi_uldivmod' in branch 'mmc-next' of linux-mmc tree. Could you point out which file use it? This patch just use the 'div_u64' to calculate the timeout in order to avoid overflow. Best Regards Jerry Huang > -Original Message- > From: kbuild test robot [m

RE: [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): undefined reference to `__aeabi_uldivmod'

Hi,Chris I had update my branch linux-mmc and test, there is no such err. As u64 need the macro div_u64 in "include/linux/math64.h" #ifndef div_u64 static inline u64 div_u64(u64 dividend, u32 divisor) { u32 remainder; return div_u64_rem(dividend, divisor, &remainder); } #endif As

Re: [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): undefined reference to `__aeabi_uldivmod'

Hi, On Sun, Nov 25 2012, kbuild test robot wrote: > tree: git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git mmc-next > head: b1dc46e6cd5f314f52a9864cc7ba1b7624b54bd7 > commit: d29254e21ee37b3c8525817398d96d6403f3 [45/63] mmc: core: > Use u64 to calculate the timeout value to avoid

[mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): undefined reference to `__aeabi_uldivmod'

tree: git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git mmc-next head: b1dc46e6cd5f314f52a9864cc7ba1b7624b54bd7 commit: d29254e21ee37b3c8525817398d96d6403f3 [45/63] mmc: core: Use u64 to calculate the timeout value to avoid overflow config: make ARCH=arm omap2plus_defconfig All er

Re: [PATCH 1/7] mmc: omap_hsmmc: Fix Oops in case of data errors

Hi Venkat, On Mon, Nov 19 2012, Venkatraman S wrote: > From: Balaji T K > > "commit ae4bf788ee9bf7c2d51b0309117d1fcccbdd50a2 > mmc: omap_hsmmc: consolidate error report handling of HSMMC IRQ" > sets both end_cmd and end_trans to 1. > > Setting end_cmd to 1 for Data Timeout/CRC leads to NULL point

Re: [PATCH] SDHC: support command with busy response expecting for TC

Hi, On Fri, Nov 23 2012, r66...@freescale.com wrote: > From: Jerry Huang > > The IP verions older than 2.3 didn't support the command with busy response > which expect for TC bit set. But after the VVN2.3, eSDHC IP has supported it. > > Signed-off-by: Jerry Huang > CC: Anton Vorontsov > CC: Chr

Re: [PATCH 3/3] MMC: sdhci-dove: allow GPIOs to be used for card detection on Dove

Hi, adding Guennadi, On Fri, Nov 23 2012, Russell King - ARM Linux wrote: > On Fri, Nov 23, 2012 at 08:14:27PM +0800, Shawn Guo wrote: >> On Fri, Nov 23, 2012 at 08:57:26AM +, Russell King - ARM Linux wrote: >> > Does this work with the sdhci stuff? >> >> Honestly, I'm not sure, but I guess i

Re: [PATCH 1/2] sdhci: add quirk for lack of 1.8v support

On Nov 25, 2012, at 6:01 PM, Daniel Drake wrote: > The OLPC XO-1.75 laptop includes a SDHCI controller which is 1.8v > capable, and it truthfully reports so in its capabilities. This > alternate voltage is used for driving new "UHS-I" SD cards at their > full speed. > > However, what the contro

Re: [PATCH 1/1] mmc: sdhci-dove: remove duplicate inclusion of linux/err.h

Hi, On Mon, Nov 19 2012, Sachin Kamat wrote: > linux/err.h was included twice. > > Signed-off-by: Sachin Kamat > --- > drivers/mmc/host/sdhci-dove.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-dove.c b/drivers/mmc/host/sdhci-dove.c > index

Re: [PATCH 0/4] Support for optional MMC PM capabilities

Hi, On Sun, Nov 18 2012, Abhilash Kesavan wrote: > This patchset adds optional PM properties to the core MMC bindings. It also > makes the appropriate changes in the sdhci platform and dw_mmc driver files. > Based on git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git : for-next. > Note: Pat

Re: [PATCH v2 2/2] mmc: host: sdhci-s3c: Add support for pinctrl

Hi, On Sun, Nov 25 2012, Tomasz Figa wrote: > Hi Chris, > > On Sunday 25 of November 2012 14:22:44 Chris Ball wrote: >> Hi, >> >> On Wed, Nov 21 2012, Thomas Abraham wrote: >> > nit: there could have been one example each for gpio and pinctrl >> > variant instead of putting both into one example

Re: [PATCH 1/2 v3] Powerpc/eSDHC: Calculate the applicable mmc erase timeout value

Hi, On Mon, Nov 19 2012, Haijun Zhang wrote: > As large area erase needs long time usually a few minutes, > which the host can't wait will bring about timeout error. > So we need to split the large area to small sections which > only need short erase time to avoid timeout error. > > Signed-off-by:

Re: [PATCH] Powerpc eSDHC: Use u64 to calculate the timeout value to avoid overflow

Hi, On Mon, Nov 19 2012, Haijun Zhang wrote: > As some mmc cards need large timeout value usually a few seconds, > so data timeout nanosecond will overflow with u32 variable and > give the wrong timeout value, so use u64 will be safe. > > Signed-off-by: Jerry Huang > Signed-off-by: Haijun Zhang

Re: [PATCH v2 2/2] mmc: host: sdhci-s3c: Add support for pinctrl

Hi Chris, On Sunday 25 of November 2012 14:22:44 Chris Ball wrote: > Hi, > > On Wed, Nov 21 2012, Thomas Abraham wrote: > > nit: there could have been one example each for gpio and pinctrl > > variant instead of putting both into one example node. > > Tomasz, do you want to reply to this review

Re: [PATCH v6 09/14] mmc: sdhci-pxav3: add quirks2

Hi, On Sun, Nov 18 2012, Kevin Liu wrote: >>> From: Kevin Liu >>> >>> Acked-by: Zhangfei Gao >>> Signed-off-by: Kevin Liu >>> --- >>> drivers/mmc/host/sdhci-pxav3.c |2 ++ >>> include/linux/platform_data/pxa_sdhci.h |2 ++ >>> 2 files changed, 4 insertions(+), 0 deletions(-)

Re: [PATCH v2 2/2] mmc: host: sdhci-s3c: Add support for pinctrl

Hi, On Wed, Nov 21 2012, Thomas Abraham wrote: > nit: there could have been one example each for gpio and pinctrl > variant instead of putting both into one example node. Tomasz, do you want to reply to this review comment? Thanks, - Chris. -- Chris Ball One Laptop Pe

Re: [PATCH 1/2] sdhci: add quirk for lack of 1.8v support

On Sun, Nov 25, 2012 at 12:36 PM, Philip Rakity wrote: > The same effect can be achieved by setting the quirk > SDHCI_QUIRK_MISSING_CAPS > reading caps[0] and removing from caps[1] the UHS values in the controller > specific code for your board. > > What is the reason you cannot do this ? The sa

Re: [PATCH 1/2] sdhci: add quirk for lack of 1.8v support

Daniel The same effect can be achieved by setting the quirk SDHCI_QUIRK_MISSING_CAPS reading caps[0] and removing from caps[1] the UHS values in the controller specific code for your board. What is the reason you cannot do this ? Philip On Nov 25, 2012, at 6:01 PM, Daniel Drake wrote: > Th

Re: UHS-I voltage switching on OLPC XO-1.75

On Tue, Nov 20, 2012 at 2:53 AM, Johan Rudholm wrote: >> On the other hand, we may have a good basis to add a quirk, triggered >> by the device tree, for when the hardware physically does not have >> 1.8v capabilities. > > This also seems proper, if we know we can't get 1.8V, then we > shouldn't e

[PATCH 2/2] mmc: add no-1-8-v device tree flag

The OLPC XO-1.75 laptop includes a SDHCI controller which is 1.8v capable, and it truthfully reports so in its capabilities. This alternate voltage is used for driving new "UHS-I" SD cards at their full speed. However, what the controller doesn't know is that the motherboard physically doesn't hav

[PATCH 1/2] sdhci: add quirk for lack of 1.8v support

The OLPC XO-1.75 laptop includes a SDHCI controller which is 1.8v capable, and it truthfully reports so in its capabilities. This alternate voltage is used for driving new "UHS-I" SD cards at their full speed. However, what the controller doesn't know is that the motherboard physically doesn't hav

Re: [PATCH v3] mmc: core: Add support for idle time BKOPS

Hi Chris, I managed to find a solution in which there is no need to check the number of written / discarded sectors as a trigger for BKOPS status check. I moved the code that checks the need to stop the BKOPS to mmc/block code, in which there is no need for additional claim_host and remove_host op

[PATCH v3] mmc: core: Add support for idle time BKOPS

Devices have various maintenance operations need to perform internally. In order to reduce latencies during time critical operations like read and write, it is better to execute maintenance operations in other times - when the host is not being serviced. Such operations are called Background operat