RE: [PATCH v2 1/2] mmc: dw_mmc: exynos: Stop claiming wp-gpio

2012-11-28 Thread Seungwon Jeon
Hi Doug, On Thursday, November 29, 2012, Doug Anderson wrote: > Seungwon, > > Thanks for the review. See below for comments. If you'd like me to > respin then please let me know. Otherwise I look forward to your ack. > > On Wed, Nov 28, 2012 at 1:29 AM, Seungwon Jeon wrote: > > Yes. pin of w

RE: [PATCH 2/2] mmc: dw_mmc: make sure of clearing HLE interrupt

2012-11-28 Thread Seungwon Jeon
Hi James, On Wednesday, November 28, 2012, James Hogan wrote: > Hi, > > On 28/11/12 10:26, Seungwon Jeon wrote: > > Even though HLE interrupt is enabled, there is no touch. > > This patch clears HLE interrupt which is not unhandled. > > It's not entirely clear from this description what the patc

RE: [PATCH V4] Powerpc eSDHC Recover from the ADMA error

2012-11-28 Thread Zhang Haijun-B42677
Hi chris, Sorry to miss this mail. Patch V4 for this patch had resend. Pls review. Thanks. Regards Haijun. > -Original Message- > From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- > ow...@vger.kernel.org] On Behalf Of Chris Ball > Sent: Sunday, November 18, 2012 4:56 AM > To: Hua

RE: [PATCH] Powerpc/eSDHC: Calculate the applicable mmc erase timeout value

2012-11-28 Thread Zhang Haijun-B42677
Sorry, I forget to add patch version. Discard this patch. Another had send. Regards Haijun. > -Original Message- > From: Zhang Haijun-B42677 > Sent: Thursday, November 29, 2012 1:22 PM > To: linux-mmc@vger.kernel.org > Cc: Zhang Haijun-B42677; Huang Changming-R66093; Chris Ball > Subjec

[PATCH 1/2 V5] Powerpc/eSDHC: Calculate the applicable mmc erase timeout value

2012-11-28 Thread Haijun Zhang
As large area erase needs long time usually a few minutes, So we use max_discard_to to limit the size one request can issue to avoid timeout. As our controller had the quirk SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK so we need to assign the timeout_clk and max_discard_to according to the max_dtr which ca

[PATCH] Powerpc/eSDHC: Calculate the applicable mmc erase timeout value

2012-11-28 Thread Haijun Zhang
As large area erase needs long time usually a few minutes, So we use max_discard_to to limit the size one request can issue to avoid timeout. As our controller had the quirk SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK so we need to assign the timeout_clk and max_discard_to according to the max_dtr which ca

[PATCH V4] Powerpc eSDHC Recover from the ADMA error

2012-11-28 Thread Haijun Zhang
Signed-off-by: Haijun Zhang Signed-off-by: Jerry Huang Acked-by: Anton Vorontsov CC: Chris Ball --- changes for v4: - Correct inconsistent issue changes for v3: - Correct the if statement in function workground changes for v2: - Invert the condition of the if statement

Re: [PATCH] Powerpc/eSDHC: Calculate the applicable mmc erase timeout value

2012-11-28 Thread Anton Vorontsov
On Thu, Nov 29, 2012 at 12:48:22PM +0800, Haijun Zhang wrote: > As large area erase needs long time usually a few minutes, > So we use max_discard_to to limit the size one request can > issue to avoid timeout. As our controller had the quirk > SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK so we need to assig

RE: [PATCH] Powerpc/eSDHC: Calculate the applicable mmc erase timeout value

2012-11-28 Thread Zhang Haijun-B42677
Thanks Anton Please review. Regards Haijun. > -Original Message- > From: Zhang Haijun-B42677 > Sent: Thursday, November 29, 2012 12:48 PM > To: linux-mmc@vger.kernel.org > Cc: Zhang Haijun-B42677; Huang Changming-R66093; Anton Vorontsov > Subject: [PATCH] Powerpc/eSDHC: Calculate the a

[PATCH] Powerpc/eSDHC: Calculate the applicable mmc erase timeout value

2012-11-28 Thread Haijun Zhang
As large area erase needs long time usually a few minutes, So we use max_discard_to to limit the size one request can issue to avoid timeout. As our controller had the quirk SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK so we need to assign the timeout_clk and max_discard_to according to the max_dtr which ca

Re: [PATCH 1/2 v4] Powerpc/eSDHC: Calculate the applicable mmc erase timeout value

2012-11-28 Thread Anton Vorontsov
On Thu, Nov 29, 2012 at 12:00:16PM +0800, Haijun Zhang wrote: > As large area erase needs long time usually a few minutes, > So we use max_discard_to to limit the size one request can > issue to avoid timeout. As our controller had the quirk > SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK so we need to assig

[PATCH 1/2 v4] Powerpc/eSDHC: Calculate the applicable mmc erase timeout value

2012-11-28 Thread Haijun Zhang
As large area erase needs long time usually a few minutes, So we use max_discard_to to limit the size one request can issue to avoid timeout. As our controller had the quirk SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK so we need to assign the timeout_clk and max_discard_to according to the max_dtr which ca

Re: [PATCH -next] mmc: wmt-sdmmc: fix potential NULL pointer dereference in wmt_mci_probe()

2012-11-28 Thread Tony Prisk
On Wed, 2012-11-28 at 21:31 -0500, Wei Yongjun wrote: > From: Wei Yongjun > > The dereference to 'of_id' should be moved below the NULL test. > > Signed-off-by: Wei Yongjun > --- > drivers/mmc/host/wmt-sdmmc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/

[PATCH -next] mmc: wmt-sdmmc: fix potential NULL pointer dereference in wmt_mci_probe()

2012-11-28 Thread Wei Yongjun
From: Wei Yongjun The dereference to 'of_id' should be moved below the NULL test. Signed-off-by: Wei Yongjun --- drivers/mmc/host/wmt-sdmmc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/wmt-sdmmc.c b/drivers/mmc/host/wmt-sdmmc.c index 5ba4605..f737b0c

[RFC][PATCH] pxamci: defining CONFIG_REGULATOR_DUMMY may break PXA MMC controller driver.

2012-11-28 Thread dromede
From: Marko Katic Here's an interesting scenario. The spitz machine has an Intersil 6271A voltage regulator and an ADS7846 touchscreen controller. The ADS7846 driver requires the use of the voltage regulator or if not present, CONFIG_REGULATOR_DUMMY should be used for proper operation. So to supp

Re: [PATCH v2 1/2] mmc: dw_mmc: exynos: Stop claiming wp-gpio

2012-11-28 Thread Doug Anderson
Seungwon, Thanks for the review. See below for comments. If you'd like me to respin then please let me know. Otherwise I look forward to your ack. On Wed, Nov 28, 2012 at 1:29 AM, Seungwon Jeon wrote: > Yes. pin of write protection is common property. > This change is good. I have some sugges

Re: [PATCH] mmc: mmci: Support non-power-of-two block sizes for ux500v2 variant

2012-11-28 Thread Russell King - ARM Linux
On Wed, Nov 28, 2012 at 05:55:13PM +0100, Per Forlin wrote: > I have tried to work out an if-statement to check this properly. Here > is my conclusion, > This only works if sg len is 1 (in the SDIO case) > > if (WRITE) > align = sg->offset & 3 > else if (READ) > align = 0 > > if (sg->offset &

Re: [PATCH] mmc: mmci: Support non-power-of-two block sizes for ux500v2 variant

2012-11-28 Thread Per Forlin
On Mon, Nov 26, 2012 at 11:52 AM, Per Förlin wrote: > On 11/26/2012 11:27 AM, Russell King - ARM Linux wrote: >> On Mon, Nov 26, 2012 at 11:20:32AM +0100, Per Förlin wrote: >>> On 11/22/2012 06:37 PM, Russell King - ARM Linux wrote: On Thu, Nov 22, 2012 at 06:28:30PM +0100, Per Forlin wrote:

Re: [PATCH v3] mmc: core: Add support for idle time BKOPS

2012-11-28 Thread Chris Ball
Hi Maya, On Sun, Nov 25 2012, me...@codeaurora.org wrote: > I managed to find a solution in which there is no need to check the number > of written / discarded sectors as a trigger for BKOPS status check. > I moved the code that checks the need to stop the BKOPS to mmc/block code, > in which there

Re: [PATCH] mmc: mmci: Fixup and cleanup code for DMA handling

2012-11-28 Thread Ulf Hansson
On 21 November 2012 16:22, Ulf Hansson wrote: > On 16 October 2012 13:44, Ulf Hansson wrote: >> On 16 October 2012 10:17, Linus Walleij wrote: >>> On Tue, Oct 16, 2012 at 9:16 AM, Ulf Hansson wrote: >>> This code has not been tested on a "legacy" ARM PL180 but only for ux500 boards. E

Re: [PATCH 2/2] mmc: dw_mmc: make sure of clearing HLE interrupt

2012-11-28 Thread James Hogan
Hi, On 28/11/12 10:26, Seungwon Jeon wrote: > Even though HLE interrupt is enabled, there is no touch. > This patch clears HLE interrupt which is not unhandled. It's not entirely clear from this description what the patch is trying to do. I presume from the patch you're trying to say something li

Re: [PATCH 1/2] mmc: dw_mmc: use devres functions in dw_mmc

2012-11-28 Thread James Hogan
On 28/11/12 10:26, Seungwon Jeon wrote: > Use managed device resource functions for easy handling. > This makes driver simpler in the routine of error and exit. > > Signed-off-by: Seungwon Jeon This looks reasonable to me Acked-by: James Hogan > --- > drivers/mmc/host/dw_mmc.c | 43 +++

[PATCH 2/2] mmc: dw_mmc: make sure of clearing HLE interrupt

2012-11-28 Thread Seungwon Jeon
Even though HLE interrupt is enabled, there is no touch. This patch clears HLE interrupt which is not unhandled. Signed-off-by: Seungwon Jeon --- drivers/mmc/host/dw_mmc.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/

[PATCH 1/2] mmc: dw_mmc: use devres functions in dw_mmc

2012-11-28 Thread Seungwon Jeon
Use managed device resource functions for easy handling. This makes driver simpler in the routine of error and exit. Signed-off-by: Seungwon Jeon --- drivers/mmc/host/dw_mmc.c | 43 ++- 1 files changed, 14 insertions(+), 29 deletions(-) diff --git a/dri

RE: [PATCH v2 1/2] mmc: dw_mmc: exynos: Stop claiming wp-gpio

2012-11-28 Thread Seungwon Jeon
Yes. pin of write protection is common property. This change is good. I have some suggestion below. Could you check it? On Friday, November 23, 2012, Doug Anderson wrote: > The exynos code claimed wp-gpio with devm_gpio_request() but never did > anything with it. That meant that anyone using a wr

[PATCH] mmc: sh_mobile_sdhi: fix clock frequency printing

2012-11-28 Thread Guennadi Liakhovetski
During its probing the SDHI driver prints out the clock frequency, but does it wrongly, always reporting 0Hz. Use the MMC host frequency value to fix this issue. Signed-off-by: Guennadi Liakhovetski --- drivers/mmc/host/sh_mobile_sdhi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

[PATCH] mmc: sh_mmcif: remove unneeded clock connection ID

2012-11-28 Thread Guennadi Liakhovetski
MMCIF only uses one clock, all ARM and SuperH platforms register MMCIF clock lookup entries with no connection ID, hence it can be dropped in the driver too. Signed-off-by: Guennadi Liakhovetski --- drivers/mmc/host/sh_mmcif.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff

[PATCH] mmc: sh_mobile_sdhi: remove unneeded clock connection ID

2012-11-28 Thread Guennadi Liakhovetski
SDHI only uses one clock, all ARM and SuperH platform register SDHI clock lookup entries with no connection ID, hence it can be dropped in the driver too. Signed-off-by: Guennadi Liakhovetski --- drivers/mmc/host/sh_mobile_sdhi.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) d