Re: [PATCH] mmc: dw-mmc: fix the error for a few argument

Hi, On Mon, Dec 03 2012, Jaehoon Chung wrote: > The argument of dw_mci_setup_bus is modified. > (Abhilash's patch: mmc: dw-mc: Add sdio power binding) > This patch used the dw_mci_setup_bus(slot, false) instead of > dw_mci_setup_bus(slot) > > Signed-off-by: Jaehoon Chung > --- > drivers/mmc/host

[PATCH] mmc: dw-mmc: fix the error for a few argument

The argument of dw_mci_setup_bus is modified. (Abhilash's patch: mmc: dw-mc: Add sdio power binding) This patch used the dw_mci_setup_bus(slot, false) instead of dw_mci_setup_bus(slot) Signed-off-by: Jaehoon Chung --- drivers/mmc/host/dw_mmc.c |2 +- 1 files changed, 1 insertions(+), 1 delet

Re: [PATCH v3 1/4] mmc: dw-mmc: relocate the position called dw_mci_setup_bus()

Hi Chris, This patch has dependency with Abhilash's patch(mmc:dw-mmc: Add sdio power binding) That patch is modified the dw_mci_setup_bus's argument. So it is produced the compiler error. Do you modify the dw_mci_bus_setup(slot, false) instead of dw_mci_bus_setup(slot)? Otherwise, i will resend

Re: [PATCH V5] Powerpc eSDHC Recover from the ADMA error

Hi, On Mon, Dec 03 2012, Haijun Zhang wrote: > A-003500: False ADMA Error might be reported when ADMA is used for > multiple block read command with Stop at Block Gap. If PROCTL[SABGREQ] > is set when the particular block's data is received by the System side > logic before entire block(with CRC)

RE: [PATCH V5] Powerpc eSDHC Recover from the ADMA error

New patch had sent. Pls Review. Thanks Chris. Regards Haijun. > -Original Message- > From: Chris Ball [mailto:c...@laptop.org] > Sent: Tuesday, December 04, 2012 10:48 AM > To: Zhang Haijun-B42677 > Cc: linux-mmc@vger.kernel.org; Huang Changming-R66093 > Subject: Re: [PATCH V5] Powerpc

[PATCH V5] Powerpc eSDHC Recover from the ADMA error

A-003500: False ADMA Error might be reported when ADMA is used for multiple block read command with Stop at Block Gap. If PROCTL[SABGREQ] is set when the particular block's data is received by the System side logic before entire block(with CRC) data is received by the SD side logic, and also if ADM

Re: [PATCH V5] Powerpc eSDHC Recover from the ADMA error

Hi, On Thu, Nov 29 2012, Haijun Zhang wrote: > A-003500: False ADMA Error might be reported when ADMA is used for > multiple block read command with Stop at Block Gap. If PROCTL[SABGREQ] > is set when the particular block's data is received by the System side > logic before entire block(with CR

Powerpc : patches sent

Hi Chris I had sent six patches list below, they all Acked-by or Reviewed-by Anton. Could you please help review these patches again? If resending these patches is needed Pls let me know. They are sorted by date. Thanks in advance. 1) Subject: [PATCH V5] Powerpc eSDHC Recover from the

Re: [PATCH v3 2/4] mmc: dw-mmc: remove the duplicated code

Hi, On Thu, Nov 08 2012, Jaehoon Chung wrote: > ctype is used 1-bit buswidth mode by default. > > Signed-off-by: Jaehoon Chung > Signed-off-by: Kyungmin Park Thanks, pushed to mmc-next for 3.8. - Chris. -- Chris Ball One Laptop Per Child -- To unsubscribe from this l

Re: [PATCH v3 1/4] mmc: dw-mmc: relocate the position called dw_mci_setup_bus()

Hi, On Thu, Nov 08 2012, Jaehoon Chung wrote: > To ensure the stable clock need to enable before set the > DW_MMC_CARD_NEED_INIT flag. > If set DW_MMC_CARD_NEED_INIT flag, wait for 80-clock before first command > after power-up. > > Signed-off-by: Jaehoon Chung > Signed-off-by: Kyungmin Park >

Re: [RESEND PATCH] mmc: Limit MMC speed to 52MHz if not HS200

Hi Al, On Fri, Nov 30 2012, Al Cooper wrote: > If "caps2" host capabilities does not indicate support for MMC > HS200, don't allow clock speeds >52MHz. Currently, for MMC, the > clock speed is set to the lesser of the max speed the eMMC module > supports (card->ext_csd.hs_max_dtr) or the max base

Re: [PATCH 1/2] mmc: dw_mmc: use devres functions in dw_mmc

Hi, On Wed, Nov 28 2012, James Hogan wrote: > On 28/11/12 10:26, Seungwon Jeon wrote: >> Use managed device resource functions for easy handling. >> This makes driver simpler in the routine of error and exit. >> >> Signed-off-by: Seungwon Jeon > > This looks reasonable to me > > Acked-by: James

Re: [PATCH] mmc: sh_mmcif: remove unneeded clock connection ID

Hi, On Fri, Nov 30 2012, Simon Horman wrote: > On Wed, Nov 28, 2012 at 10:24:27AM +0100, Guennadi Liakhovetski wrote: >> MMCIF only uses one clock, all ARM and SuperH platforms register MMCIF >> clock lookup entries with no connection ID, hence it can be dropped in >> the driver too. >> >> Signed

Re: [PATCH] mmc: sh_mobile_sdhi: remove unneeded clock connection ID

Hi, On Fri, Nov 30 2012, Simon Horman wrote: > On Wed, Nov 28, 2012 at 10:24:21AM +0100, Guennadi Liakhovetski wrote: >> SDHI only uses one clock, all ARM and SuperH platform register SDHI clock >> lookup entries with no connection ID, hence it can be dropped in the >> driver too. >> >> Signed-of

Re: [PATCH] mmc: sh_mobile_sdhi: fix clock frequency printing

Hi, On Fri, Nov 30 2012, Simon Horman wrote: > On Wed, Nov 28, 2012 at 10:24:13AM +0100, Guennadi Liakhovetski wrote: >> During its probing the SDHI driver prints out the clock frequency, but >> does it wrongly, always reporting 0Hz. Use the MMC host frequency value >> to fix this issue. >> >> Si

Re: [PATCH 1/2] mmc: Remove redundant null check before kfree in sdio_bus.c

Hi Sachin, On Tue, Nov 20 2012, Sachin Kamat wrote: > kfree on a null pointer is a no-op. > > Signed-off-by: Sachin Kamat > --- > drivers/mmc/core/sdio_bus.c |3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/core/sdio_bus.c b/drivers/mmc/core/sdio_bus.c

Re: [PATCH] mmc: sdhci-imx-esdhc: use more devm_* functions

Hi Shawn, On Mon, Nov 26 2012, Shawn Guo wrote: > Use devm_kzalloc, devm_gpio_request_one and devm_request_irq to make > cleanup path simpler. > > Signed-off-by: Shawn Guo Thanks, pushed to mmc-next for 3.8. - Chris. -- Chris Ball One Laptop Per Child -- To unsubscrib

Re: [PATCH 3/3] MMC: sdhci-dove: allow GPIOs to be used for card detection on Dove

Hi Guennadi, On Mon, Nov 26 2012, Guennadi Liakhovetski wrote: >> Guennadi, what are your thoughts about consolidating this reset logic >> between the sdhci tasklet and slot-gpio? It would certainly be nice to >> use slot-gpio in cases like this one, so it's worth fixing. > > Sure, this can be ad

Re: [PATCH 2/2] mmc: add no-1-8-v device tree flag

Hi, On Sun, Nov 25 2012, Daniel Drake wrote: > The OLPC XO-1.75 laptop includes a SDHCI controller which is 1.8v > capable, and it truthfully reports so in its capabilities. This > alternate voltage is used for driving new "UHS-I" SD cards at their > full speed. > > However, what the controller do

Re: [PATCH 1/2] sdhci: add quirk for lack of 1.8v support

Hi, On Sun, Nov 25 2012, Daniel Drake wrote: > The OLPC XO-1.75 laptop includes a SDHCI controller which is 1.8v > capable, and it truthfully reports so in its capabilities. This > alternate voltage is used for driving new "UHS-I" SD cards at their > full speed. > > However, what the controller do

Re: [PATCH v3 1/4] mmc: dw-mmc: relocate the position called dw_mci_setup_bus()

On Tue, Nov 27, 2012 at 11:44 PM, Jaehoon Chung wrote: > Hi, > > On 11/27/2012 04:58 PM, Seungwon Jeon wrote: >> On Thursday, November 08, 2012, Jaehoon Chung wrote: >>> To ensure the stable clock need to enable before set the >>> DW_MMC_CARD_NEED_INIT flag. >>> If set DW_MMC_CARD_NEED_INIT flag

Re: [PATCH v3] mmc: core: Add support for idle time BKOPS

Hi Jaehoon, With this patch we don't expect to see any degradation. Thanks for verifying that. The test plan would be to run the lmdd and iozone benchmarks with this patch and verify that the performance is not degraded. I verified it with the msm_sdcc controller. Chris - We do expect it to influ

Re: [PATCH 1/2] mmc: Remove redundant null check before kfree in sdio_bus.c

On 20 November 2012 14:43, Sachin Kamat wrote: > kfree on a null pointer is a no-op. > > Signed-off-by: Sachin Kamat > --- > drivers/mmc/core/sdio_bus.c |3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/core/sdio_bus.c b/drivers/mmc/core/sdio_bus.c > ind