[PATCH] mmc: dw_mmc: change the macro name from DTO to DRTO

2013-05-26 Thread Jaehoon Chung
At Interrupt status register, Bit9 is Data Read Timeout. But we used macro name as the DTO. It could be confused with the Data Transfer Over(DTO)-Bit[3]. it's clearly that is changed the DRTO instead of DTO. Signed-off-by: Jaehoon Chung --- drivers/mmc/host/dw_mmc.c |4 ++-- drivers/mmc/host

[PATCHv2] mmc: sdhci-s3c: fix the wrong register value when, clock is disabled

2013-05-26 Thread Jaehoon Chung
When use the QUIRK_NONSTANDARD_CLOCK, then never set to 0 at clock control register. This patch is fixed this problem. Signed-off-by: Jaehoon Chung --- Changelog v2: - Rebased at the latest mmc tree drivers/mmc/host/sdhci-s3c.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

Re: [PATCH v2] mmc: dwmmc: let device core setup the default pin configuration

2013-05-26 Thread Jaehoon Chung
Minor comment, Maybe Seungwon mentioned the prefix use as "dw_mmc". Best Regards, Jaehoon Chung On 04/02/2013 03:09 PM, Thomas Abraham wrote: > With device core now able to setup the default pin configuration, > the pin configuration code based on the deprecated Samsung specific > gpio bindings i

eMMC bus test command failure

2013-05-26 Thread Minjian Wu (minjianwu)
Hi, I got one issue on Linux V3.7 as following. > mmc0: switch to bus width 1 ddr 0 failed  > mmc0: error -110 whilst initialising MMC card  After debugging and checking the source codes, we find that in mmc_send_bus_test function, there is no data timeout

Re: [PATCH 04/13] mmc: mxs-mmc: Let device core handle pinctrl

2013-05-26 Thread Fabio Estevam
Hi Chris, On Mon, May 6, 2013 at 3:05 PM, Fabio Estevam wrote: > Since commit ab78029 (drivers/pinctrl: grab default handles from device core), > we can rely on device core for handling pinctrl. > > So remove devm_pinctrl_get_select_default() from the driver. > > Cc: Chris Ball > Cc: > Signed-o

Re: [PATCH 1/1] mmc: of_mmc_spi: fix card detect irq

2013-05-26 Thread Sergei Shtylyov
Hello. On 05/26/2013 04:28 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: set missing irq type the IRQF_ONESHOT Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD Cc: stable # 3.4+ Cc: linux-mmc@vger.kernel.org --- drivers/mmc/host/of_mmc_spi.c |4 ++-- 1 file changed, 2 insertions(+), 2 de

Re: [PATCH 0/3] mmc: omap_hsmmc: fixes for 3.10

2013-05-26 Thread Chris Ball
Hi, On Fri, May 10 2013, Balaji T K wrote: > Fix to make wlan/sdio work with dt and to use dma binding from dt > > Matt Porter (1): > mmc: omap_hsmmc: convert to dma_request_slave_channel_compat > > Santosh Shilimkar (1): > mmc: omap_hsmmc: Skip platform_get_resource_byname() for dt case > > T

Re: [PATCH 0/3] mmc: sdhci: support runtime PM for BYT SD cards

2013-05-26 Thread Chris Ball
Hi Adrian, On Mon, May 06 2013, Adrian Hunter wrote: > Hi > > Here are 3 patches to support runtime PM for BYT SD cards > > Please note that these patches are dependent upon 2 gpio patches > that are in linux-next and linux-gpio but not the mmc tree. > Those patches are: > > author Mika We

Re: [PATCHv4 6/6] mmc: dw_mmc: Add support DW SD/MMC driver on SOCFPGA

2013-05-26 Thread Pavel Machek
On Fri 2013-05-24 20:58:34, Arnd Bergmann wrote: > On Friday 24 May 2013, Dinh Nguyen wrote: > > I apologize for that. Will make sure to include a [PATCH 0/6] message in > > the future. > > No worries, I actually saw now that my only other comment was also > wrong, as you have the binding I was lo

Re: [PATCH 01/22] mmc: android-goldfish: remove unnecessary platform_set_drvdata()

2013-05-26 Thread Chris Ball
Hi Jingoo, On Mon, May 06 2013, Jingoo Han wrote: > The driver core clears the driver data to NULL after device_release > or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d > (device-core: Ensure drvdata = NULL when no driver is bound). > Thus, it is not needed to manually

Re: [PATCH] mmc: Allow sdhci platform drivers to set quirks2 from platform data

2013-05-26 Thread Chris Ball
Hi Al, On Tue, Apr 30 2013, Al Cooper wrote: > Signed-off-by: Al Cooper > --- > drivers/mmc/host/sdhci-pltfm.c |4 +++- > drivers/mmc/host/sdhci-pltfm.h |1 + > 2 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm

Re: [PATCH V2] mmc: atmel-mci: add CONFIG_PM_SLEEP to suspend/resume functions

2013-05-26 Thread Chris Ball
Hi, On Mon, Apr 29 2013, Jingoo Han wrote: > Add CONFIG_PM_SLEEP to suspend/resume functions to fix the following > build warning when CONFIG_PM_SLEEP is not selected. This is because > sleep PM callbacks defined by SIMPLE_DEV_PM_OPS are only used when > the CONFIG_PM_SLEEP is enabled. > > drivers

Re: [PATCH 0/3] mmc: sdhi / tmio: add DT DMA

2013-05-26 Thread Chris Ball
Hi, On Sun, May 26 2013, Chris Ball wrote: > On Fri, Apr 26 2013, Guennadi Liakhovetski wrote: >> These 3 patches add Device Tree DMA support to the TMIO MMC driver, when >> used on SDHI platforms. >> >> Samuel: these patches touch an mfd header file lightly, I think, it's >> better just to get

Re: [PATCH 0/3] mmc: sdhi / tmio: add DT DMA

2013-05-26 Thread Chris Ball
Hi Guennadi, On Fri, Apr 26 2013, Guennadi Liakhovetski wrote: > These 3 patches add Device Tree DMA support to the TMIO MMC driver, when > used on SDHI platforms. > > Samuel: these patches touch an mfd header file lightly, I think, it's > better just to get your ack than to make a separate patc

Re: [PATCH 0/3] mmc: add more device ids

2013-05-26 Thread Chris Ball
Hi Adrian, On Fri, Apr 26 2013, Adrian Hunter wrote: > Here is a minor fix and some more device ids for sdhci-acpi and sdhci-pci. > > Please queue for 3.10 if possible. > > Adrian Hunter (3): > mmc: sdhci-acpi: fix initial runtime pm status > mmc: sdhci-acpi: add more device ids >

Re: [PATCH v2] mmc: core: Fix select power class after resume

2013-05-26 Thread Chris Ball
Hi Fredrik, On Tue, Apr 23 2013, Fredrik Soderstedt wrote: > Use the saved values in card->ext_csd when selecting power class. > By doing this the power class will be selected even if mmc_init_card > is called with oldcard != NULL, which is the case after a suspend/resume. > > Today ext_csd is NUL

Re: [PATCH] mmc: core: Restructure and simplify code for mmc sleep|awake

2013-05-26 Thread Chris Ball
Hi, On Fri, Apr 19 2013, Ulf Hansson wrote: > From: Ulf Hansson > > The mmc_card_sleep|awake APIs are not being used since the support is > already properly encapsulated within the suspend sequence. Sleep|awake > command is also specific for eMMC. > > We remove the sleep|awake bus_ops, the mmc_ca

Re: [PATCH V4 0/4] mmc: Use runtime pm for blkdevice

2013-05-26 Thread Chris Ball
Hi Ulf, On Thu, May 02 2013, Ulf Hansson wrote: > From: Ulf Hansson > > SDIO has been using runtime pm for a while to handle runtime power save > operations. This patchset is enabling the option to make the sd/mmc > blockdevices to use runtime pm as well. > > The runtime pm implementation for the

Re: [PATCH] mmc: atmel-mci: convert to dma_request_slave_channel_compat()

2013-05-26 Thread Chris Ball
Hi Nicolas, On Fri, May 10 2013, Nicolas Ferre wrote: > From: Ludovic Desroches > > Use generic DMA DT helper. Platforms booting with or without DT populated are > both supported. > > Signed-off-by: Ludovic Desroches > Acked-by: Jean-Christophe PLAGNIOL-VILLARD > Acked-by: Nicolas Ferre > ---

Re: [PATCH -next] mmc: mxs-mmc: fix error return code in mxs_mmc_probe()

2013-05-26 Thread Chris Ball
Hi, On Fri, Apr 19 2013, Marek Vasut wrote: > Dear Wei Yongjun, > >> From: Wei Yongjun >> >> Fix to return -ENODEV in the request dma error case instead >> of 0, as done elsewhere in this function. >> >> Signed-off-by: Wei Yongjun > > Seems ok to me. > > Reviewed-by: Marek Vasut Thanks, push

Re: [PATCH -next] mmc: dw_mmc: fix error return code in dw_mci_probe()

2013-05-26 Thread Chris Ball
Hi, On Tue, Apr 23 2013, Seungwon Jeon wrote: > On Friday, April 19, 2013 , Wei Yongjun wrote: >> From: Wei Yongjun >> >> Fix to return -ENOMEM in alloc workqueue error case instead >> of 0, as done elsewhere in this function. >> >> Signed-off-by: Wei Yongjun > > Acked-by: Seungwon Jeon Than

Re: [PATCH] Add method for triggering Sanitize command

2013-05-26 Thread Chris Ball
Hi, On Wed, Mar 20 2013, Yaniv Gardi wrote: > This patch adds a method to trigger Sanitize command to MMC. > The Sanitize command is used for deleting the unmapped memory region > of the MMC device. > > Signed-off-by: Yaniv Gardi Thanks, pushed to mmc-utils. - Chris. -- Chris Ball

Re: [PATCH v1] mmc-utils: adding support for Android compilation

2013-05-26 Thread Chris Ball
Hi, On Wed, Apr 24 2013, Yaniv Gardi wrote: > Signed-off-by: Yaniv Gardi > --- > Android.mk | 11 +++ > 1 files changed, 11 insertions(+), 0 deletions(-) > create mode 100644 Android.mk > > diff --git a/Android.mk b/Android.mk > new file mode 100644 > index 000..7c8cce4 > --- /dev

Re: [PATCH v3] mmc: card: Adding support for sanitize in eMMC 4.5

2013-05-26 Thread Chris Ball
Hi Maya, On Thu, Apr 18 2013, Maya Erez wrote: > The sanitize support is added as a user-app ioctl call, and > was removed from the block-device request, since its purpose is > to be invoked not via File-System but by a user. > This feature deletes the unmap memory region of the eMMC card, > by wr

Re: [RESEND PATCH] mmc: core: Re-use code for MMC_CAP2_DETECT_ON_ERR in polling mode

2013-05-26 Thread Chris Ball
Hi, On Thu, Apr 18 2013, Ulf Hansson wrote: > From: Ulf Hansson > > Previously the MMC_CAP2_DETECT_ON_ERR was invented for detecting > slow card removal. In was never a realy good solution and a proper > fix has been merged using gpio debouncing instead. We remove this > cap in this patch. > > Al

Re: [PATCH] mmc: core: Only execute tuning for SDR50 and SDR104

2013-05-26 Thread Chris Ball
Hi, On Wed, Apr 17 2013, Fredrik Soderstedt wrote: > Only execute tuning for sd and sdio devices that are using > SDR50 or SDR104. > > Make sure clock is hold during tuning for sdio devices. > > Signed-off-by: Fredrik Soderstedt Thanks, pushed to mmc-next for 3.11. - Chris. -- Chris Ball

Re: [PATCH v2] mmc: sdhci-esdhc-imx: fix multiblock reads on i.MX53

2013-05-26 Thread Chris Ball
Hi, On Fri, Mar 15 2013, Lucas Stach wrote: > The eSDHC controller on the i.MX53 needs an additional, non spec > compliant CMD12 after a multiblock read with a predefined number of > blocks. Otherwise the internal state machine won't go back to the > idle state. > > This commit effectively reverts

Re: [PATCH] mmc: sdhci-esdhc-imx: Fix SDIO interrupts

2013-05-26 Thread Chris Ball
Hi Martin, On Mon, Apr 15 2013, Martin Fuzzey wrote: > Currently SDIO interrupts do not work on i.MX53 and maybe others. > > This was observed with a Marvell 8787 based SDIO wifi adapter > using the mwifiex driver and firmware from the Marvell git > repository. > The symptom was a timeout after fi

[PATCH 1/1] mmc: of_mmc_spi: fix card detect irq

2013-05-26 Thread Jean-Christophe PLAGNIOL-VILLARD
set missing irq type the IRQF_ONESHOT Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD Cc: stable # 3.4+ Cc: linux-mmc@vger.kernel.org --- drivers/mmc/host/of_mmc_spi.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/of_mmc_spi.c b/drivers/mmc/host/of_